Re: [PATCHv2] Bluetooth: Fix not sending link key negative reply

[Johan Hedberg <johan.hedberg@gmail.com>]

Hi Andrei,

On Tue, May 07, 2013, Andrei Emeltchenko wrote:
> If Link Keys are not loaded during initialization with
> MGMT_OP_LOAD_LINK_KEYS command then pairing always fails
> since HCI_LINK_KEYS is not set. Check instead for HCI_MGMT
> flag.
> 
> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> ---
> *v2 modified patch following Johan's comments

The existing behavior is intentional with the implicit assumption that a
mgmt_load_link_keys will always be received, if only to set the debug
keys flag in case of no link keys. So I'd word the commit message
differently, something like:

	Bluetooth: Use HCI_MGMT flag for link keys management

	The HCI_MGMT flag should be enough to test for a user space that
	expects the kernel to do link keys management. Checking for the
	special HCI_LINK_KEYS flag is a bit overkill for this since we
	don't strictly speaking need to receive the load_link_keys
	command to know that user space talks mgmt - any mgmt command
	should be enough.

Johan