All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 2/2] Bluetooth: Use HCI_MGMT instead of HCI_LINK_KEYS flag
Date: Tue, 7 May 2013 14:41:16 +0300	[thread overview]
Message-ID: <20130507114116.GA11873@x220> (raw)
In-Reply-To: <1367926547-8279-2-git-send-email-Andrei.Emeltchenko.news@gmail.com>

Hi Andrei,

On Tue, May 07, 2013, Andrei Emeltchenko wrote:
> --- a/net/bluetooth/hci_event.c
> +++ b/net/bluetooth/hci_event.c
> @@ -2687,7 +2687,7 @@ static void hci_link_key_notify_evt(struct hci_dev *hdev, struct sk_buff *skb)
>  		hci_conn_drop(conn);
>  	}
>  
> -	if (test_bit(HCI_LINK_KEYS, &hdev->dev_flags))
> +	if (test_bit(HCI_MGMT, &hdev->dev_flags))
>  		hci_add_link_key(hdev, conn, 1, &ev->bdaddr, ev->link_key,
>  				 ev->key_type, pin_len);
>  

It seems to me that this chunk would be more appropriately merged to the
first patch.

Johan

  reply	other threads:[~2013-05-07 11:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-06 13:50 [RFC] Bluetooth: Fix not sending link key negative reply Andrei Emeltchenko
2013-05-07  6:06 ` Johan Hedberg
2013-05-07 10:51   ` [PATCHv2] " Andrei Emeltchenko
2013-05-07 11:14     ` Johan Hedberg
2013-05-07 11:35       ` [PATCH 1/2] Bluetooth: Use HCI_MGMT flag for link keys management Andrei Emeltchenko
2013-05-07 11:35         ` [PATCH 2/2] Bluetooth: Use HCI_MGMT instead of HCI_LINK_KEYS flag Andrei Emeltchenko
2013-05-07 11:41           ` Johan Hedberg [this message]
2013-05-07 11:57             ` [PATCH] " Andrei Emeltchenko
2013-05-14  8:44             ` [PATCHv2 1/2] " Andrei Emeltchenko
2013-05-14  8:44               ` [PATCHv2 2/2] Bluetooth: Remove unneeded flag Andrei Emeltchenko
2013-05-14  9:03                 ` Johan Hedberg
2013-05-20 20:59                 ` Gustavo Padovan
2013-05-20 21:44                   ` Gustavo Padovan
2013-05-14  9:02               ` [PATCHv2 1/2] Bluetooth: Use HCI_MGMT instead of HCI_LINK_KEYS flag Johan Hedberg
2013-05-20 20:58               ` Gustavo Padovan
2013-05-07 12:51       ` [PATCHv2] Bluetooth: Fix not sending link key negative reply Andrei Emeltchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130507114116.GA11873@x220 \
    --to=johan.hedberg@gmail.com \
    --cc=Andrei.Emeltchenko.news@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.