From: Robert Richter <rric@kernel.org>
To: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
linux-kernel@vger.kernel.org,
SH-Run Zhen RZ Wang <rzwang@cn.ibm.com>
Subject: Re: [PATCH] perf tools: Fix perf version generation
Date: Wed, 8 May 2013 13:06:11 +0200 [thread overview]
Message-ID: <20130508110611.GA8356@rric.localhost> (raw)
In-Reply-To: <518A2B4B.4040509@linux.vnet.ibm.com>
On 08.05.13 18:39:07, Xiao Guangrong wrote:
> I remember that Wang has posted a similar patch to fix this bug several
> weeks ago:
> http://lkml.org/lkml/2013/4/24/70
>
> But have no response yet.
Yes, this patch would fix the version tag too.
The patch I wrote also reports a commit id even in the case when no
tag is found. This was the original reason why I stumbled over this.
Assume a repository for testing there you just push the commit id to.
This does not contain any tags but a valid commit id. Now, it
determines the version tag from the makefile but does not drop the
commit id.
-Robert
next prev parent reply other threads:[~2013-05-08 11:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-08 9:43 [PATCH] perf tools: Fix perf version generation Robert Richter
2013-05-08 10:39 ` Xiao Guangrong
2013-05-08 11:06 ` Robert Richter [this message]
2013-05-08 14:01 ` Runzhen Wang
2013-05-10 9:09 ` Robert Richter
2013-07-01 8:24 ` Borislav Petkov
2013-07-12 8:52 ` [tip:perf/urgent] " tip-bot for Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130508110611.GA8356@rric.localhost \
--to=rric@kernel.org \
--cc=acme@ghostprotocols.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rzwang@cn.ibm.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.