All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xiao Guangrong <xiaoguangrong@linux.vnet.ibm.com>
To: Robert Richter <rric@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	linux-kernel@vger.kernel.org,
	Robert Richter <robert.richter@calxeda.com>,
	SH-Run Zhen RZ Wang <rzwang@cn.ibm.com>
Subject: Re: [PATCH] perf tools: Fix perf version generation
Date: Wed, 08 May 2013 18:39:07 +0800	[thread overview]
Message-ID: <518A2B4B.4040509@linux.vnet.ibm.com> (raw)
In-Reply-To: <1368006214-12912-1-git-send-email-rric@kernel.org>

On 05/08/2013 05:43 PM, Robert Richter wrote:
> From: Robert Richter <robert.richter@calxeda.com>
> 
> The tag of the perf version is wrongly determined, always the latest
> tag is taken regardless of the HEAD commit:
> 
>  $ perf --version
>  perf version 3.9.rc8.gd7f5d3
>  $ git describe d7f5d3
>  v3.9-rc7-154-gd7f5d33
>  $ head -n 4 Makefile
>  VERSION = 3
>  PATCHLEVEL = 9
>  SUBLEVEL = 0
>  EXTRAVERSION = -rc7
> 
> In other cases no tag might be found.
> 
> This patch fixes this.
> 
> This new implementation handles also the case if there are no tags at
> all found in the git repo but there is a commit id.

I remember that Wang has posted a similar patch to fix this bug several
weeks ago:
	http://lkml.org/lkml/2013/4/24/70

But have no response yet.


  reply	other threads:[~2013-05-08 10:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-08  9:43 [PATCH] perf tools: Fix perf version generation Robert Richter
2013-05-08 10:39 ` Xiao Guangrong [this message]
2013-05-08 11:06   ` Robert Richter
2013-05-08 14:01     ` Runzhen Wang
2013-05-10  9:09       ` Robert Richter
2013-07-01  8:24 ` Borislav Petkov
2013-07-12  8:52 ` [tip:perf/urgent] " tip-bot for Robert Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=518A2B4B.4040509@linux.vnet.ibm.com \
    --to=xiaoguangrong@linux.vnet.ibm.com \
    --cc=acme@ghostprotocols.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robert.richter@calxeda.com \
    --cc=rric@kernel.org \
    --cc=rzwang@cn.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.