From: holt@sgi.com (Robin Holt)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH -v8 11/11] Move arch/x86 reboot= handling to generic kernel.
Date: Thu, 9 May 2013 06:29:41 -0500 [thread overview]
Message-ID: <20130509112941.GV3672@sgi.com> (raw)
In-Reply-To: <20130508182304.GP18614@n2100.arm.linux.org.uk>
On Wed, May 08, 2013 at 07:23:05PM +0100, Russell King - ARM Linux wrote:
> On Tue, May 07, 2013 at 09:39:55AM -0500, Robin Holt wrote:
> > + case 's':
> > + reboot_mode = REBOOT_WARM;
> > + case 'h':
> > + reboot_mode = REBOOT_COLD;
> > + case 'g':
> > + reboot_mode = REBOOT_GPIO;
>
> Further to Ingo's comments, also note that the above is broken. Any
> of s,h,g will result in REBOOT_GPIO being set which is clearly wrong.
I couldn't be more of an idiot. I will fix it in -v9.
Robin
WARNING: multiple messages have this Message-ID (diff)
From: Robin Holt <holt@sgi.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Robin Holt <holt@sgi.com>,
Andrew Morton <akpm@linux-foundation.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Guan Xuetao <gxt@mprc.pku.edu.cn>, Russ Anderson <rja@sgi.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
the arch/x86 maintainers <x86@kernel.org>,
Arm Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH -v8 11/11] Move arch/x86 reboot= handling to generic kernel.
Date: Thu, 9 May 2013 06:29:41 -0500 [thread overview]
Message-ID: <20130509112941.GV3672@sgi.com> (raw)
In-Reply-To: <20130508182304.GP18614@n2100.arm.linux.org.uk>
On Wed, May 08, 2013 at 07:23:05PM +0100, Russell King - ARM Linux wrote:
> On Tue, May 07, 2013 at 09:39:55AM -0500, Robin Holt wrote:
> > + case 's':
> > + reboot_mode = REBOOT_WARM;
> > + case 'h':
> > + reboot_mode = REBOOT_COLD;
> > + case 'g':
> > + reboot_mode = REBOOT_GPIO;
>
> Further to Ingo's comments, also note that the above is broken. Any
> of s,h,g will result in REBOOT_GPIO being set which is clearly wrong.
I couldn't be more of an idiot. I will fix it in -v9.
Robin
next prev parent reply other threads:[~2013-05-09 11:29 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 14:39 [PATCH -v8 00/11] Shutdown from reboot_cpuid without stopping other cpus Robin Holt
2013-05-07 14:39 ` Robin Holt
2013-05-07 14:39 ` [PATCH -v8 01/11] CPU hotplug: Provide a generic helper to disable/enable CPU hotplug Robin Holt
2013-05-07 14:39 ` Robin Holt
2013-05-09 22:01 ` Andrew Morton
2013-05-09 22:01 ` Andrew Morton
2013-05-10 11:11 ` Rafael J. Wysocki
2013-05-10 11:11 ` Rafael J. Wysocki
2013-05-10 17:03 ` Andrew Morton
2013-05-10 17:03 ` Andrew Morton
2013-05-11 4:16 ` Robin Holt
2013-05-11 4:16 ` Robin Holt
2013-05-11 9:13 ` Srivatsa S. Bhat
2013-05-11 9:13 ` Srivatsa S. Bhat
2013-05-11 9:49 ` Robin Holt
2013-05-11 9:49 ` Robin Holt
2013-05-07 14:39 ` [PATCH -v8 02/11] Migrate shutdown/reboot to boot cpu Robin Holt
2013-05-07 14:39 ` Robin Holt
2013-05-07 14:39 ` [PATCH -v8 03/11] Remove -stable friendly PF_THREAD_BOUND define Robin Holt
2013-05-07 14:39 ` Robin Holt
2013-05-07 14:39 ` [PATCH -v8 04/11] Move shutdown/reboot related functions to kernel/reboot.c Robin Holt
2013-05-07 14:39 ` Robin Holt
2013-05-07 14:39 ` [PATCH -v8 05/11] checkpatch.pl the new kernel/reboot.c file Robin Holt
2013-05-07 14:39 ` Robin Holt
2013-05-07 14:39 ` [PATCH -v8 06/11] x86, prepare reboot_mode for moving to generic kernel code Robin Holt
2013-05-07 14:39 ` Robin Holt
2013-05-07 14:39 ` [PATCH -v8 07/11] unicore32, " Robin Holt
2013-05-07 14:39 ` Robin Holt
2013-05-07 14:39 ` [PATCH -v8 08/11] arm, Remove unused restart_mode fields from some arm subarchs Robin Holt
2013-05-07 14:39 ` Robin Holt
2013-05-07 14:39 ` [PATCH -v8 09/11] arm, prepare reboot_mode for moving to generic kernel code Robin Holt
2013-05-07 14:39 ` Robin Holt
2013-05-07 14:39 ` [PATCH -v8 10/11] arm, change reboot_mode to use enum reboot_mode Robin Holt
2013-05-07 14:39 ` Robin Holt
2013-05-07 14:39 ` [PATCH -v8 11/11] Move arch/x86 reboot= handling to generic kernel Robin Holt
2013-05-07 14:39 ` Robin Holt
2013-05-08 10:39 ` Ingo Molnar
2013-05-08 10:39 ` Ingo Molnar
2013-05-08 18:20 ` Russell King - ARM Linux
2013-05-08 18:20 ` Russell King - ARM Linux
2013-05-08 18:33 ` H. Peter Anvin
2013-05-08 18:33 ` H. Peter Anvin
2013-05-09 11:20 ` Robin Holt
2013-05-09 11:20 ` Robin Holt
2013-05-09 13:01 ` Robin Holt
2013-05-09 13:01 ` Robin Holt
2013-05-09 13:36 ` Russell King - ARM Linux
2013-05-09 13:36 ` Russell King - ARM Linux
2013-05-09 15:59 ` Robin Holt
2013-05-09 15:59 ` Robin Holt
2013-05-08 18:23 ` Russell King - ARM Linux
2013-05-08 18:23 ` Russell King - ARM Linux
2013-05-09 11:29 ` Robin Holt [this message]
2013-05-09 11:29 ` Robin Holt
2013-05-08 20:50 ` Andrew Morton
2013-05-08 20:50 ` Andrew Morton
2013-05-09 11:29 ` Robin Holt
2013-05-09 11:29 ` Robin Holt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130509112941.GV3672@sgi.com \
--to=holt@sgi.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.