From: Mark Brown <broonie@kernel.org>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Ming Lei <tom.leiming@gmail.com>,
Saravana Kannan <skannan@codeaurora.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mike Turquette <mturquette@linaro.org>,
Liam Girdwood <lrg@ti.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
Stephen Boyd <sboyd@codeaurora.org>
Subject: Re: [PATCH 1/3] driver core: Add API to wait for deferred probe to complete during init
Date: Thu, 9 May 2013 14:50:17 +0100 [thread overview]
Message-ID: <20130509135017.GD3200@sirena.org.uk> (raw)
In-Reply-To: <CACxGe6uHBNUcbD9SeRP5c3E8NN-Z2yjVV+9VAhuoJnXoBtTu2w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 819 bytes --]
On Thu, May 09, 2013 at 12:50:46PM +0100, Grant Likely wrote:
> However, if a device that shuts down resources after init has
> completed and then cannot turn those resources back on when another
> driver requests them then it sounds like there is a bigger design
> problem. We're in a hotplug world and most of the time a driver cannot
> assume that a resource will never get requested after initcalls have
> completed. It sounds like a design bug in the driver if it cannot
> handle that use case.
Even if the driver copes fine it can still be desirable to avoid the
power down/up cycle if it involves some user visible effect - things
like blinking the display off then on for example. That said I am a
little suspicious about this approach, it doesn't feel as robust as it
should to go round individual callers.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] driver core: Add API to wait for deferred probe to complete during init
Date: Thu, 9 May 2013 14:50:17 +0100 [thread overview]
Message-ID: <20130509135017.GD3200@sirena.org.uk> (raw)
In-Reply-To: <CACxGe6uHBNUcbD9SeRP5c3E8NN-Z2yjVV+9VAhuoJnXoBtTu2w@mail.gmail.com>
On Thu, May 09, 2013 at 12:50:46PM +0100, Grant Likely wrote:
> However, if a device that shuts down resources after init has
> completed and then cannot turn those resources back on when another
> driver requests them then it sounds like there is a bigger design
> problem. We're in a hotplug world and most of the time a driver cannot
> assume that a resource will never get requested after initcalls have
> completed. It sounds like a design bug in the driver if it cannot
> handle that use case.
Even if the driver copes fine it can still be desirable to avoid the
power down/up cycle if it involves some user visible effect - things
like blinking the display off then on for example. That said I am a
little suspicious about this approach, it doesn't feel as robust as it
should to go round individual callers.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130509/a652d63c/attachment.sig>
next prev parent reply other threads:[~2013-05-09 13:50 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 5:18 [PATCH 0/3] Fix disable of unused clk/regulator with deferred probe Saravana Kannan
2013-05-09 5:18 ` Saravana Kannan
2013-05-09 5:18 ` [PATCH 1/3] driver core: Add API to wait for deferred probe to complete during init Saravana Kannan
2013-05-09 5:18 ` Saravana Kannan
2013-05-09 10:07 ` Ming Lei
2013-05-09 10:07 ` Ming Lei
2013-05-09 11:50 ` Grant Likely
2013-05-09 11:50 ` Grant Likely
2013-05-09 13:50 ` Mark Brown [this message]
2013-05-09 13:50 ` Mark Brown
2013-05-09 14:14 ` Russell King - ARM Linux
2013-05-09 14:14 ` Russell King - ARM Linux
2013-05-09 14:37 ` Mark Brown
2013-05-09 14:37 ` Mark Brown
2013-05-09 15:07 ` Russell King - ARM Linux
2013-05-09 15:07 ` Russell King - ARM Linux
2013-05-09 15:43 ` Mark Brown
2013-05-09 15:43 ` Mark Brown
2013-05-09 18:39 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-09 18:39 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-09 18:39 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-09 16:39 ` Grant Likely
2013-05-09 16:39 ` Grant Likely
2013-05-10 9:30 ` Mark Brown
2013-05-10 9:30 ` Mark Brown
2013-05-09 16:52 ` Saravana Kannan
2013-05-09 16:52 ` Saravana Kannan
2013-05-09 18:09 ` Grant Likely
2013-05-09 18:09 ` Grant Likely
2013-05-09 18:12 ` Saravana Kannan
2013-05-09 18:12 ` Saravana Kannan
2013-05-09 14:32 ` Ming Lei
2013-05-09 14:32 ` Ming Lei
2013-05-09 5:18 ` [PATCH 2/3] clk: Disable unused clocks after deferred probing is done Saravana Kannan
2013-05-09 5:18 ` Saravana Kannan
2013-05-09 5:18 ` [PATCH 3/3] regulator: core: Disable unused regulators " Saravana Kannan
2013-05-09 5:18 ` Saravana Kannan
2013-05-09 18:35 ` [PATCH v2 1/2] clk: Disable unused clocks " Saravana Kannan
2013-05-09 18:35 ` Saravana Kannan
2013-05-10 6:45 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-10 6:45 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-10 23:03 ` Saravana Kannan
2013-05-10 23:03 ` Saravana Kannan
2013-05-22 10:35 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-22 10:35 ` Jean-Christophe PLAGNIOL-VILLARD
2013-05-16 4:34 ` Saravana Kannan
2013-05-16 4:34 ` Saravana Kannan
2013-05-16 12:55 ` Ulf Hansson
2013-05-16 12:55 ` Ulf Hansson
2013-05-16 19:23 ` Saravana Kannan
2013-05-16 19:23 ` Saravana Kannan
2013-05-29 7:51 ` Mike Turquette
2013-05-29 7:51 ` Mike Turquette
2013-05-30 1:46 ` Saravana Kannan
2013-05-30 1:46 ` Saravana Kannan
2013-05-30 1:46 ` Saravana Kannan
2013-05-09 18:35 ` [PATCH 2/2] regulator: core: Disable unused regulators " Saravana Kannan
2013-05-09 18:35 ` Saravana Kannan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130509135017.GD3200@sirena.org.uk \
--to=broonie@kernel.org \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=mturquette@linaro.org \
--cc=sboyd@codeaurora.org \
--cc=skannan@codeaurora.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.