From: holt@sgi.com (Robin Holt)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH -v9 04/11] Move shutdown/reboot related functions to kernel/reboot.c
Date: Thu, 9 May 2013 19:05:53 -0500 [thread overview]
Message-ID: <20130510000552.GX3658@sgi.com> (raw)
In-Reply-To: <20130509135100.13947d1805a583703ee8488b@linux-foundation.org>
On Thu, May 09, 2013 at 01:51:00PM -0700, Andrew Morton wrote:
> On Thu, 9 May 2013 14:23:18 -0500 Robin Holt <holt@sgi.com> wrote:
>
> > This patch is preparatory. It moves reboot related syscall, etc
> > functions from kernel/sys.c to kernel/reboot.c.
>
> This doesn't apply.
Weird, I just grabbed a recent Linus kernel tree and all 11 applied.
I then did an update to linus' tree to commit 70eba4226 and now I get
rejects on arm. I will resubmit a -v10 fixed up shortly.
Robin
>
> > -static void migrate_to_reboot_cpu(void)
> > -{
> > - /* The boot cpu is always logical cpu 0 */
> > - int cpu = 0;
> > -
> > - cpu_hotplug_disable();
> > -
> > - /* Make certain the cpu I'm about to reboot on is online */
> > - if (!cpu_online(cpu))
> > - cpu = cpumask_first(cpu_online_mask);
>
> Here it's deleting code which was already modified by "[PATCH -v9
> 02/11] Migrate shutdown/reboot to boot cpu.". So patch [4/11]
> generates rejects when applied on top of [patch 2/11].
>
> There are several similar glitches.
WARNING: multiple messages have this Message-ID (diff)
From: Robin Holt <holt@sgi.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Robin Holt <holt@sgi.com>, "H. Peter Anvin" <hpa@zytor.com>,
Russ Anderson <rja@sgi.com>,
Russell King <linux@arm.linux.org.uk>,
Guan Xuetao <gxt@mprc.pku.edu.cn>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
the arch/x86 maintainers <x86@kernel.org>,
Arm Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH -v9 04/11] Move shutdown/reboot related functions to kernel/reboot.c
Date: Thu, 9 May 2013 19:05:53 -0500 [thread overview]
Message-ID: <20130510000552.GX3658@sgi.com> (raw)
In-Reply-To: <20130509135100.13947d1805a583703ee8488b@linux-foundation.org>
On Thu, May 09, 2013 at 01:51:00PM -0700, Andrew Morton wrote:
> On Thu, 9 May 2013 14:23:18 -0500 Robin Holt <holt@sgi.com> wrote:
>
> > This patch is preparatory. It moves reboot related syscall, etc
> > functions from kernel/sys.c to kernel/reboot.c.
>
> This doesn't apply.
Weird, I just grabbed a recent Linus kernel tree and all 11 applied.
I then did an update to linus' tree to commit 70eba4226 and now I get
rejects on arm. I will resubmit a -v10 fixed up shortly.
Robin
>
> > -static void migrate_to_reboot_cpu(void)
> > -{
> > - /* The boot cpu is always logical cpu 0 */
> > - int cpu = 0;
> > -
> > - cpu_hotplug_disable();
> > -
> > - /* Make certain the cpu I'm about to reboot on is online */
> > - if (!cpu_online(cpu))
> > - cpu = cpumask_first(cpu_online_mask);
>
> Here it's deleting code which was already modified by "[PATCH -v9
> 02/11] Migrate shutdown/reboot to boot cpu.". So patch [4/11]
> generates rejects when applied on top of [patch 2/11].
>
> There are several similar glitches.
next prev parent reply other threads:[~2013-05-10 0:05 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 19:23 [PATCH -v8 00/11] Shutdown from reboot_cpuid without stopping other cpus Robin Holt
2013-05-09 19:23 ` Robin Holt
2013-05-09 19:23 ` [PATCH -v9 01/11] CPU hotplug: Provide a generic helper to disable/enable CPU hotplug Robin Holt
2013-05-09 19:23 ` Robin Holt
2013-05-09 19:23 ` [PATCH -v9 02/11] Migrate shutdown/reboot to boot cpu Robin Holt
2013-05-09 19:23 ` Robin Holt
2013-05-09 19:23 ` [PATCH -v9 03/11] Remove -stable friendly PF_THREAD_BOUND define Robin Holt
2013-05-09 19:23 ` Robin Holt
2013-05-09 19:23 ` [PATCH -v9 04/11] Move shutdown/reboot related functions to kernel/reboot.c Robin Holt
2013-05-09 19:23 ` Robin Holt
2013-05-09 20:51 ` Andrew Morton
2013-05-09 20:51 ` Andrew Morton
2013-05-10 0:05 ` Robin Holt [this message]
2013-05-10 0:05 ` Robin Holt
2013-05-10 9:50 ` Robin Holt
2013-05-10 9:50 ` Robin Holt
2013-05-09 19:23 ` [PATCH -v9 05/11] checkpatch.pl the new kernel/reboot.c file Robin Holt
2013-05-09 19:23 ` Robin Holt
2013-05-09 19:23 ` [PATCH -v9 06/11] x86, prepare reboot_mode for moving to generic kernel code Robin Holt
2013-05-09 19:23 ` Robin Holt
2013-05-09 19:23 ` [PATCH -v9 07/11] unicore32, " Robin Holt
2013-05-09 19:23 ` Robin Holt
2013-05-10 15:05 ` Xuetao Guan
2013-05-10 15:05 ` Xuetao Guan
2013-05-09 19:23 ` [PATCH -v9 08/11] arm, Remove unused restart_mode fields from some arm subarchs Robin Holt
2013-05-09 19:23 ` Robin Holt
2013-05-09 19:23 ` [PATCH -v9 09/11] arm, prepare reboot_mode for moving to generic kernel code Robin Holt
2013-05-09 19:23 ` Robin Holt
2013-05-09 19:23 ` [PATCH -v9 10/11] arm, change reboot_mode to use enum reboot_mode Robin Holt
2013-05-09 19:23 ` Robin Holt
2013-05-09 19:23 ` [PATCH -v9 11/11] Move arch/x86 reboot= handling to generic kernel Robin Holt
2013-05-09 19:23 ` Robin Holt
2013-05-10 7:06 ` [PATCH -v8 00/11] Shutdown from reboot_cpuid without stopping other cpus Ingo Molnar
2013-05-10 7:06 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130510000552.GX3658@sgi.com \
--to=holt@sgi.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.