From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: guaneryu@gmail.com, ext4 development <linux-ext4@vger.kernel.org>,
xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: regression test for ext4 resize with non-extent files
Date: Fri, 10 May 2013 14:55:44 +1000 [thread overview]
Message-ID: <20130510045544.GQ23072@dastard> (raw)
In-Reply-To: <518C6414.20800@redhat.com>
On Thu, May 09, 2013 at 10:05:56PM -0500, Eric Sandeen wrote:
> On 5/9/13 10:03 PM, Eryu Guan wrote:
> > On Fri, May 10, 2013 at 6:02 AM, Eric Sandeen <sandeen@redhat.com <mailto:sandeen@redhat.com>> wrote:
> >
>
> ...
>
> > index 53af708..4c3e2f4 100644
> > --- a/tests/ext4/group
> > +++ b/tests/ext4/group
> > @@ -9,3 +9,4 @@
> > 303 aio dangerous ioctl rw stress
> > 304 aio dangerous ioctl rw stress
> > 305 auto
> > +306 dangerous rw resize quick
> >
> >
> > I'm wondering why it's not in auto group :)
>
>
> because I forgot about auto! :)
>
> But it's also somewhat dangerous; it could oops or hang, so perhaps
> auto is not a good idea.
If the bug has already been fixed, then auto rather than dangerous
should be used. If the hang/panic cannot be fixed, or is going to
take some time to be fixed, that's when dangerous should be used.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>,
guaneryu@gmail.com, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: regression test for ext4 resize with non-extent files
Date: Fri, 10 May 2013 14:55:44 +1000 [thread overview]
Message-ID: <20130510045544.GQ23072@dastard> (raw)
In-Reply-To: <518C6414.20800@redhat.com>
On Thu, May 09, 2013 at 10:05:56PM -0500, Eric Sandeen wrote:
> On 5/9/13 10:03 PM, Eryu Guan wrote:
> > On Fri, May 10, 2013 at 6:02 AM, Eric Sandeen <sandeen@redhat.com <mailto:sandeen@redhat.com>> wrote:
> >
>
> ...
>
> > index 53af708..4c3e2f4 100644
> > --- a/tests/ext4/group
> > +++ b/tests/ext4/group
> > @@ -9,3 +9,4 @@
> > 303 aio dangerous ioctl rw stress
> > 304 aio dangerous ioctl rw stress
> > 305 auto
> > +306 dangerous rw resize quick
> >
> >
> > I'm wondering why it's not in auto group :)
>
>
> because I forgot about auto! :)
>
> But it's also somewhat dangerous; it could oops or hang, so perhaps
> auto is not a good idea.
If the bug has already been fixed, then auto rather than dangerous
should be used. If the hang/panic cannot be fixed, or is going to
take some time to be fixed, that's when dangerous should be used.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-05-10 4:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 22:02 [PATCH] xfstests: regression test for ext4 resize with non-extent files Eric Sandeen
2013-05-09 22:02 ` Eric Sandeen
2013-05-10 3:03 ` Eryu Guan
2013-05-10 3:05 ` Eric Sandeen
2013-05-10 4:55 ` Dave Chinner [this message]
2013-05-10 4:55 ` Dave Chinner
2013-05-10 13:23 ` [PATCH V2] " Eric Sandeen
2013-05-10 13:23 ` Eric Sandeen
2013-05-14 10:00 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130510045544.GQ23072@dastard \
--to=david@fromorbit.com \
--cc=guaneryu@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.