Re: [LTP] [PATCH 2/2]semctl/semctl01.c: Test features IPC_INFO, SEM_INFO and SEM_STAT

[Mike Frysinger <vapier@gentoo.org>]

[-- Attachment #1.1: Type: Text/Plain, Size: 1275 bytes --]

On Friday 10 May 2013 04:30:00 Wanlong Gao wrote:
> On 05/10/2013 12:20 AM, Mike Frysinger wrote:
> > On Thursday 09 May 2013 09:32:32 chrubis@suse.cz wrote:
> >>> +#ifdef __linux__
> >>> +int TST_TOTAL = 13;
> >>> +#else
> >>> 
> >>>  int TST_TOTAL = 10;
> >>> 
> >>> +#endif
> >>> 
> >>>  static int sem_id_1 = -1;
> >>> 
> >>> @@ -57,8 +65,14 @@ static void func_sval(void);
> >>> 
> >>>  static void func_rmid(void);
> >>>  static void child_cnt(void);
> >>>  static void child_pid(void);
> >>> 
> >>> +#ifdef __linux__
> >>> +static void func_iinfo(int);
> >>> +static void func_sinfo(void);
> >>> +static void func_sstat(int);
> >>> +#endif
> >> 
> >> Well the only part of the LTP that we promise that will build and run on
> >> anything else than Linux is Open Posix Testsuite, so in my opinion these
> >> ifdefs are not needed. Has anybody different opinion?
> > 
> > i agree -- drop the __linux__ check, especially under testcases/kernel/
> > ... the "kernel" there is "linux".
> 
> So, you mean drop the "sgi" as well?

scrubbing it from testcases/kernel/syscalls/sighold/sighold02.c makes sense.  
SGI is dead and so is IRIX.  if they want to run tests against their system, 
then can download an older version of LTP.
-mike

[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 403 bytes --]

------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and 
their applications. This 200-page book is written by three acclaimed 
leaders in the field. The early access version is available now. 
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may

[-- Attachment #3: Type: text/plain, Size: 155 bytes --]

_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list