From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
To: Mike Frysinger <vapier@gentoo.org>
Cc: ltp-list@lists.sourceforge.net
Subject: Re: [LTP] [PATCH 2/2]semctl/semctl01.c: Test features IPC_INFO, SEM_INFO and SEM_STAT
Date: Fri, 10 May 2013 16:30:00 +0800 [thread overview]
Message-ID: <518CB008.5080402@cn.fujitsu.com> (raw)
In-Reply-To: <201305091220.44861.vapier@gentoo.org>
On 05/10/2013 12:20 AM, Mike Frysinger wrote:
> On Thursday 09 May 2013 09:32:32 chrubis@suse.cz wrote:
>>> +#ifdef __linux__
>>> +int TST_TOTAL = 13;
>>> +#else
>>> int TST_TOTAL = 10;
>>> +#endif
>>> static int sem_id_1 = -1;
>>> @@ -57,8 +65,14 @@ static void func_sval(void);
>>> static void func_rmid(void);
>>> static void child_cnt(void);
>>> static void child_pid(void);
>>> +#ifdef __linux__
>>> +static void func_iinfo(int);
>>> +static void func_sinfo(void);
>>> +static void func_sstat(int);
>>> +#endif
>>
>> Well the only part of the LTP that we promise that will build and run on
>> anything else than Linux is Open Posix Testsuite, so in my opinion these
>> ifdefs are not needed. Has anybody different opinion?
>
> i agree -- drop the __linux__ check, especially under testcases/kernel/ ...
> the "kernel" there is "linux".
So, you mean drop the "sgi" as well?
Thanks,
Wanlong Gao
> -mike
>
>
>
> ------------------------------------------------------------------------------
> Learn Graph Databases - Download FREE O'Reilly Book
> "Graph Databases" is the definitive new guide to graph databases and
> their applications. This 200-page book is written by three acclaimed
> leaders in the field. The early access version is available now.
> Download your free book today! http://p.sf.net/sfu/neotech_d2d_may
>
>
>
> _______________________________________________
> Ltp-list mailing list
> Ltp-list@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/ltp-list
>
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and
their applications. This 200-page book is written by three acclaimed
leaders in the field. The early access version is available now.
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list
next prev parent reply other threads:[~2013-05-10 8:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-09 8:42 [LTP] [PATCH 1/2]semctl/semctl01.c: cleanup DAN LI
2013-05-09 8:46 ` [LTP] [PATCH 2/2]semctl/semctl01.c: Test features IPC_INFO, SEM_INFO and SEM_STAT DAN LI
2013-05-09 13:32 ` chrubis
[not found] ` <201305091220.44861.vapier@gentoo.org>
2013-05-10 8:30 ` Wanlong Gao [this message]
2013-05-10 15:36 ` Mike Frysinger
2013-05-13 2:28 ` Wanlong Gao
2013-05-09 16:22 ` [LTP] [PATCH 1/2]semctl/semctl01.c: cleanup Mike Frysinger
2013-05-10 2:35 ` DAN LI
2013-05-10 15:27 ` Mike Frysinger
2013-05-13 11:23 ` chrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518CB008.5080402@cn.fujitsu.com \
--to=gaowanlong@cn.fujitsu.com \
--cc=ltp-list@lists.sourceforge.net \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.