Re: [PATCH 1/3] Add pciutils to the console package

[Denys Dmytriyenko <denys@ti.com>]

Oh, and the commit message should be of the proper format:

packagegroup-arago-console: add pciutils

Please see this past post about the same:
http://arago-project.org/pipermail/meta-arago/2013-May/001373.html

-- 
Denys


On Fri, May 10, 2013 at 09:55:12AM -0400, Denys Dmytriyenko wrote:
> Sam,
> 
> See below.
> 
> On Fri, May 10, 2013 at 01:43:44PM +0000, Nelson, Sam wrote:
> > Thanks for the response.
> > Pciutils provides very basic utilities for pci, when you have pci interface 
> > supported in the platform. ( I guess this is common).  There was customer 
> > request to have it in a minimal file system.
> > 
> > If it does not belong in here. Please suggest any alternate recipes where 
> > this will naturally belong.
> > 
> > There is only 1 patch, I wanted to send.  The other patches are not 
> > relevant, please ignore.
> > 
> > With regards,
> > sam
> > 
> > 
> > -----Original Message-----
> > From: Maupin, Chase 
> > Sent: Friday, May 10, 2013 9:26 AM
> > To: Nelson, Sam; meta-arago@arago-project.org
> > Subject: RE: [meta-arago] [PATCH 1/3] Add pciutils to the console package
> > 
> > >-----Original Message-----
> > >From: meta-arago-bounces@arago-project.org [mailto:meta-arago- 
> > >bounces@arago-project.org] On Behalf Of Nelson, Sam
> > >Sent: Friday, May 10, 2013 5:47 AM
> > >To: meta-arago@arago-project.org
> > >Subject: [meta-arago] [PATCH 1/3] Add pciutils to the console package
> > 
> > Why are you adding this to the console package?  That is supposed to be a 
> > small package so what is the use case for adding this here instead of 
> > somewhere else?
> > 
> > Also, I didn't see patches 2 and 3 of this set.  Did I miss them?
> > 
> > >
> > >Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> > >---
> > > .../packagegroups/packagegroup-arago-console.bb    |    1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > >diff --git a/meta-arago-distro/recipes- 
> > >core/packagegroups/packagegroup-arago-console.bb b/meta-arago- 
> > >distro/recipes-core/packagegroups/packagegroup-arago-console.bb
> > >index 5a80064..930049a 100755
> > >--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-
> > >arago-console.bb
> > >+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-
> > >arago-console.bb
> > >@@ -25,6 +25,7 @@ ARAGO_UTILS = "\
> > >     i2c-tools \
> > >     iproute2 \
> > >     strace \
> > >+    pciutils \
> 
>     ${@base_contains('MACHINE_FEATURES', 'pci', 'pciutils', '',d)} \
> 
> And don't forget to add "pci" to the list of MACHINE_FEATURES for your machine 
> "keystone-evm" or better yet to your SOC "keystone", if it's a common 
> peripheral for all Keystone devices.
> 
> > You would need to bump the PR
> 
> Agree, make sure you bump PR on every recipe change.
> 
> -- 
> Denys
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago