* [PATCH 1/3] Add pciutils to the console package
@ 2013-05-10 10:46 Sam Nelson
2013-05-10 13:25 ` Maupin, Chase
0 siblings, 1 reply; 6+ messages in thread
From: Sam Nelson @ 2013-05-10 10:46 UTC (permalink / raw)
To: meta-arago
Signed-off-by: Sam Nelson <sam.nelson@ti.com>
---
.../packagegroups/packagegroup-arago-console.bb | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb
index 5a80064..930049a 100755
--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb
@@ -25,6 +25,7 @@ ARAGO_UTILS = "\
i2c-tools \
iproute2 \
strace \
+ pciutils \
"
ARAGO_SDK_PREREQ = "\
--
1.7.9.5
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] Add pciutils to the console package
2013-05-10 10:46 [PATCH 1/3] Add pciutils to the console package Sam Nelson
@ 2013-05-10 13:25 ` Maupin, Chase
2013-05-10 13:43 ` Nelson, Sam
0 siblings, 1 reply; 6+ messages in thread
From: Maupin, Chase @ 2013-05-10 13:25 UTC (permalink / raw)
To: Nelson, Sam, meta-arago@arago-project.org
>-----Original Message-----
>From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
>bounces@arago-project.org] On Behalf Of Nelson, Sam
>Sent: Friday, May 10, 2013 5:47 AM
>To: meta-arago@arago-project.org
>Subject: [meta-arago] [PATCH 1/3] Add pciutils to the console
>package
Why are you adding this to the console package? That is supposed to be a small package so what is the use case for adding this here instead of somewhere else?
Also, I didn't see patches 2 and 3 of this set. Did I miss them?
>
>Signed-off-by: Sam Nelson <sam.nelson@ti.com>
>---
> .../packagegroups/packagegroup-arago-console.bb | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/meta-arago-distro/recipes-
>core/packagegroups/packagegroup-arago-console.bb b/meta-arago-
>distro/recipes-core/packagegroups/packagegroup-arago-console.bb
>index 5a80064..930049a 100755
>--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-
>arago-console.bb
>+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-
>arago-console.bb
>@@ -25,6 +25,7 @@ ARAGO_UTILS = "\
> i2c-tools \
> iproute2 \
> strace \
>+ pciutils \
You would need to bump the PR
> "
>
> ARAGO_SDK_PREREQ = "\
>--
>1.7.9.5
>
>_______________________________________________
>meta-arago mailing list
>meta-arago@arago-project.org
>http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] Add pciutils to the console package
2013-05-10 13:25 ` Maupin, Chase
@ 2013-05-10 13:43 ` Nelson, Sam
2013-05-10 13:46 ` Cooper Jr., Franklin
2013-05-10 13:55 ` Denys Dmytriyenko
0 siblings, 2 replies; 6+ messages in thread
From: Nelson, Sam @ 2013-05-10 13:43 UTC (permalink / raw)
To: Maupin, Chase, meta-arago@arago-project.org
Thanks for the response.
Pciutils provides very basic utilities for pci, when you have pci interface supported in the platform. ( I guess this is common). There was customer request to have it in a minimal file system.
If it does not belong in here. Please suggest any alternate recipes where this will naturally belong.
There is only 1 patch, I wanted to send. The other patches are not relevant, please ignore.
With regards,
sam
-----Original Message-----
From: Maupin, Chase
Sent: Friday, May 10, 2013 9:26 AM
To: Nelson, Sam; meta-arago@arago-project.org
Subject: RE: [meta-arago] [PATCH 1/3] Add pciutils to the console package
>-----Original Message-----
>From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
>bounces@arago-project.org] On Behalf Of Nelson, Sam
>Sent: Friday, May 10, 2013 5:47 AM
>To: meta-arago@arago-project.org
>Subject: [meta-arago] [PATCH 1/3] Add pciutils to the console package
Why are you adding this to the console package? That is supposed to be a small package so what is the use case for adding this here instead of somewhere else?
Also, I didn't see patches 2 and 3 of this set. Did I miss them?
>
>Signed-off-by: Sam Nelson <sam.nelson@ti.com>
>---
> .../packagegroups/packagegroup-arago-console.bb | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/meta-arago-distro/recipes-
>core/packagegroups/packagegroup-arago-console.bb b/meta-arago-
>distro/recipes-core/packagegroups/packagegroup-arago-console.bb
>index 5a80064..930049a 100755
>--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-
>arago-console.bb
>+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-
>arago-console.bb
>@@ -25,6 +25,7 @@ ARAGO_UTILS = "\
> i2c-tools \
> iproute2 \
> strace \
>+ pciutils \
You would need to bump the PR
> "
>
> ARAGO_SDK_PREREQ = "\
>--
>1.7.9.5
>
>_______________________________________________
>meta-arago mailing list
>meta-arago@arago-project.org
>http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] Add pciutils to the console package
2013-05-10 13:43 ` Nelson, Sam
@ 2013-05-10 13:46 ` Cooper Jr., Franklin
2013-05-10 13:55 ` Denys Dmytriyenko
1 sibling, 0 replies; 6+ messages in thread
From: Cooper Jr., Franklin @ 2013-05-10 13:46 UTC (permalink / raw)
To: Nelson, Sam, Maupin, Chase, meta-arago@arago-project.org
Not all machines support PCI so it isn't a good fit to force all machines to include this utility.
Use something like below:
ARAGO_UTILS_append_<machine> = "pci"
This will insure only the machine you care about is picking up this utility.
You also forgot to bump the PR.
> -----Original Message-----
> From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> bounces@arago-project.org] On Behalf Of Nelson, Sam
> Sent: Friday, May 10, 2013 8:44 AM
> To: Maupin, Chase; meta-arago@arago-project.org
> Subject: Re: [meta-arago] [PATCH 1/3] Add pciutils to the console package
>
> Thanks for the response.
> Pciutils provides very basic utilities for pci, when you have pci interface
> supported in the platform. ( I guess this is common). There was customer
> request to have it in a minimal file system.
>
> If it does not belong in here. Please suggest any alternate recipes where this will
> naturally belong.
>
> There is only 1 patch, I wanted to send. The other patches are not relevant,
> please ignore.
>
> With regards,
> sam
>
>
> -----Original Message-----
> From: Maupin, Chase
> Sent: Friday, May 10, 2013 9:26 AM
> To: Nelson, Sam; meta-arago@arago-project.org
> Subject: RE: [meta-arago] [PATCH 1/3] Add pciutils to the console package
>
> >-----Original Message-----
> >From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> >bounces@arago-project.org] On Behalf Of Nelson, Sam
> >Sent: Friday, May 10, 2013 5:47 AM
> >To: meta-arago@arago-project.org
> >Subject: [meta-arago] [PATCH 1/3] Add pciutils to the console package
>
> Why are you adding this to the console package? That is supposed to be a small
> package so what is the use case for adding this here instead of somewhere else?
>
> Also, I didn't see patches 2 and 3 of this set. Did I miss them?
>
> >
> >Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> >---
> > .../packagegroups/packagegroup-arago-console.bb | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >diff --git a/meta-arago-distro/recipes-
> >core/packagegroups/packagegroup-arago-console.bb b/meta-arago-
> >distro/recipes-core/packagegroups/packagegroup-arago-console.bb
> >index 5a80064..930049a 100755
> >--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-
> >arago-console.bb
> >+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-
> >arago-console.bb
> >@@ -25,6 +25,7 @@ ARAGO_UTILS = "\
> > i2c-tools \
> > iproute2 \
> > strace \
> >+ pciutils \
>
> You would need to bump the PR
>
> > "
> >
> > ARAGO_SDK_PREREQ = "\
> >--
> >1.7.9.5
> >
> >_______________________________________________
> >meta-arago mailing list
> >meta-arago@arago-project.org
> >http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] Add pciutils to the console package
2013-05-10 13:43 ` Nelson, Sam
2013-05-10 13:46 ` Cooper Jr., Franklin
@ 2013-05-10 13:55 ` Denys Dmytriyenko
2013-05-10 14:00 ` Denys Dmytriyenko
1 sibling, 1 reply; 6+ messages in thread
From: Denys Dmytriyenko @ 2013-05-10 13:55 UTC (permalink / raw)
To: Nelson, Sam; +Cc: meta-arago@arago-project.org
Sam,
See below.
On Fri, May 10, 2013 at 01:43:44PM +0000, Nelson, Sam wrote:
> Thanks for the response.
> Pciutils provides very basic utilities for pci, when you have pci interface
> supported in the platform. ( I guess this is common). There was customer
> request to have it in a minimal file system.
>
> If it does not belong in here. Please suggest any alternate recipes where
> this will naturally belong.
>
> There is only 1 patch, I wanted to send. The other patches are not
> relevant, please ignore.
>
> With regards,
> sam
>
>
> -----Original Message-----
> From: Maupin, Chase
> Sent: Friday, May 10, 2013 9:26 AM
> To: Nelson, Sam; meta-arago@arago-project.org
> Subject: RE: [meta-arago] [PATCH 1/3] Add pciutils to the console package
>
> >-----Original Message-----
> >From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> >bounces@arago-project.org] On Behalf Of Nelson, Sam
> >Sent: Friday, May 10, 2013 5:47 AM
> >To: meta-arago@arago-project.org
> >Subject: [meta-arago] [PATCH 1/3] Add pciutils to the console package
>
> Why are you adding this to the console package? That is supposed to be a
> small package so what is the use case for adding this here instead of
> somewhere else?
>
> Also, I didn't see patches 2 and 3 of this set. Did I miss them?
>
> >
> >Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> >---
> > .../packagegroups/packagegroup-arago-console.bb | 1 +
> > 1 file changed, 1 insertion(+)
> >
> >diff --git a/meta-arago-distro/recipes-
> >core/packagegroups/packagegroup-arago-console.bb b/meta-arago-
> >distro/recipes-core/packagegroups/packagegroup-arago-console.bb
> >index 5a80064..930049a 100755
> >--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-
> >arago-console.bb
> >+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-
> >arago-console.bb
> >@@ -25,6 +25,7 @@ ARAGO_UTILS = "\
> > i2c-tools \
> > iproute2 \
> > strace \
> >+ pciutils \
${@base_contains('MACHINE_FEATURES', 'pci', 'pciutils', '',d)} \
And don't forget to add "pci" to the list of MACHINE_FEATURES for your machine
"keystone-evm" or better yet to your SOC "keystone", if it's a common
peripheral for all Keystone devices.
> You would need to bump the PR
Agree, make sure you bump PR on every recipe change.
--
Denys
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] Add pciutils to the console package
2013-05-10 13:55 ` Denys Dmytriyenko
@ 2013-05-10 14:00 ` Denys Dmytriyenko
0 siblings, 0 replies; 6+ messages in thread
From: Denys Dmytriyenko @ 2013-05-10 14:00 UTC (permalink / raw)
To: Nelson, Sam; +Cc: meta-arago@arago-project.org
Oh, and the commit message should be of the proper format:
packagegroup-arago-console: add pciutils
Please see this past post about the same:
http://arago-project.org/pipermail/meta-arago/2013-May/001373.html
--
Denys
On Fri, May 10, 2013 at 09:55:12AM -0400, Denys Dmytriyenko wrote:
> Sam,
>
> See below.
>
> On Fri, May 10, 2013 at 01:43:44PM +0000, Nelson, Sam wrote:
> > Thanks for the response.
> > Pciutils provides very basic utilities for pci, when you have pci interface
> > supported in the platform. ( I guess this is common). There was customer
> > request to have it in a minimal file system.
> >
> > If it does not belong in here. Please suggest any alternate recipes where
> > this will naturally belong.
> >
> > There is only 1 patch, I wanted to send. The other patches are not
> > relevant, please ignore.
> >
> > With regards,
> > sam
> >
> >
> > -----Original Message-----
> > From: Maupin, Chase
> > Sent: Friday, May 10, 2013 9:26 AM
> > To: Nelson, Sam; meta-arago@arago-project.org
> > Subject: RE: [meta-arago] [PATCH 1/3] Add pciutils to the console package
> >
> > >-----Original Message-----
> > >From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> > >bounces@arago-project.org] On Behalf Of Nelson, Sam
> > >Sent: Friday, May 10, 2013 5:47 AM
> > >To: meta-arago@arago-project.org
> > >Subject: [meta-arago] [PATCH 1/3] Add pciutils to the console package
> >
> > Why are you adding this to the console package? That is supposed to be a
> > small package so what is the use case for adding this here instead of
> > somewhere else?
> >
> > Also, I didn't see patches 2 and 3 of this set. Did I miss them?
> >
> > >
> > >Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> > >---
> > > .../packagegroups/packagegroup-arago-console.bb | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > >diff --git a/meta-arago-distro/recipes-
> > >core/packagegroups/packagegroup-arago-console.bb b/meta-arago-
> > >distro/recipes-core/packagegroups/packagegroup-arago-console.bb
> > >index 5a80064..930049a 100755
> > >--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-
> > >arago-console.bb
> > >+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-
> > >arago-console.bb
> > >@@ -25,6 +25,7 @@ ARAGO_UTILS = "\
> > > i2c-tools \
> > > iproute2 \
> > > strace \
> > >+ pciutils \
>
> ${@base_contains('MACHINE_FEATURES', 'pci', 'pciutils', '',d)} \
>
> And don't forget to add "pci" to the list of MACHINE_FEATURES for your machine
> "keystone-evm" or better yet to your SOC "keystone", if it's a common
> peripheral for all Keystone devices.
>
> > You would need to bump the PR
>
> Agree, make sure you bump PR on every recipe change.
>
> --
> Denys
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-05-10 14:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-10 10:46 [PATCH 1/3] Add pciutils to the console package Sam Nelson
2013-05-10 13:25 ` Maupin, Chase
2013-05-10 13:43 ` Nelson, Sam
2013-05-10 13:46 ` Cooper Jr., Franklin
2013-05-10 13:55 ` Denys Dmytriyenko
2013-05-10 14:00 ` Denys Dmytriyenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.