Re: [PATCH] libxl: Make 'xl vcpu-set' work properly on overcommited hosts.

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

On Wed, May 08, 2013 at 05:03:53PM +0100, Ian Jackson wrote:
> Konrad Rzeszutek Wilk writes ("Re: [Xen-devel] [PATCH] libxl: Make 'xl vcpu-set' work properly on overcommited hosts."):
> > Note that all of the libxl_cpu_bitmap_[test|set] silently ignore
> > any test or sets above its size:
> > 
> >      if (bit >= bitmap->size * 8)
> >          return 0;
> > 
> > so we were never notified off this bug.
> 
> I hadn't spotted that.  Arguably "return 0" should be "abort()".

I am really hesistant about doing this in Xen 4.3. There are a bunch
of places where this is used and I fear this will cause tons of
asserts and more bugs to crep up which will make George MAD!!!


I can certainly prep a patch for Xen 4.4 and slowly fix the fallout.
> 
> > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> 
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

Is that for adding an assert or to the patch?
> 
> Thanks,
> Ian.
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
>