Re: [PATCH] fix grub-install efibootmgr presence test with --removable

[Andrey Borzenkov <arvidjaar@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 1178 bytes --]

В Sat, 11 May 2013 08:49:00 +0200
Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> пишет:

> On 11.05.2013 06:43, Andrey Borzenkov wrote:
> 
> > В Fri, 10 May 2013 16:57:38 +0200
> > Vladimir 'φ-coder/phcoder' Serbinenko <phcoder@gmail.com> пишет:
> > 
> >> On 09.05.2013 12:44, Leif Lindholm wrote:
> >>
> >>> When executed for an EFI target, grub-install checks for the path of
> >>> efibootmgr - however, this utility is not required (or used) when
> >>> installing to a removable media (with --removable).
> >>>
> >>
> >> This patch would simply ignore the problem. I comitted another fix which
> >> is cleaner.
> >>
> > 
> > Note that "which command" already prints error message when command was
> > not found, so additional error output is strictly speaking redundant.
> > 
> 
> It doesn't.
> phcoder@debian.x201.phnet:08:48:40:~$ which ttt
> phcoder@debian.x201.phnet:08:48:41:~$
> 

This is probably system dependent

bor@opensuse:~> which xxx
which: no xxx in (/home/bor/bin:/usr/local/bin:/usr/bin:/bin:/usr/bin/X11:/usr/X11R6/bin:/usr/games)

I guess in this case it is better to redirect stderr to /dev/null

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 198 bytes --]