All of lore.kernel.org
 help / color / mirror / Atom feed
From: holt@sgi.com (Robin Holt)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH -v10 00/11] Shutdown from reboot_cpuid without stopping other cpus.
Date: Sat, 11 May 2013 07:49:00 -0500	[thread overview]
Message-ID: <20130511124900.GA3672@sgi.com> (raw)
In-Reply-To: <1368273447-11958-1-git-send-email-holt@sgi.com>

I will resubmit a -v11 with Russell's comment about the wrongly added
^// in a bit.

Robin

On Sat, May 11, 2013 at 06:57:16AM -0500, Robin Holt wrote:
> We recently noticed that reboot of a 1024 cpu machine takes approx 16
> minutes of just stopping the cpus.  The slowdown was tracked to commit
> f96972f.
> 
> The current implementation does all the work of hot removing the cpus
> before halting the system.  We are switching to just migrating to the
> reboot_cpu and then continuing with shutdown/reboot.
> 
> The patch set is broken into eleven parts.  The first two are planned for
> the stable release.  The others move the halt/shutdown/reboot related
> functions to their own kernel/reboot.c file and then move the handling
> of the kernel reboot= kernel parameter to generic kernel code.
> 
> Changes since -v9
>  - Added Ingo's Acked-by for x86.
> 
>  - Added Guan's Acked-by for unicore32.
> 
>  - Replaced first patch with updated patch from Srivatsa S. Bhat.
>    This compiles for alpha allmodconfig, all arm defconfigs, and a few
>    test x86_64 defconfigs.  I have not tried more.
> 
> Changes since -v8
>  - Changes reboot_cpu on stack to cpu to fix bug noticed by Russell King.
> 
>  - Switched unicore32 and arm from using REBOOT_WARM/COLD to HARD/SOFT.
> 
>  - Fixed case statement bug.
> 
>  - Went to using simple_strtoul for parsing reboot_cpu=smp###.
> 
>  - Made parsing of reboot= not use any #ifdef'd code.
> 
> Changes since -v7.
>  - Fixed authorship for first patch.
> 
>  - Rebased to Linus' current tree (51a26ae7a).
> 
> Changes since -v6.
>  - Cross compiled all arm architectures (using v3.9 kernel.  Fails with
>    current).
> 
>  - Added a #define for non-hotplug case.
> 
>  - Add #define for PF_THREAD_BOUND as compatibility to make stable easier.
> 
>  - Fixup s/reboot_cpu_id/reboot_cpu/
> 
>  - Add include of linux/uaccess.h to allow building on arm.
> 
>  - Removed last remaining checkpatch.pl line length warning on
>    kernel/reboot.c.
> 
>  - Fixed the duplicate handling or the reboot= kernel parameter.
> 
> Changes since -v5.
>  - Moved the arch/x86 reboot= up to the generic kernel code.
> 
> Changes since -v4.
>  - Integrated Srivatsa S. Bhat creating cpu_hotplug_disable()
>    function
> 
>  - Integrated comments by Srivatsa S. Bhat.
> 
>  - Made one more comment consistent with others in function.
> 
> Changes since -v3.
>  - Added a tested-by for the original reporter.
> 
>  - Fix compile failure found by Joe Perches.
> 
>  - Integrated comments by Joe Perches.
> 
> 
> To: Andrew Morton <akpm@linux-foundation.org>
> Cc: H. Peter Anvin <hpa@zytor.com>
> Cc: Russ Anderson <rja@sgi.com>
> Cc: Robin Holt <holt@sgi.com>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>
> Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
> Cc: the arch/x86 maintainers <x86@kernel.org>
> Cc: Arm Mailing List <linux-arm-kernel@lists.infradead.org>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

WARNING: multiple messages have this Message-ID (diff)
From: Robin Holt <holt@sgi.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "H. Peter Anvin" <hpa@zytor.com>, Russ Anderson <rja@sgi.com>,
	Robin Holt <holt@sgi.com>, Russell King <linux@arm.linux.org.uk>,
	Guan Xuetao <gxt@mprc.pku.edu.cn>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	the arch/x86 maintainers <x86@kernel.org>,
	Arm Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH -v10 00/11] Shutdown from reboot_cpuid without stopping other cpus.
Date: Sat, 11 May 2013 07:49:00 -0500	[thread overview]
Message-ID: <20130511124900.GA3672@sgi.com> (raw)
In-Reply-To: <1368273447-11958-1-git-send-email-holt@sgi.com>

I will resubmit a -v11 with Russell's comment about the wrongly added
^// in a bit.

Robin

On Sat, May 11, 2013 at 06:57:16AM -0500, Robin Holt wrote:
> We recently noticed that reboot of a 1024 cpu machine takes approx 16
> minutes of just stopping the cpus.  The slowdown was tracked to commit
> f96972f.
> 
> The current implementation does all the work of hot removing the cpus
> before halting the system.  We are switching to just migrating to the
> reboot_cpu and then continuing with shutdown/reboot.
> 
> The patch set is broken into eleven parts.  The first two are planned for
> the stable release.  The others move the halt/shutdown/reboot related
> functions to their own kernel/reboot.c file and then move the handling
> of the kernel reboot= kernel parameter to generic kernel code.
> 
> Changes since -v9
>  - Added Ingo's Acked-by for x86.
> 
>  - Added Guan's Acked-by for unicore32.
> 
>  - Replaced first patch with updated patch from Srivatsa S. Bhat.
>    This compiles for alpha allmodconfig, all arm defconfigs, and a few
>    test x86_64 defconfigs.  I have not tried more.
> 
> Changes since -v8
>  - Changes reboot_cpu on stack to cpu to fix bug noticed by Russell King.
> 
>  - Switched unicore32 and arm from using REBOOT_WARM/COLD to HARD/SOFT.
> 
>  - Fixed case statement bug.
> 
>  - Went to using simple_strtoul for parsing reboot_cpu=smp###.
> 
>  - Made parsing of reboot= not use any #ifdef'd code.
> 
> Changes since -v7.
>  - Fixed authorship for first patch.
> 
>  - Rebased to Linus' current tree (51a26ae7a).
> 
> Changes since -v6.
>  - Cross compiled all arm architectures (using v3.9 kernel.  Fails with
>    current).
> 
>  - Added a #define for non-hotplug case.
> 
>  - Add #define for PF_THREAD_BOUND as compatibility to make stable easier.
> 
>  - Fixup s/reboot_cpu_id/reboot_cpu/
> 
>  - Add include of linux/uaccess.h to allow building on arm.
> 
>  - Removed last remaining checkpatch.pl line length warning on
>    kernel/reboot.c.
> 
>  - Fixed the duplicate handling or the reboot= kernel parameter.
> 
> Changes since -v5.
>  - Moved the arch/x86 reboot= up to the generic kernel code.
> 
> Changes since -v4.
>  - Integrated Srivatsa S. Bhat creating cpu_hotplug_disable()
>    function
> 
>  - Integrated comments by Srivatsa S. Bhat.
> 
>  - Made one more comment consistent with others in function.
> 
> Changes since -v3.
>  - Added a tested-by for the original reporter.
> 
>  - Fix compile failure found by Joe Perches.
> 
>  - Integrated comments by Joe Perches.
> 
> 
> To: Andrew Morton <akpm@linux-foundation.org>
> Cc: H. Peter Anvin <hpa@zytor.com>
> Cc: Russ Anderson <rja@sgi.com>
> Cc: Robin Holt <holt@sgi.com>
> Cc: Russell King <linux@arm.linux.org.uk>
> Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>
> Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
> Cc: the arch/x86 maintainers <x86@kernel.org>
> Cc: Arm Mailing List <linux-arm-kernel@lists.infradead.org>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

  parent reply	other threads:[~2013-05-11 12:49 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-11 11:57 [PATCH -v10 00/11] Shutdown from reboot_cpuid without stopping other cpus Robin Holt
2013-05-11 11:57 ` Robin Holt
2013-05-11 11:57 ` [PATCH -v10 01/11] CPU hotplug: Provide a generic helper to disable/enable CPU hotplug Robin Holt
2013-05-11 11:57   ` Robin Holt
2013-05-11 11:57 ` [PATCH -v10 02/11] Migrate shutdown/reboot to boot cpu Robin Holt
2013-05-11 11:57   ` Robin Holt
2013-05-11 11:57 ` [PATCH -v10 03/11] Remove -stable friendly PF_THREAD_BOUND define Robin Holt
2013-05-11 11:57   ` Robin Holt
2013-05-11 11:57 ` [PATCH -v10 04/11] Move shutdown/reboot related functions to kernel/reboot.c Robin Holt
2013-05-11 11:57   ` Robin Holt
2013-05-11 11:57 ` [PATCH -v10 05/11] checkpatch.pl the new kernel/reboot.c file Robin Holt
2013-05-11 11:57   ` Robin Holt
2013-05-11 11:57 ` [PATCH -v10 06/11] x86, prepare reboot_mode for moving to generic kernel code Robin Holt
2013-05-11 11:57   ` Robin Holt
2013-05-11 11:57 ` [PATCH -v10 07/11] unicore32, " Robin Holt
2013-05-11 11:57   ` Robin Holt
2013-05-11 11:57 ` [PATCH -v10 08/11] arm, Remove unused restart_mode fields from some arm subarchs Robin Holt
2013-05-11 11:57   ` Robin Holt
2013-05-11 12:27   ` Russell King - ARM Linux
2013-05-11 12:27     ` Russell King - ARM Linux
2013-05-11 11:57 ` [PATCH -v10 09/11] arm, prepare reboot_mode for moving to generic kernel code Robin Holt
2013-05-11 11:57   ` Robin Holt
2013-05-11 13:04   ` Russell King - ARM Linux
2013-05-11 13:04     ` Russell King - ARM Linux
2013-05-11 15:47     ` H. Peter Anvin
2013-05-11 15:47       ` H. Peter Anvin
2013-05-11 19:10       ` Russell King - ARM Linux
2013-05-11 19:10         ` Russell King - ARM Linux
2013-05-12  2:49         ` H. Peter Anvin
2013-05-12  2:49           ` H. Peter Anvin
2013-05-11 11:57 ` [PATCH -v10 10/11] arm, change reboot_mode to use enum reboot_mode Robin Holt
2013-05-11 11:57   ` Robin Holt
2013-05-11 12:27   ` Russell King - ARM Linux
2013-05-11 12:27     ` Russell King - ARM Linux
2013-05-11 11:57 ` [PATCH -v10 11/11] Move arch/x86 reboot= handling to generic kernel Robin Holt
2013-05-11 11:57   ` Robin Holt
2013-05-11 12:28   ` Russell King - ARM Linux
2013-05-11 12:28     ` Russell King - ARM Linux
2013-05-11 12:29 ` [PATCH -v10 00/11] Shutdown from reboot_cpuid without stopping other cpus Russell King - ARM Linux
2013-05-11 12:29   ` Russell King - ARM Linux
2013-05-11 12:49 ` Robin Holt [this message]
2013-05-11 12:49   ` Robin Holt
  -- strict thread matches above, loose matches on Subject: below --
2013-05-11  1:58 Robin Holt
2013-05-11  1:58 ` Robin Holt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130511124900.GA3672@sgi.com \
    --to=holt@sgi.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.