From: Denys Dmytriyenko <denys@ti.com>
To: Sam Nelson <sam.nelson@ti.com>
Cc: meta-arago@arago-project.org
Subject: Re: [PATCH] Recipe: Adding pciutils package
Date: Tue, 14 May 2013 12:54:28 -0400 [thread overview]
Message-ID: <20130514165428.GD18680@edge> (raw)
In-Reply-To: <1368536896-27356-1-git-send-email-sam.nelson@ti.com>
On Tue, May 14, 2013 at 09:08:16AM -0400, Sam Nelson wrote:
> pciutils provides very basic utilities for
> querying the devices on the pci bus, when pci
> interface is supported in the platform and
> useful to be part of the console package
Sam,
This looks very good!
Few more nit-picks:
0. Again, the subject line should follow the OE Community guidelines:
http://openembedded.org/wiki/Commit_Patch_Message_Guidelines
We've discussed it already here:
http://arago-project.org/pipermail/meta-arago/2013-May/001373.html
1. If you are re-sending a new revision of the patch, please update the
subject to contain [PATCHv2] or [PATCHv3] etc. Also you can log the changes
between patch revisions after --- mark.
2. This recipe now becomes machine-specifci, so please add at the top:
PACKAGE_ARCH = "${MACHINE_ARCH}"
3. And please don't forget to add "pci" to the list of MACHINE_FEATURES for
your machine (keystone-evm.conf) or better yet your SOC (keystone.inc)
--
Denys
> Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> ---
> .../packagegroups/packagegroup-arago-console.bb | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb
> index 5a80064..ceee77e 100755
> --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb
> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb
> @@ -1,6 +1,6 @@
> DESCRIPTION = "Extended task to get more basic and console apps"
> LICENSE = "MIT"
> -PR = "r5"
> +PR = "r6"
>
> inherit packagegroup
>
> @@ -25,6 +25,7 @@ ARAGO_UTILS = "\
> i2c-tools \
> iproute2 \
> strace \
> + ${@base_contains('MACHINE_FEATURES', 'pci', 'pciutils', '',d)} \
> "
>
> ARAGO_SDK_PREREQ = "\
> --
> 1.7.9.5
>
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
next prev parent reply other threads:[~2013-05-14 16:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 13:08 [PATCH] Recipe: Adding pciutils package Sam Nelson
2013-05-14 16:54 ` Denys Dmytriyenko [this message]
[not found] ` <4F9216F96E5DF9428610502835A9F4905491F683@DLEE11.ent.ti.com>
2013-05-14 23:40 ` Denys Dmytriyenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130514165428.GD18680@edge \
--to=denys@ti.com \
--cc=meta-arago@arago-project.org \
--cc=sam.nelson@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.