[PATCH] Recipe: Adding pciutils package

[PATCH] Recipe: Adding pciutils package

[Sam Nelson]

   pciutils provides very basic utilities for
   querying the devices on the pci bus, when pci
   interface is supported in the platform and
   useful to be part of the console package

Signed-off-by: Sam Nelson <sam.nelson@ti.com>
---
 .../packagegroups/packagegroup-arago-console.bb    |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb
index 5a80064..ceee77e 100755
--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb
@@ -1,6 +1,6 @@
 DESCRIPTION = "Extended task to get more basic and console apps"
 LICENSE = "MIT"
-PR = "r5"
+PR = "r6"
 
 inherit packagegroup
 
@@ -25,6 +25,7 @@ ARAGO_UTILS = "\
     i2c-tools \
     iproute2 \
     strace \
+    ${@base_contains('MACHINE_FEATURES', 'pci', 'pciutils', '',d)} \
     "
 
 ARAGO_SDK_PREREQ = "\
-- 
1.7.9.5

Re: [PATCH] Recipe: Adding pciutils package

[Denys Dmytriyenko]

On Tue, May 14, 2013 at 09:08:16AM -0400, Sam Nelson wrote:
>    pciutils provides very basic utilities for
>    querying the devices on the pci bus, when pci
>    interface is supported in the platform and
>    useful to be part of the console package

Sam,

This looks very good!

Few more nit-picks:

0. Again, the subject line should follow the OE Community guidelines:
http://openembedded.org/wiki/Commit_Patch_Message_Guidelines
We've discussed it already here:
http://arago-project.org/pipermail/meta-arago/2013-May/001373.html

1. If you are re-sending a new revision of the patch, please update the 
subject to contain [PATCHv2] or [PATCHv3] etc. Also you can log the changes 
between patch revisions after --- mark.

2. This recipe now becomes machine-specifci, so please add at the top:
PACKAGE_ARCH = "${MACHINE_ARCH}"

3. And please don't forget to add "pci" to the list of MACHINE_FEATURES for 
your machine (keystone-evm.conf) or better yet your SOC (keystone.inc)

-- 
Denys


> Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> ---
>  .../packagegroups/packagegroup-arago-console.bb    |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb
> index 5a80064..ceee77e 100755
> --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb
> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb
> @@ -1,6 +1,6 @@
>  DESCRIPTION = "Extended task to get more basic and console apps"
>  LICENSE = "MIT"
> -PR = "r5"
> +PR = "r6"
>  
>  inherit packagegroup
>  
> @@ -25,6 +25,7 @@ ARAGO_UTILS = "\
>      i2c-tools \
>      iproute2 \
>      strace \
> +    ${@base_contains('MACHINE_FEATURES', 'pci', 'pciutils', '',d)} \
>      "
>  
>  ARAGO_SDK_PREREQ = "\
> -- 
> 1.7.9.5
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago

Re: [PATCH] Recipe: Adding pciutils package

[Denys Dmytriyenko]

Sam,

On Tue, May 14, 2013 at 02:34:45PM -0400, Nelson, Sam wrote:
> I am still new to this. So pardon my questions inline.

There's no shame in being new to this. But keeping discussion on the list 
might get you the answer quicker - some common things can be answered by 
other people and you don't have to wait for me to find a spare minute...

I hope you don't mind me copying the list, as this is useful information below 
for others as well.


> On Tue, May 14, 2013 at 09:08:16AM -0400, Sam Nelson wrote:
> >    pciutils provides very basic utilities for
> >    querying the devices on the pci bus, when pci
> >    interface is supported in the platform and
> >    useful to be part of the console package
> 
> Sam,
> 
> This looks very good!
> 
> Few more nit-picks:
> 
> 0. Again, the subject line should follow the OE Community guidelines:
> http://openembedded.org/wiki/Commit_Patch_Message_Guidelines
> We've discussed it already here:
> http://arago-project.org/pipermail/meta-arago/2013-May/001373.html
> 
> 1. If you are re-sending a new revision of the patch, please update the 
> subject to contain [PATCHv2] or [PATCHv3] etc. Also you can log the changes 
> between patch revisions after --- mark.
> >> How do I do this. I just use git send-email.  Appreciate your help.

There are few useful flags to git-format-patch:

 --subject-prefix=<Subject-Prefix>
     Instead of the standard [PATCH] prefix in the subject line, instead use
     [<Subject-Prefix>]. This allows for useful naming of a patch series, and 
     can be combined with the --numbered option.

 -v <n>, --reroll-count=<n>
     Mark the series as the <n>-th iteration of the topic. The output 
     filenames have v<n> prepended to them, and the subject prefix ("PATCH" by 
     default, but configurable via the --subject-prefix option) has ` v<n>` 
     appended to it. E.g. --reroll-count=4 may produce v4-0001-add-makefile.patch 
     file that has "Subject: [PATCH v4 1/20] Add makefile" in it.

 --notes[=<ref>]
     Append the notes (see git-notes(1)) for the commit after the three-dash 
     line.

     The expected use case of this is to write supporting explanation for the 
     commit that does not belong to the commit log message proper, and include 
     it with the patch submission. While one can simply write these 
     explanations after format-patch has run but before sending, keeping them 
     as Git notes allows them to be maintained between versions of the patch 
     series (but see the discussion of the notes.rewrite configuration options 
     in git-notes(1) to use this workflow).

But sometimes it's easier to make those changes manually, as long as you don't 
mangle the actual patch - make sure your text editor does not re-format the 
patch while editing, does not introduce new line breaks or wraps long lines.


> 2. This recipe now becomes machine-specifci, so please add at the top:
> PACKAGE_ARCH = "${MACHINE_ARCH}"
> >> DONE.

Good.


> 3. And please don't forget to add "pci" to the list of MACHINE_FEATURES for 
> your machine (keystone-evm.conf) or better yet your SOC (keystone.inc)

> Yes. I have taken care of this in the meta-ti keystone.inc. Thanks.

And please use proper quoting - sometimes it's hard to figure out if it's your 
comment or mine or someone else's from before...

-- 
Denys