All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Standardisation of $(BUILD)/.root name
Date: Wed, 15 May 2013 00:23:24 +0200	[thread overview]
Message-ID: <20130514222324.GA8043@free.fr> (raw)
In-Reply-To: <2999958.1S5Q3eWKd9@sagittae>

J?r?me, All,

On 2013-05-14 17:27 +0200, J?r?me Pouiller spake thusly:
> On Tuesday 14 May 2013 17:07:21 Thomas Petazzoni wrote:
> > Dear J?r?me Pouiller,
> > 
> > On Tue, 14 May 2013 16:30:50 +0200, J?r?me Pouiller wrote:
> > > -$(BUILD_DIR)/.root:
> > > 
> > > +$(STAMP_DIR)/skeleton-target-installed:
> > >  	mkdir -p $(TARGET_DIR)
> > >  	rsync -a \
> > >  	
> > >  		--exclude .empty --exclude .svn --exclude .git \
> > >  		--exclude .hg --exclude=CVS --exclude '*~' \
> > >  		$(TARGET_SKELETON)/ $(TARGET_DIR)/
> > >  	
> > >  	cp support/misc/target-dir-warning.txt $(TARGET_DIR_WARNING_FILE)
> > > 
> > > +	mkdir -p $(STAMP_DIR)
> > > 
> > >  	touch $@
> > 
> > I'm generally ok with the idea, but I don't like this mkdir. There is
> > already a mkdir that creates the stamp file directory, in the main
> > Makefile.
> I also dislike this mkdir. My problem is to be sure $(STAMP_DIR) is created 
> before $(STAMP_DIR)/skeleton-target-installed. 
> 
> I can change order of dependencies in dirs target but this solution is too 
> fragile.

Agreed, this is not-so-nice.

> I cannot just add a dependency between $(STAMP_DIR)/skeleton-target-installed 
> and  $(STAMP_DIR).

Why not? Like:
    $(STAMP_DIR)/skeleton-target-installed: $(STAMP_DIR)

which to me looks like the sane solution (and not what I previosuly
answered Arnout about $(TARGET_DIR))

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 223 225 172 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

  reply	other threads:[~2013-05-14 22:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-17 11:04 [Buildroot] Target rebuilding Jérôme Pouiller
2013-01-17 13:27 ` Stephan Hoffmann
2013-01-18  9:43   ` Jérôme Pouiller
2013-01-19 16:32 ` Arnout Vandecappelle
2013-05-14 14:30   ` [Buildroot] [PATCH] Standardisation of $(BUILD)/.root name Jérôme Pouiller
2013-05-14 15:07     ` Thomas Petazzoni
2013-05-14 15:27       ` Jérôme Pouiller
2013-05-14 22:23         ` Yann E. MORIN [this message]
2013-05-15  6:19           ` Jérôme Pouiller
2013-05-15  6:27             ` Jérôme Pouiller
2013-05-15 21:01               ` Yann E. MORIN
2013-05-15 20:59             ` Yann E. MORIN
2013-05-14 21:52       ` Arnout Vandecappelle
2013-05-14 22:06         ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130514222324.GA8043@free.fr \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.