All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] Target rebuilding
Date: Sat, 19 Jan 2013 17:32:15 +0100	[thread overview]
Message-ID: <50FACA8F.1040503@mind.be> (raw)
In-Reply-To: <4486164.oLnzyGq5cK@sagittae>

On 17/01/13 12:04, J?r?me Pouiller wrote:
> Hello all,
>
> It is handy to do tests directly in target/. But after some time, it is
> necessary to make a new fresh target/ directory. The current procedure to do
> this is:
>
> * remove build/.root (or remove target/ if you want to throw all your work)
> * remove build/*/.stamp_target_installed
> * depending of you toolchain:
>    # remove stamps/ext-toolchain-installed (external)
>    # remove stamps/ct-ng-toolchain-installed (ctng)
>    # remove target/lib/libc.so.0 (buildroot)
> * launch make
>
> I think this process lacks of consistency. Idealy, this process should be:
>    rm -r target (depending if want to throw all your work)
>    rm build/*/.stamp_target_installed
>    make

  I agree that it lacks consistency, and I'm in favour of improving the 
consistency of stamp files.

>
> I suggest following changes:
>
>   1. Move build/.root to stamps/. Since it is hidden, many user forget this
> file exist.

  ACK.

>
>   2. All stamps files are in subdirectories of build/. I suggest to move
> stamps/ to build/stamps/

  I'm not convinced that that improves the consistency. If build/.root 
moves to stamps, than all directories in build/ are build directories. 
That sounds like a good idea to me.


>   3. Buildroot toolchain should create a stamp files to be uniform with other
> toolchains. In add, target/lib/libc.so.0 never exists when PREFER_STATIC_LIB
> is enable.

  ACK

  Note that the buildroot toolchain is on the way out (though it will 
probably take 3 more years before it's really gone), so don't put too 
much effort into improving it.


>   4. To be consistent stamps/*-toolchain-installed may be renamed
> stamps/.stamp_target_installed or stamps/.stamp_toolchain_target_installed or
> toolchain/.stamp_target_installed. We may add a README file to explain what is
> purpose of this apparently empty directory.

  I don't agree with this one. build/*/.stamp_* is stuff that is created 
by the package infrastructure. The toolchain stuff is not in the package 
infrastructure. So I wouldn't let it use the same pattern for stamp files.


>    5. stamps/ext-toolchain-installed currently copy libc in staging/ and in
> target/. It may be splited in two rules: stamps/ext-toolchain-target-installed
> and stamps/ext-toolchain-staging-installed.

  It could be split, but what is the advantage of that?


> What do you think about it?

  Let's see some patches! :-)

  Regards,
  Arnout


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  parent reply	other threads:[~2013-01-19 16:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-17 11:04 [Buildroot] Target rebuilding Jérôme Pouiller
2013-01-17 13:27 ` Stephan Hoffmann
2013-01-18  9:43   ` Jérôme Pouiller
2013-01-19 16:32 ` Arnout Vandecappelle [this message]
2013-05-14 14:30   ` [Buildroot] [PATCH] Standardisation of $(BUILD)/.root name Jérôme Pouiller
2013-05-14 15:07     ` Thomas Petazzoni
2013-05-14 15:27       ` Jérôme Pouiller
2013-05-14 22:23         ` Yann E. MORIN
2013-05-15  6:19           ` Jérôme Pouiller
2013-05-15  6:27             ` Jérôme Pouiller
2013-05-15 21:01               ` Yann E. MORIN
2013-05-15 20:59             ` Yann E. MORIN
2013-05-14 21:52       ` Arnout Vandecappelle
2013-05-14 22:06         ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50FACA8F.1040503@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.