* [PATCHv3] arago-console: Adding pciutils package @ 2013-05-14 22:52 Nelson, Sam 2013-05-14 23:18 ` Denys Dmytriyenko 2013-05-15 3:53 ` Denys Dmytriyenko 0 siblings, 2 replies; 4+ messages in thread From: Nelson, Sam @ 2013-05-14 22:52 UTC (permalink / raw) To: meta-arago@arago-project.org pciutils provides very basic utilities for querying the devices on the pci bus, when pci interface is supported in the platform and useful to be part of the console package Signed-off-by: Sam Nelson <sam.nelson@ti.com> --- .../packagegroups/packagegroup-arago-console.bb | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb index 5a80064..537f050 100755 --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb @@ -1,6 +1,8 @@ DESCRIPTION = "Extended task to get more basic and console apps" LICENSE = "MIT" -PR = "r5" +PR = "r6" + +PACKAGE_ARCH = "${MACHINE_ARCH}" inherit packagegroup @@ -25,6 +27,7 @@ ARAGO_UTILS = "\ i2c-tools \ iproute2 \ strace \ + ${@base_contains('MACHINE_FEATURES', 'pci', 'pciutils', '',d)} \ " ARAGO_SDK_PREREQ = "\ -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCHv3] arago-console: Adding pciutils package 2013-05-14 22:52 [PATCHv3] arago-console: Adding pciutils package Nelson, Sam @ 2013-05-14 23:18 ` Denys Dmytriyenko 2013-05-15 3:53 ` Denys Dmytriyenko 1 sibling, 0 replies; 4+ messages in thread From: Denys Dmytriyenko @ 2013-05-14 23:18 UTC (permalink / raw) To: Nelson, Sam; +Cc: meta-arago@arago-project.org Perfect, thanks! I'm pushing it shortly. -- Denys On Tue, May 14, 2013 at 10:52:06PM +0000, Nelson, Sam wrote: > pciutils provides very basic utilities for > querying the devices on the pci bus, when pci > interface is supported in the platform and > useful to be part of the console package > > Signed-off-by: Sam Nelson <sam.nelson@ti.com> > --- > .../packagegroups/packagegroup-arago-console.bb | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb > index 5a80064..537f050 100755 > --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb > @@ -1,6 +1,8 @@ > DESCRIPTION = "Extended task to get more basic and console apps" > LICENSE = "MIT" > -PR = "r5" > +PR = "r6" > + > +PACKAGE_ARCH = "${MACHINE_ARCH}" > > inherit packagegroup > > @@ -25,6 +27,7 @@ ARAGO_UTILS = "\ > i2c-tools \ > iproute2 \ > strace \ > + ${@base_contains('MACHINE_FEATURES', 'pci', 'pciutils', '',d)} \ > " > > ARAGO_SDK_PREREQ = "\ > -- > 1.7.9.5 > > _______________________________________________ > meta-arago mailing list > meta-arago@arago-project.org > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCHv3] arago-console: Adding pciutils package 2013-05-14 22:52 [PATCHv3] arago-console: Adding pciutils package Nelson, Sam 2013-05-14 23:18 ` Denys Dmytriyenko @ 2013-05-15 3:53 ` Denys Dmytriyenko 2013-05-15 18:38 ` Nelson, Sam 1 sibling, 1 reply; 4+ messages in thread From: Denys Dmytriyenko @ 2013-05-15 3:53 UTC (permalink / raw) To: Nelson, Sam; +Cc: meta-arago@arago-project.org So, it only looked perfect, but there were still some issues and I had to massage the patch in, only because I already promised I'll take it... 1. You should submit patches against the mainline meta-arago, not against your forked and work-in-progress personal tree. I.e. your PR was at r5 already, while the one in meta-arago is at r4, and you appear to have removed ltrace from the list of ARAGO_UTILS. 2. The recipe in your tree has 755 permissions, which is wrong and happens when you edit files mounted from Windows. I see it quite a lot in your team and you should probably stop doing it... -- Denys On Tue, May 14, 2013 at 10:52:06PM +0000, Nelson, Sam wrote: > pciutils provides very basic utilities for > querying the devices on the pci bus, when pci > interface is supported in the platform and > useful to be part of the console package > > Signed-off-by: Sam Nelson <sam.nelson@ti.com> > --- > .../packagegroups/packagegroup-arago-console.bb | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb > index 5a80064..537f050 100755 > --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb > @@ -1,6 +1,8 @@ > DESCRIPTION = "Extended task to get more basic and console apps" > LICENSE = "MIT" > -PR = "r5" > +PR = "r6" > + > +PACKAGE_ARCH = "${MACHINE_ARCH}" > > inherit packagegroup > > @@ -25,6 +27,7 @@ ARAGO_UTILS = "\ > i2c-tools \ > iproute2 \ > strace \ > + ${@base_contains('MACHINE_FEATURES', 'pci', 'pciutils', '',d)} \ > " > > ARAGO_SDK_PREREQ = "\ > -- > 1.7.9.5 > > _______________________________________________ > meta-arago mailing list > meta-arago@arago-project.org > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCHv3] arago-console: Adding pciutils package 2013-05-15 3:53 ` Denys Dmytriyenko @ 2013-05-15 18:38 ` Nelson, Sam 0 siblings, 0 replies; 4+ messages in thread From: Nelson, Sam @ 2013-05-15 18:38 UTC (permalink / raw) To: Dmytriyenko, Denys; +Cc: meta-arago@arago-project.org Thanks Denys. I will pay attention to this . -----Original Message----- From: Dmytriyenko, Denys Sent: Tuesday, May 14, 2013 11:54 PM To: Nelson, Sam Cc: meta-arago@arago-project.org Subject: Re: [meta-arago] [PATCHv3] arago-console: Adding pciutils package So, it only looked perfect, but there were still some issues and I had to massage the patch in, only because I already promised I'll take it... 1. You should submit patches against the mainline meta-arago, not against your forked and work-in-progress personal tree. I.e. your PR was at r5 already, while the one in meta-arago is at r4, and you appear to have removed ltrace from the list of ARAGO_UTILS. 2. The recipe in your tree has 755 permissions, which is wrong and happens when you edit files mounted from Windows. I see it quite a lot in your team and you should probably stop doing it... -- Denys On Tue, May 14, 2013 at 10:52:06PM +0000, Nelson, Sam wrote: > pciutils provides very basic utilities for > querying the devices on the pci bus, when pci > interface is supported in the platform and > useful to be part of the console package > > Signed-off-by: Sam Nelson <sam.nelson@ti.com> > --- > .../packagegroups/packagegroup-arago-console.bb | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb > index 5a80064..537f050 100755 > --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-console.bb > @@ -1,6 +1,8 @@ > DESCRIPTION = "Extended task to get more basic and console apps" > LICENSE = "MIT" > -PR = "r5" > +PR = "r6" > + > +PACKAGE_ARCH = "${MACHINE_ARCH}" > > inherit packagegroup > > @@ -25,6 +27,7 @@ ARAGO_UTILS = "\ > i2c-tools \ > iproute2 \ > strace \ > + ${@base_contains('MACHINE_FEATURES', 'pci', 'pciutils', '',d)} \ > " > > ARAGO_SDK_PREREQ = "\ > -- > 1.7.9.5 > > _______________________________________________ > meta-arago mailing list > meta-arago@arago-project.org > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-05-15 18:38 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-05-14 22:52 [PATCHv3] arago-console: Adding pciutils package Nelson, Sam 2013-05-14 23:18 ` Denys Dmytriyenko 2013-05-15 3:53 ` Denys Dmytriyenko 2013-05-15 18:38 ` Nelson, Sam
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.