* [PATCH] packagegroup-arago-tisdk-matrix: remove ethernet menu from common apps
@ 2013-05-15 18:32 hzhang
2013-05-15 18:37 ` Denys Dmytriyenko
0 siblings, 1 reply; 5+ messages in thread
From: hzhang @ 2013-05-15 18:32 UTC (permalink / raw)
To: meta-arago
From: Hao Zhang <hzhang@ti.com>
---
.../packagegroup-arago-tisdk-matrix.bb | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-matrix.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-matrix.bb
index dda72af..2b40f98 100755
--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-matrix.bb
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-matrix.bb
@@ -1,6 +1,6 @@
DESCRIPTION = "Task to include Matrix v2"
LICENSE = "MIT"
-PR = "r15"
+PR = "r16"
inherit packagegroup
@@ -22,7 +22,6 @@ MATRIX_COMMON_APPS = " \
matrix-gui-oprofile-demos \
matrix-gui-settings-demos \
matrix-gui-usb-demos \
- matrix-gui-submenus-ethernet \
"
MATRIX_QT_APPS = " \
@@ -47,6 +46,7 @@ MATRIX_APPS_append_omap3 = " \
"
MATRIX_APPS_append_ti33x = " \
+ matrix-gui-submenus-ethernet \
matrix-gui-ethernet-demos \
${@base_contains('MACHINE_FEATURES','sgx','${MATRIX_SGX_DEMOS}','',d)} \
matrix-gui-multimedia-demos \
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] packagegroup-arago-tisdk-matrix: remove ethernet menu from common apps
2013-05-15 18:32 [PATCH] packagegroup-arago-tisdk-matrix: remove ethernet menu from common apps hzhang
@ 2013-05-15 18:37 ` Denys Dmytriyenko
2013-05-15 18:41 ` Zhang, Hao
0 siblings, 1 reply; 5+ messages in thread
From: Denys Dmytriyenko @ 2013-05-15 18:37 UTC (permalink / raw)
To: hzhang; +Cc: meta-arago
Don't you have ethernet on Keystone?
On Wed, May 15, 2013 at 02:32:28PM -0400, hzhang@ti.com wrote:
> From: Hao Zhang <hzhang@ti.com>
>
> ---
> .../packagegroup-arago-tisdk-matrix.bb | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-matrix.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-matrix.bb
> index dda72af..2b40f98 100755
> --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-matrix.bb
> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-matrix.bb
> @@ -1,6 +1,6 @@
> DESCRIPTION = "Task to include Matrix v2"
> LICENSE = "MIT"
> -PR = "r15"
> +PR = "r16"
>
> inherit packagegroup
>
> @@ -22,7 +22,6 @@ MATRIX_COMMON_APPS = " \
> matrix-gui-oprofile-demos \
> matrix-gui-settings-demos \
> matrix-gui-usb-demos \
> - matrix-gui-submenus-ethernet \
> "
>
> MATRIX_QT_APPS = " \
> @@ -47,6 +46,7 @@ MATRIX_APPS_append_omap3 = " \
> "
>
> MATRIX_APPS_append_ti33x = " \
> + matrix-gui-submenus-ethernet \
So, what about other machines besides ti33x?
> matrix-gui-ethernet-demos \
> ${@base_contains('MACHINE_FEATURES','sgx','${MATRIX_SGX_DEMOS}','',d)} \
> matrix-gui-multimedia-demos \
> --
> 1.7.9.5
>
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] packagegroup-arago-tisdk-matrix: remove ethernet menu from common apps
2013-05-15 18:37 ` Denys Dmytriyenko
@ 2013-05-15 18:41 ` Zhang, Hao
2013-05-15 18:45 ` Denys Dmytriyenko
0 siblings, 1 reply; 5+ messages in thread
From: Zhang, Hao @ 2013-05-15 18:41 UTC (permalink / raw)
To: Dmytriyenko, Denys; +Cc: meta-arago@arago-project.org
Yes, we do, but the Ethernet demo description says it's ti33x specific demo, I tried it on KS2 evm and it's not working.
-----Original Message-----
From: Dmytriyenko, Denys
Sent: Wednesday, May 15, 2013 2:38 PM
To: Zhang, Hao
Cc: meta-arago@arago-project.org
Subject: Re: [meta-arago] [PATCH] packagegroup-arago-tisdk-matrix: remove ethernet menu from common apps
Don't you have ethernet on Keystone?
On Wed, May 15, 2013 at 02:32:28PM -0400, hzhang@ti.com wrote:
> From: Hao Zhang <hzhang@ti.com>
>
> ---
> .../packagegroup-arago-tisdk-matrix.bb | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-matrix.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-matrix.bb
> index dda72af..2b40f98 100755
> --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-matrix.bb
> +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-matrix.bb
> @@ -1,6 +1,6 @@
> DESCRIPTION = "Task to include Matrix v2"
> LICENSE = "MIT"
> -PR = "r15"
> +PR = "r16"
>
> inherit packagegroup
>
> @@ -22,7 +22,6 @@ MATRIX_COMMON_APPS = " \
> matrix-gui-oprofile-demos \
> matrix-gui-settings-demos \
> matrix-gui-usb-demos \
> - matrix-gui-submenus-ethernet \
> "
>
> MATRIX_QT_APPS = " \
> @@ -47,6 +46,7 @@ MATRIX_APPS_append_omap3 = " \
> "
>
> MATRIX_APPS_append_ti33x = " \
> + matrix-gui-submenus-ethernet \
So, what about other machines besides ti33x?
> matrix-gui-ethernet-demos \
> ${@base_contains('MACHINE_FEATURES','sgx','${MATRIX_SGX_DEMOS}','',d)} \
> matrix-gui-multimedia-demos \
> --
> 1.7.9.5
>
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] packagegroup-arago-tisdk-matrix: remove ethernet menu from common apps
2013-05-15 18:41 ` Zhang, Hao
@ 2013-05-15 18:45 ` Denys Dmytriyenko
2013-05-15 20:00 ` Cooper Jr., Franklin
0 siblings, 1 reply; 5+ messages in thread
From: Denys Dmytriyenko @ 2013-05-15 18:45 UTC (permalink / raw)
To: Zhang, Hao; +Cc: meta-arago@arago-project.org
Chase, Franklin,
This component is coming from Sitara Apps - what is so special in Ethernet
demos that they only run on ti33x? Can we make them more generic?
--
Denys
On Wed, May 15, 2013 at 02:41:43PM -0400, Zhang, Hao wrote:
> Yes, we do, but the Ethernet demo description says it's ti33x specific demo,
> I tried it on KS2 evm and it's not working.
>
> -----Original Message-----
> From: Dmytriyenko, Denys
> Sent: Wednesday, May 15, 2013 2:38 PM
> To: Zhang, Hao
> Cc: meta-arago@arago-project.org
> Subject: Re: [meta-arago] [PATCH] packagegroup-arago-tisdk-matrix: remove ethernet menu from common apps
>
> Don't you have ethernet on Keystone?
>
> On Wed, May 15, 2013 at 02:32:28PM -0400, hzhang@ti.com wrote:
> > From: Hao Zhang <hzhang@ti.com>
> >
> > ---
> > .../packagegroup-arago-tisdk-matrix.bb | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-matrix.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-matrix.bb
> > index dda72af..2b40f98 100755
> > --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-matrix.bb
> > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-tisdk-matrix.bb
> > @@ -1,6 +1,6 @@
> > DESCRIPTION = "Task to include Matrix v2"
> > LICENSE = "MIT"
> > -PR = "r15"
> > +PR = "r16"
> >
> > inherit packagegroup
> >
> > @@ -22,7 +22,6 @@ MATRIX_COMMON_APPS = " \
> > matrix-gui-oprofile-demos \
> > matrix-gui-settings-demos \
> > matrix-gui-usb-demos \
> > - matrix-gui-submenus-ethernet \
> > "
> >
> > MATRIX_QT_APPS = " \
> > @@ -47,6 +46,7 @@ MATRIX_APPS_append_omap3 = " \
> > "
> >
> > MATRIX_APPS_append_ti33x = " \
> > + matrix-gui-submenus-ethernet \
>
> So, what about other machines besides ti33x?
>
>
> > matrix-gui-ethernet-demos \
> > ${@base_contains('MACHINE_FEATURES','sgx','${MATRIX_SGX_DEMOS}','',d)} \
> > matrix-gui-multimedia-demos \
> > --
> > 1.7.9.5
> >
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] packagegroup-arago-tisdk-matrix: remove ethernet menu from common apps
2013-05-15 18:45 ` Denys Dmytriyenko
@ 2013-05-15 20:00 ` Cooper Jr., Franklin
0 siblings, 0 replies; 5+ messages in thread
From: Cooper Jr., Franklin @ 2013-05-15 20:00 UTC (permalink / raw)
To: Dmytriyenko, Denys, Zhang, Hao; +Cc: meta-arago@arago-project.org
Looking at the script and description these apps are meant to use the second Ethernet port that only the am335x sk board exposes.
So his originally patch is fine.
Another possible solution is to remove matrix-gui-submenus-ethernet since matrix-gui-submenus-ethernet already RDEPENDS on that package.
This patch is missing a brief commit message explaining why this package is being moved/removed.
> -----Original Message-----
> From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> bounces@arago-project.org] On Behalf Of Dmytriyenko, Denys
> Sent: Wednesday, May 15, 2013 1:45 PM
> To: Zhang, Hao
> Cc: meta-arago@arago-project.org
> Subject: Re: [meta-arago] [PATCH] packagegroup-arago-tisdk-matrix: remove
> ethernet menu from common apps
>
> Chase, Franklin,
>
> This component is coming from Sitara Apps - what is so special in Ethernet
> demos that they only run on ti33x? Can we make them more generic?
>
> --
> Denys
>
>
> On Wed, May 15, 2013 at 02:41:43PM -0400, Zhang, Hao wrote:
> > Yes, we do, but the Ethernet demo description says it's ti33x specific demo,
> > I tried it on KS2 evm and it's not working.
> >
> > -----Original Message-----
> > From: Dmytriyenko, Denys
> > Sent: Wednesday, May 15, 2013 2:38 PM
> > To: Zhang, Hao
> > Cc: meta-arago@arago-project.org
> > Subject: Re: [meta-arago] [PATCH] packagegroup-arago-tisdk-matrix: remove
> ethernet menu from common apps
> >
> > Don't you have ethernet on Keystone?
> >
> > On Wed, May 15, 2013 at 02:32:28PM -0400, hzhang@ti.com wrote:
> > > From: Hao Zhang <hzhang@ti.com>
> > >
> > > ---
> > > .../packagegroup-arago-tisdk-matrix.bb | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-
> arago-tisdk-matrix.bb b/meta-arago-distro/recipes-
> core/packagegroups/packagegroup-arago-tisdk-matrix.bb
> > > index dda72af..2b40f98 100755
> > > --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-
> tisdk-matrix.bb
> > > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-
> arago-tisdk-matrix.bb
> > > @@ -1,6 +1,6 @@
> > > DESCRIPTION = "Task to include Matrix v2"
> > > LICENSE = "MIT"
> > > -PR = "r15"
> > > +PR = "r16"
> > >
> > > inherit packagegroup
> > >
> > > @@ -22,7 +22,6 @@ MATRIX_COMMON_APPS = " \
> > > matrix-gui-oprofile-demos \
> > > matrix-gui-settings-demos \
> > > matrix-gui-usb-demos \
> > > - matrix-gui-submenus-ethernet \
> > > "
> > >
> > > MATRIX_QT_APPS = " \
> > > @@ -47,6 +46,7 @@ MATRIX_APPS_append_omap3 = " \
> > > "
> > >
> > > MATRIX_APPS_append_ti33x = " \
> > > + matrix-gui-submenus-ethernet \
> >
> > So, what about other machines besides ti33x?
> >
> >
> > > matrix-gui-ethernet-demos \
> > >
> ${@base_contains('MACHINE_FEATURES','sgx','${MATRIX_SGX_DEMOS}','',d)}
> \
> > > matrix-gui-multimedia-demos \
> > > --
> > > 1.7.9.5
> > >
> > > _______________________________________________
> > > meta-arago mailing list
> > > meta-arago@arago-project.org
> > > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-05-15 20:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-15 18:32 [PATCH] packagegroup-arago-tisdk-matrix: remove ethernet menu from common apps hzhang
2013-05-15 18:37 ` Denys Dmytriyenko
2013-05-15 18:41 ` Zhang, Hao
2013-05-15 18:45 ` Denys Dmytriyenko
2013-05-15 20:00 ` Cooper Jr., Franklin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.