From: Dave Chinner <david@fromorbit.com>
To: Oskar Andero <oskar.andero@sonymobile.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Hugh Dickins <hughd@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Radovan Lekanovic <radovan.lekanovic@sonymobile.com>,
David Rientjes <rientjes@google.com>
Subject: Re: [RFC PATCH 1/2] mm: vmscan: let any negative return value from shrinker mean error
Date: Thu, 16 May 2013 10:47:49 +1000 [thread overview]
Message-ID: <20130516004749.GD24635@dastard> (raw)
In-Reply-To: <1368454595-5121-2-git-send-email-oskar.andero@sonymobile.com>
On Mon, May 13, 2013 at 04:16:34PM +0200, Oskar Andero wrote:
> The shrinkers must return -1 to indicate that it is busy. Instead of
> relaying on magical numbers, let any negative value indicate error. This
> opens up for using the errno.h error codes in the shrinker
> implementations.
Just what is the shrinker infrastructure supposed to do with a
random error code?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Oskar Andero <oskar.andero@sonymobile.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Hugh Dickins <hughd@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Radovan Lekanovic <radovan.lekanovic@sonymobile.com>,
David Rientjes <rientjes@google.com>
Subject: Re: [RFC PATCH 1/2] mm: vmscan: let any negative return value from shrinker mean error
Date: Thu, 16 May 2013 10:47:49 +1000 [thread overview]
Message-ID: <20130516004749.GD24635@dastard> (raw)
In-Reply-To: <1368454595-5121-2-git-send-email-oskar.andero@sonymobile.com>
On Mon, May 13, 2013 at 04:16:34PM +0200, Oskar Andero wrote:
> The shrinkers must return -1 to indicate that it is busy. Instead of
> relaying on magical numbers, let any negative value indicate error. This
> opens up for using the errno.h error codes in the shrinker
> implementations.
Just what is the shrinker infrastructure supposed to do with a
random error code?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2013-05-16 0:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-13 14:16 [RFC PATCH 0/2] return value from shrinkers Oskar Andero
2013-05-13 14:16 ` Oskar Andero
2013-05-13 14:16 ` [RFC PATCH 1/2] mm: vmscan: let any negative return value from shrinker mean error Oskar Andero
2013-05-13 14:16 ` Oskar Andero
2013-05-16 0:47 ` Dave Chinner [this message]
2013-05-16 0:47 ` Dave Chinner
2013-05-13 14:16 ` [RFC PATCH 2/2] Clean-up shrinker return values Oskar Andero
2013-05-13 14:16 ` Oskar Andero
2013-05-14 15:03 ` [RFC PATCH 0/2] return value from shrinkers Glauber Costa
2013-05-14 15:03 ` Glauber Costa
2013-05-15 14:10 ` Oskar Andero
2013-05-15 14:10 ` Oskar Andero
2013-05-15 14:18 ` Glauber Costa
2013-05-15 14:18 ` Glauber Costa
2013-05-15 14:47 ` Oskar Andero
2013-05-15 14:47 ` Oskar Andero
2013-05-15 14:49 ` Glauber Costa
2013-05-15 14:49 ` Glauber Costa
2013-05-16 8:20 ` Oskar Andero
2013-05-16 8:20 ` Oskar Andero
2013-05-16 8:23 ` Glauber Costa
2013-05-16 8:23 ` Glauber Costa
2013-05-15 23:05 ` Andrew Morton
2013-05-15 23:05 ` Andrew Morton
2013-05-16 7:52 ` Oskar Andero
2013-05-16 7:52 ` Oskar Andero
2013-05-16 16:27 ` Andrew Morton
2013-05-16 16:27 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130516004749.GD24635@dastard \
--to=david@fromorbit.com \
--cc=gregkh@linuxfoundation.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=oskar.andero@sonymobile.com \
--cc=radovan.lekanovic@sonymobile.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.