From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: sfr@canb.auug.org.au, rdunlap@infradead.org, kvm@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
target-devel@vger.kernel.org, linux-next@vger.kernel.org
Subject: Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec
Date: Thu, 16 May 2013 09:46:21 +0300 [thread overview]
Message-ID: <20130516064620.GB26995@redhat.com> (raw)
In-Reply-To: <20130515.201055.1401062016041347476.davem@davemloft.net>
On Wed, May 15, 2013 at 08:10:55PM -0700, David Miller wrote:
> From: Rusty Russell <rusty@rustcorp.com.au>
> Date: Thu, 16 May 2013 09:05:38 +0930
>
> > memcpy_fromiovec() has nothing to do with networking: that was just the
> > first user. Note that crypto/algif_skcipher.c also uses it. The
> > obvious answer is to move it into lib/.
>
> +1
Rusty sent a patch that does this:
http://patchwork.ozlabs.org/patch/244207/
David, looks like you weren't CC'd.
If you agree could you please Ack that patch and then I can merge it
through the vhost tree?
Or if you prefer merge it directly and I'll sort out the dependencies...
Thanks,
--
MST
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: rusty@rustcorp.com.au, nab@linux-iscsi.org, asias@redhat.com,
kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
target-devel@vger.kernel.org, sfr@canb.auug.org.au,
rdunlap@infradead.org, linux-next@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec
Date: Thu, 16 May 2013 09:46:21 +0300 [thread overview]
Message-ID: <20130516064620.GB26995@redhat.com> (raw)
In-Reply-To: <20130515.201055.1401062016041347476.davem@davemloft.net>
On Wed, May 15, 2013 at 08:10:55PM -0700, David Miller wrote:
> From: Rusty Russell <rusty@rustcorp.com.au>
> Date: Thu, 16 May 2013 09:05:38 +0930
>
> > memcpy_fromiovec() has nothing to do with networking: that was just the
> > first user. Note that crypto/algif_skcipher.c also uses it. The
> > obvious answer is to move it into lib/.
>
> +1
Rusty sent a patch that does this:
http://patchwork.ozlabs.org/patch/244207/
David, looks like you weren't CC'd.
If you agree could you please Ack that patch and then I can merge it
through the vhost tree?
Or if you prefer merge it directly and I'll sort out the dependencies...
Thanks,
--
MST
next prev parent reply other threads:[~2013-05-16 6:46 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 4:17 linux-next: Tree for May 14 Stephen Rothwell
2013-05-14 4:17 ` Stephen Rothwell
2013-05-14 19:16 ` linux-next: Tree for May 14 (vhost_scsi) Randy Dunlap
2013-05-14 23:55 ` Stephen Rothwell
2013-05-15 0:59 ` [PATCH] vhost-scsi: Depend on NET for memcpy_fromiovec Asias He
2013-05-15 0:59 ` Asias He
2013-05-15 3:10 ` Nicholas A. Bellinger
2013-05-15 3:10 ` Nicholas A. Bellinger
2013-05-15 3:44 ` Asias He
2013-05-15 3:44 ` Asias He
2013-05-15 5:17 ` Rusty Russell
2013-05-15 5:17 ` Rusty Russell
2013-05-15 22:37 ` Nicholas A. Bellinger
2013-05-15 22:37 ` Nicholas A. Bellinger
2013-05-15 23:35 ` Rusty Russell
2013-05-15 23:35 ` Rusty Russell
2013-05-16 2:16 ` Asias He
2013-05-16 2:16 ` Asias He
2013-05-16 3:10 ` David Miller
2013-05-16 3:10 ` David Miller
2013-05-16 6:46 ` Michael S. Tsirkin [this message]
2013-05-16 6:46 ` Michael S. Tsirkin
2013-05-16 9:10 ` David Miller
2013-05-16 9:10 ` David Miller
2013-05-16 1:48 ` Asias He
2013-05-16 1:48 ` Asias He
2013-05-16 6:42 ` Michael S. Tsirkin
2013-05-16 6:42 ` Michael S. Tsirkin
2013-05-16 2:08 ` Asias He
2013-05-16 2:08 ` Asias He
2013-05-16 3:34 ` Rusty Russell
2013-05-16 3:55 ` Joe Perches
2013-05-16 23:42 ` Rusty Russell
2013-05-16 23:42 ` Rusty Russell
2013-05-17 4:42 ` Randy Dunlap
2013-05-17 6:55 ` Rusty Russell
2013-05-20 2:07 ` Asias He
2013-05-20 16:43 ` Dmitry Torokhov
2013-05-17 4:42 ` Randy Dunlap
2013-05-23 7:30 ` Michael S. Tsirkin
2013-05-23 7:30 ` Michael S. Tsirkin
2013-05-16 3:55 ` Joe Perches
2013-05-16 4:35 ` Asias He
2013-05-16 4:35 ` Asias He
2013-05-16 6:36 ` Michael S. Tsirkin
2013-05-16 6:36 ` Michael S. Tsirkin
2013-05-16 3:34 ` Rusty Russell
2013-05-15 5:17 ` Rusty Russell
2013-05-14 23:55 ` linux-next: Tree for May 14 (vhost_scsi) Stephen Rothwell
2013-05-14 19:16 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130516064620.GB26995@redhat.com \
--to=mst@redhat.com \
--cc=davem@davemloft.net \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=target-devel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.