From: Dan Carpenter <dan.carpenter@oracle.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Ben Myers <bpm@sgi.com>, Alex Elder <elder@kernel.org>,
kernel-janitors@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [patch] xfs: bug widening binary "not" operation
Date: Fri, 17 May 2013 06:31:59 +0000 [thread overview]
Message-ID: <20130517063159.GO1360@mwanda> (raw)
In-Reply-To: <20130516230314.GH24635@dastard>
On Fri, May 17, 2013 at 09:03:14AM +1000, Dave Chinner wrote:
> As it is, the static checker missed the:
>
> rounding = max_t(uint, ....);
>
> The line before the above usage. I posted a patch to fix this this
> 2 weeks ago here:
>
> http://oss.sgi.com/pipermail/xfs/2013-May/025986.html
>
Ah. Grand. There is still a problem with the max_t(). The shift
operation will wrap before we do the cast. It should be:
- rounding = max_t(xfs_off_t, 1 << mp->m_sb.sb_blocklog, PAGE_CACHE_SIZE);
+ rounding = max_t(xfs_off_t, 1ULL << mp->m_sb.sb_blocklog, PAGE_CACHE_SIZE);
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Ben Myers <bpm@sgi.com>, Alex Elder <elder@kernel.org>,
kernel-janitors@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [patch] xfs: bug widening binary "not" operation
Date: Fri, 17 May 2013 09:31:59 +0300 [thread overview]
Message-ID: <20130517063159.GO1360@mwanda> (raw)
In-Reply-To: <20130516230314.GH24635@dastard>
On Fri, May 17, 2013 at 09:03:14AM +1000, Dave Chinner wrote:
> As it is, the static checker missed the:
>
> rounding = max_t(uint, ....);
>
> The line before the above usage. I posted a patch to fix this this
> 2 weeks ago here:
>
> http://oss.sgi.com/pipermail/xfs/2013-May/025986.html
>
Ah. Grand. There is still a problem with the max_t(). The shift
operation will wrap before we do the cast. It should be:
- rounding = max_t(xfs_off_t, 1 << mp->m_sb.sb_blocklog, PAGE_CACHE_SIZE);
+ rounding = max_t(xfs_off_t, 1ULL << mp->m_sb.sb_blocklog, PAGE_CACHE_SIZE);
regards,
dan carpenter
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2013-05-17 6:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-16 7:53 [patch] xfs: bug widening binary "not" operation Dan Carpenter
2013-05-16 7:53 ` Dan Carpenter
2013-05-16 23:03 ` Dave Chinner
2013-05-16 23:03 ` Dave Chinner
2013-05-17 6:31 ` Dan Carpenter [this message]
2013-05-17 6:31 ` Dan Carpenter
2013-05-17 10:19 ` Dave Chinner
2013-05-17 10:19 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130517063159.GO1360@mwanda \
--to=dan.carpenter@oracle.com \
--cc=bpm@sgi.com \
--cc=david@fromorbit.com \
--cc=elder@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.