From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Carlo Caione <carlo.caione@gmail.com>
Cc: wim@iguana.be, linux-watchdog@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@googlegroups.com,
"Henrik Nordström" <henrik@henriknordstrom.net>
Subject: Re: [PATCH v2] ARM: sunxi: New watchdog driver for Allwinner A10/A13
Date: Sun, 19 May 2013 23:40:33 +0200 [thread overview]
Message-ID: <20130519214033.GA8509@lukather> (raw)
In-Reply-To: <F595BD7D-09B6-452A-B8FF-C7B667CE1DF8@gmail.com>
On Sun, May 19, 2013 at 07:01:54PM +0200, Carlo Caione wrote:
>
> On May 19, 2013, at 5:32 PM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote:
>
> > Hi Carlo,
>
> Hi Maxime,
>
> >> +
> >> +#define WDT_CTRL 0x00
> >> +#define WDT_CTRL_RESTART (1 << 0)
> >> +#define WDT_CTRL_RESERVED (0x0a57 << 1)
> >
> > You didn't replied to me on that part in the previous mail. It doesn't
> > seem to be needed, so why keeping it?
>
> Actually I wrote you about this on irc (probably you were afk)
> Anyway I tested the driver without using the 0x0a57 and without these bits the watchdog is never successfully kicked.
> I'm going to submit a v3 soon, addressing also the suggestions given by Henrik on linux-sunxi ml.
Ok, please discuss this both using mails and by keeping all the
recipients... I wasn't in copy of these mails anymore, neither were the
kernel mailing lists which makes it a pain for the archives and for
other people being part of the discussions.
Please always reply-to-all, and with mails, to these questions.
Anyway, ok. Put a comment explaining why you need it then.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: sunxi: New watchdog driver for Allwinner A10/A13
Date: Sun, 19 May 2013 23:40:33 +0200 [thread overview]
Message-ID: <20130519214033.GA8509@lukather> (raw)
In-Reply-To: <F595BD7D-09B6-452A-B8FF-C7B667CE1DF8@gmail.com>
On Sun, May 19, 2013 at 07:01:54PM +0200, Carlo Caione wrote:
>
> On May 19, 2013, at 5:32 PM, Maxime Ripard <maxime.ripard@free-electrons.com> wrote:
>
> > Hi Carlo,
>
> Hi Maxime,
>
> >> +
> >> +#define WDT_CTRL 0x00
> >> +#define WDT_CTRL_RESTART (1 << 0)
> >> +#define WDT_CTRL_RESERVED (0x0a57 << 1)
> >
> > You didn't replied to me on that part in the previous mail. It doesn't
> > seem to be needed, so why keeping it?
>
> Actually I wrote you about this on irc (probably you were afk)
> Anyway I tested the driver without using the 0x0a57 and without these bits the watchdog is never successfully kicked.
> I'm going to submit a v3 soon, addressing also the suggestions given by Henrik on linux-sunxi ml.
Ok, please discuss this both using mails and by keeping all the
recipients... I wasn't in copy of these mails anymore, neither were the
kernel mailing lists which makes it a pain for the archives and for
other people being part of the discussions.
Please always reply-to-all, and with mails, to these questions.
Anyway, ok. Put a comment explaining why you need it then.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2013-05-19 21:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-18 19:05 [PATCH v2] ARM: sunxi: New watchdog driver for Allwinner A10/A13 Carlo Caione
2013-05-18 19:05 ` Carlo Caione
2013-05-19 15:32 ` Maxime Ripard
2013-05-19 15:32 ` Maxime Ripard
2013-05-19 17:01 ` Carlo Caione
2013-05-19 17:01 ` Carlo Caione
2013-05-19 21:40 ` Maxime Ripard [this message]
2013-05-19 21:40 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130519214033.GA8509@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=carlo.caione@gmail.com \
--cc=henrik@henriknordstrom.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.