From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Oskar Andero <oskar.andero@sonymobile.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Radovan Lekanovic <radovan.lekanovic@sonymobile.com>,
David Rientjes <rientjes@google.com>,
Glauber Costa <glommer@openvz.org>,
Dave Chinner <dchinner@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH] mm: vmscan: add BUG_ON on illegal return values from scan_objects
Date: Mon, 20 May 2013 06:56:35 -0700 [thread overview]
Message-ID: <20130520135635.GA18693@kroah.com> (raw)
In-Reply-To: <1369041267-26424-1-git-send-email-oskar.andero@sonymobile.com>
On Mon, May 20, 2013 at 11:14:27AM +0200, Oskar Andero wrote:
> Add a BUG_ON to catch any illegal value from the shrinkers. This fixes a
> potential bug if scan_objects returns a negative other than -1, which
> would lead to undefined behaviour.
So it's better to crash a machine and keep anyone from using it?
Instead of recovering from an error you found? Not good.
greg k-h
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Oskar Andero <oskar.andero@sonymobile.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Radovan Lekanovic <radovan.lekanovic@sonymobile.com>,
David Rientjes <rientjes@google.com>,
Glauber Costa <glommer@openvz.org>,
Dave Chinner <dchinner@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Hugh Dickins <hughd@google.com>
Subject: Re: [PATCH] mm: vmscan: add BUG_ON on illegal return values from scan_objects
Date: Mon, 20 May 2013 06:56:35 -0700 [thread overview]
Message-ID: <20130520135635.GA18693@kroah.com> (raw)
In-Reply-To: <1369041267-26424-1-git-send-email-oskar.andero@sonymobile.com>
On Mon, May 20, 2013 at 11:14:27AM +0200, Oskar Andero wrote:
> Add a BUG_ON to catch any illegal value from the shrinkers. This fixes a
> potential bug if scan_objects returns a negative other than -1, which
> would lead to undefined behaviour.
So it's better to crash a machine and keep anyone from using it?
Instead of recovering from an error you found? Not good.
greg k-h
next prev parent reply other threads:[~2013-05-20 13:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 9:14 [PATCH] mm: vmscan: add BUG_ON on illegal return values from scan_objects Oskar Andero
2013-05-20 9:14 ` Oskar Andero
2013-05-20 13:56 ` Greg Kroah-Hartman [this message]
2013-05-20 13:56 ` Greg Kroah-Hartman
2013-05-20 22:24 ` David Rientjes
2013-05-20 22:24 ` David Rientjes
2013-05-21 10:34 ` Dave Chinner
2013-05-21 10:34 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130520135635.GA18693@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=dchinner@redhat.com \
--cc=glommer@openvz.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=oskar.andero@sonymobile.com \
--cc=radovan.lekanovic@sonymobile.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.