From: Gustavo Padovan <gustavo@padovan.org>
To: Shuah Khan <shuah.kh@samsung.com>
Cc: "marcel@holtmann.org" <marcel@holtmann.org>,
"johan.hedberg@gmail.com" <johan.hedberg@gmail.com>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"shuahkhan@gmail.com" <shuahkhan@gmail.com>
Subject: Re: [PATCH rebased] Bluetooth: Add missing reset_resume dev_pm_ops
Date: Tue, 21 May 2013 00:28:06 -0300 [thread overview]
Message-ID: <20130521032806.GA12086@joana> (raw)
In-Reply-To: <1369098178.11557.3.camel@lorien>
Hi Shuan,
* Shuah Khan <shuah.kh@samsung.com> [2013-05-21 01:02:58 +0000]:
> Add missing reset_resume dev_pm_ops. Missing reset_resume results in the
> following message after power management device test. This change sets
> reset_resume to btusb_resume().
>
> [ 2506.936134] btusb 1-1.5:1.0: no reset_resume for driver btusb?
> [ 2506.936137] btusb 1-1.5:1.1: no reset_resume for driver btusb?
>
> Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
> ---
> drivers/bluetooth/btusb.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index 7a7e5f8..1eb90c0 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -1616,6 +1616,7 @@ static struct usb_driver btusb_driver = {
> #ifdef CONFIG_PM
> .suspend = btusb_suspend,
> .resume = btusb_resume,
> + .reset_resume = btusb_resume,
> #endif
> .id_table = btusb_table,
> .supports_autosuspend = 1,
Patch still doesn't apply, are you sending it with git-send-email?
Applying: Bluetooth: Add missing reset_resume dev_pm_ops
/home/padovan/p/linux-trees/bluetooth-next/.git/rebase-apply/patch:13: trailing whitespace.
.reset_resume = btusb_resume,
error: patch failed: drivers/bluetooth/btusb.c:1616
error: drivers/bluetooth/btusb.c: patch does not apply
Patch failed at 0001 Bluetooth: Add missing reset_resume dev_pm_ops
Gustavo
next prev parent reply other threads:[~2013-05-21 3:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-29 15:45 [PATCH] Bluetooth: Add missing reset_resume dev_pm_ops Shuah Khan
2013-04-29 15:45 ` Shuah Khan
2013-05-20 23:08 ` Gustavo Padovan
2013-05-20 23:34 ` Shuah Khan
2013-05-20 23:34 ` Shuah Khan
2013-05-21 1:02 ` [PATCH rebased] " Shuah Khan
2013-05-21 1:02 ` Shuah Khan
2013-05-21 3:28 ` Gustavo Padovan [this message]
2013-05-21 15:32 ` Shuah Khan
2013-05-21 15:32 ` Shuah Khan
-- strict thread matches above, loose matches on Subject: below --
2013-05-21 15:32 Shuah Khan
2013-05-21 15:36 ` Gustavo Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130521032806.GA12086@joana \
--to=gustavo@padovan.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=shuah.kh@samsung.com \
--cc=shuahkhan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.