From: Shuah Khan <shuah.kh@samsung.com>
To: Gustavo Padovan <gustavo@padovan.org>
Cc: "marcel@holtmann.org" <marcel@holtmann.org>,
"johan.hedberg@gmail.com" <johan.hedberg@gmail.com>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"shuahkhan@gmail.com" <shuahkhan@gmail.com>
Subject: Re: [PATCH rebased] Bluetooth: Add missing reset_resume dev_pm_ops
Date: Tue, 21 May 2013 15:32:51 +0000 [thread overview]
Message-ID: <1369150371.18338.4.camel@lorien> (raw)
In-Reply-To: <20130521032806.GA12086@joana>
T24gVHVlLCAyMDEzLTA1LTIxIGF0IDAwOjI4IC0wMzAwLCBHdXN0YXZvIFBhZG92YW4gd3JvdGU6
DQo+IEhpIFNodWFuLA0KPiANCj4gKiBTaHVhaCBLaGFuIDxzaHVhaC5raEBzYW1zdW5nLmNvbT4g
WzIwMTMtMDUtMjEgMDE6MDI6NTggKzAwMDBdOg0KPiANCj4gPiBBZGQgbWlzc2luZyByZXNldF9y
ZXN1bWUgZGV2X3BtX29wcy4gTWlzc2luZyByZXNldF9yZXN1bWUgcmVzdWx0cyBpbiB0aGUNCj4g
PiBmb2xsb3dpbmcgbWVzc2FnZSBhZnRlciBwb3dlciBtYW5hZ2VtZW50IGRldmljZSB0ZXN0LiBU
aGlzIGNoYW5nZSBzZXRzDQo+ID4gcmVzZXRfcmVzdW1lIHRvIGJ0dXNiX3Jlc3VtZSgpLg0KPiA+
IA0KPiA+IFsgMjUwNi45MzYxMzRdIGJ0dXNiIDEtMS41OjEuMDogbm8gcmVzZXRfcmVzdW1lIGZv
ciBkcml2ZXIgYnR1c2I/DQo+ID4gWyAyNTA2LjkzNjEzN10gYnR1c2IgMS0xLjU6MS4xOiBubyBy
ZXNldF9yZXN1bWUgZm9yIGRyaXZlciBidHVzYj8NCj4gPiANCj4gPiBTaWduZWQtb2ZmLWJ5OiBT
aHVhaCBLaGFuIDxzaHVhaC5raEBzYW1zdW5nLmNvbT4NCj4gPiAtLS0NCj4gPiAgZHJpdmVycy9i
bHVldG9vdGgvYnR1c2IuYyB8ICAgIDEgKw0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRp
b24oKykNCj4gPiANCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ibHVldG9vdGgvYnR1c2IuYyBi
L2RyaXZlcnMvYmx1ZXRvb3RoL2J0dXNiLmMNCj4gPiBpbmRleCA3YTdlNWY4Li4xZWI5MGMwIDEw
MDY0NA0KPiA+IC0tLSBhL2RyaXZlcnMvYmx1ZXRvb3RoL2J0dXNiLmMNCj4gPiArKysgYi9kcml2
ZXJzL2JsdWV0b290aC9idHVzYi5jDQo+ID4gQEAgLTE2MTYsNiArMTYxNiw3IEBAIHN0YXRpYyBz
dHJ1Y3QgdXNiX2RyaXZlciBidHVzYl9kcml2ZXIgPSB7DQo+ID4gICNpZmRlZiBDT05GSUdfUE0N
Cj4gPiAgCS5zdXNwZW5kCT0gYnR1c2Jfc3VzcGVuZCwNCj4gPiAgCS5yZXN1bWUJCT0gYnR1c2Jf
cmVzdW1lLA0KPiA+ICsJLnJlc2V0X3Jlc3VtZQk9IGJ0dXNiX3Jlc3VtZSwNCj4gPiAgI2VuZGlm
DQo+ID4gIAkuaWRfdGFibGUJPSBidHVzYl90YWJsZSwNCj4gPiAgCS5zdXBwb3J0c19hdXRvc3Vz
cGVuZCA9IDEsDQo+IA0KPiBQYXRjaCBzdGlsbCBkb2Vzbid0IGFwcGx5LCBhcmUgeW91IHNlbmRp
bmcgaXQgd2l0aCBnaXQtc2VuZC1lbWFpbD8NCj4gDQo+IEFwcGx5aW5nOiBCbHVldG9vdGg6IEFk
ZCBtaXNzaW5nIHJlc2V0X3Jlc3VtZSBkZXZfcG1fb3BzDQo+IC9ob21lL3BhZG92YW4vcC9saW51
eC10cmVlcy9ibHVldG9vdGgtbmV4dC8uZ2l0L3JlYmFzZS1hcHBseS9wYXRjaDoxMzogdHJhaWxp
bmcgd2hpdGVzcGFjZS4NCj4gICAgICAgICAucmVzZXRfcmVzdW1lICAgPSBidHVzYl9yZXN1bWUs
DQo+IGVycm9yOiBwYXRjaCBmYWlsZWQ6IGRyaXZlcnMvYmx1ZXRvb3RoL2J0dXNiLmM6MTYxNg0K
PiBlcnJvcjogZHJpdmVycy9ibHVldG9vdGgvYnR1c2IuYzogcGF0Y2ggZG9lcyBub3QgYXBwbHkN
Cj4gUGF0Y2ggZmFpbGVkIGF0IDAwMDEgQmx1ZXRvb3RoOiBBZGQgbWlzc2luZyByZXNldF9yZXN1
bWUgZGV2X3BtX29wcw0KPiANCj4gCUd1c3Rhdm8NCg0KSSBzYXZlZCB0aGUgcGF0Y2ggZnJvbSB0
aGUgZW1haWwgSSBzZW50IGFuZCBhcHBsaWVkIHRvIHlvdXIgbGF0ZXN0IGdpdA0KYW5kIGl0IGFw
cGxpZXMuIEkgYW0gbm90IHN1cmUgd2hhdCBoYXBwZW5lZC4gSW4gYW55IGNhc2UsIEkganVzdCBy
ZXNlbnQNCml0IHVzaW5nIGdpdC1zZW5kLWVtYWlsLiBIb3BlIHRoYXQgd29ya3MuDQoNCi0tIFNo
dWFoDQoNClNodWFoIEtoYW4sIExpbnV4IEtlcm5lbCBEZXZlbG9wZXIgLSBPcGVuIFNvdXJjZSBH
cm91cCANClNhbXN1bmcgUmVzZWFyY2ggQW1lcmljYSAoU2lsaWNvbiBWYWxsZXkpDQpzaHVhaC5r
aEBzYW1zdW5nLmNvbSB8ICg5NzApIDY3Mi0wNjU4DQoNCg==
WARNING: multiple messages have this Message-ID (diff)
From: Shuah Khan <shuah.kh@samsung.com>
To: Gustavo Padovan <gustavo@padovan.org>
Cc: "marcel@holtmann.org" <marcel@holtmann.org>,
"johan.hedberg@gmail.com" <johan.hedberg@gmail.com>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"shuahkhan@gmail.com" <shuahkhan@gmail.com>
Subject: Re: [PATCH rebased] Bluetooth: Add missing reset_resume dev_pm_ops
Date: Tue, 21 May 2013 15:32:51 +0000 [thread overview]
Message-ID: <1369150371.18338.4.camel@lorien> (raw)
In-Reply-To: <20130521032806.GA12086@joana>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 2024 bytes --]
On Tue, 2013-05-21 at 00:28 -0300, Gustavo Padovan wrote:
> Hi Shuan,
>
> * Shuah Khan <shuah.kh@samsung.com> [2013-05-21 01:02:58 +0000]:
>
> > Add missing reset_resume dev_pm_ops. Missing reset_resume results in the
> > following message after power management device test. This change sets
> > reset_resume to btusb_resume().
> >
> > [ 2506.936134] btusb 1-1.5:1.0: no reset_resume for driver btusb?
> > [ 2506.936137] btusb 1-1.5:1.1: no reset_resume for driver btusb?
> >
> > Signed-off-by: Shuah Khan <shuah.kh@samsung.com>
> > ---
> > drivers/bluetooth/btusb.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> > index 7a7e5f8..1eb90c0 100644
> > --- a/drivers/bluetooth/btusb.c
> > +++ b/drivers/bluetooth/btusb.c
> > @@ -1616,6 +1616,7 @@ static struct usb_driver btusb_driver = {
> > #ifdef CONFIG_PM
> > .suspend = btusb_suspend,
> > .resume = btusb_resume,
> > + .reset_resume = btusb_resume,
> > #endif
> > .id_table = btusb_table,
> > .supports_autosuspend = 1,
>
> Patch still doesn't apply, are you sending it with git-send-email?
>
> Applying: Bluetooth: Add missing reset_resume dev_pm_ops
> /home/padovan/p/linux-trees/bluetooth-next/.git/rebase-apply/patch:13: trailing whitespace.
> .reset_resume = btusb_resume,
> error: patch failed: drivers/bluetooth/btusb.c:1616
> error: drivers/bluetooth/btusb.c: patch does not apply
> Patch failed at 0001 Bluetooth: Add missing reset_resume dev_pm_ops
>
> Gustavo
I saved the patch from the email I sent and applied to your latest git
and it applies. I am not sure what happened. In any case, I just resent
it using git-send-email. Hope that works.
-- Shuah
Shuah Khan, Linux Kernel Developer - Open Source Group
Samsung Research America (Silicon Valley)
shuah.kh@samsung.com | (970) 672-0658
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
next prev parent reply other threads:[~2013-05-21 15:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-29 15:45 [PATCH] Bluetooth: Add missing reset_resume dev_pm_ops Shuah Khan
2013-04-29 15:45 ` Shuah Khan
2013-05-20 23:08 ` Gustavo Padovan
2013-05-20 23:34 ` Shuah Khan
2013-05-20 23:34 ` Shuah Khan
2013-05-21 1:02 ` [PATCH rebased] " Shuah Khan
2013-05-21 1:02 ` Shuah Khan
2013-05-21 3:28 ` Gustavo Padovan
2013-05-21 15:32 ` Shuah Khan [this message]
2013-05-21 15:32 ` Shuah Khan
-- strict thread matches above, loose matches on Subject: below --
2013-05-21 15:32 Shuah Khan
2013-05-21 15:36 ` Gustavo Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369150371.18338.4.camel@lorien \
--to=shuah.kh@samsung.com \
--cc=gustavo@padovan.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=shuahkhan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.