All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: shmobile: kzm9g-reference: Update CMT clocksource rating to 80
Date: Wed, 22 May 2013 13:56:13 +0000	[thread overview]
Message-ID: <20130522135608.GA32012@verge.net.au> (raw)
In-Reply-To: <519CCB97.20207@cogentembedded.com>

On Wed, May 22, 2013 at 05:43:51PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 22-05-2013 16:49, Simon Horman wrote:
> 
> >Update the CMT clocksource rating from 100 to 10.
> 
>    s/100/125/ and s/10/80/, apparently.

Thanks, I don't know what I was thinking.

> 
> >This resolves a boot-failure regression for kzm9g-reference in v3.10-rc1
> >introduced by f7db706b132f11c79ae1d74b2382e0926cf31644 ("ARM: 7674/1: smp:
> >Avoid dummy clockevent being preferred over real").
> 
> >The patch noted above reduces the rating of dummy clockevent from 400 to 100.
> 
>    400 seems very high rating for a dummy clockevent...
> 
> >This patch reduces the rating of CMT so that it is once again less than that
> >of the dummy clockevent.
> 
> >Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> 
> >---
> 
> >I also plan to reduce the rating of the STI clocksource to less than 100.
> >However, as I am not aware of any problems relating to STI in v3.10-rc
> >my plan is to update STI in the v3.11 timeframe.
> >---
> >  arch/arm/mach-shmobile/setup-sh73a0.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> >diff --git a/arch/arm/mach-shmobile/setup-sh73a0.c b/arch/arm/mach-shmobile/setup-sh73a0.c
> >index fdf3894..9696f36 100644
> >--- a/arch/arm/mach-shmobile/setup-sh73a0.c
> >+++ b/arch/arm/mach-shmobile/setup-sh73a0.c
> >@@ -252,7 +252,7 @@ static struct sh_timer_config cmt10_platform_data = {
> >  	.name = "CMT10",
> >  	.channel_offset = 0x10,
> >  	.timer_bit = 0,
> >-	.clockevent_rating = 125,
> >+	.clockevent_rating = 80,
> >  	.clocksource_rating = 125,
> >  };
> 
> WBR, Sergei
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

WARNING: multiple messages have this Message-ID (diff)
From: horms@verge.net.au (Simon Horman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: shmobile: kzm9g-reference: Update CMT clocksource rating to 80
Date: Wed, 22 May 2013 22:56:13 +0900	[thread overview]
Message-ID: <20130522135608.GA32012@verge.net.au> (raw)
In-Reply-To: <519CCB97.20207@cogentembedded.com>

On Wed, May 22, 2013 at 05:43:51PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 22-05-2013 16:49, Simon Horman wrote:
> 
> >Update the CMT clocksource rating from 100 to 10.
> 
>    s/100/125/ and s/10/80/, apparently.

Thanks, I don't know what I was thinking.

> 
> >This resolves a boot-failure regression for kzm9g-reference in v3.10-rc1
> >introduced by f7db706b132f11c79ae1d74b2382e0926cf31644 ("ARM: 7674/1: smp:
> >Avoid dummy clockevent being preferred over real").
> 
> >The patch noted above reduces the rating of dummy clockevent from 400 to 100.
> 
>    400 seems very high rating for a dummy clockevent...
> 
> >This patch reduces the rating of CMT so that it is once again less than that
> >of the dummy clockevent.
> 
> >Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> 
> >---
> 
> >I also plan to reduce the rating of the STI clocksource to less than 100.
> >However, as I am not aware of any problems relating to STI in v3.10-rc
> >my plan is to update STI in the v3.11 timeframe.
> >---
> >  arch/arm/mach-shmobile/setup-sh73a0.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> >diff --git a/arch/arm/mach-shmobile/setup-sh73a0.c b/arch/arm/mach-shmobile/setup-sh73a0.c
> >index fdf3894..9696f36 100644
> >--- a/arch/arm/mach-shmobile/setup-sh73a0.c
> >+++ b/arch/arm/mach-shmobile/setup-sh73a0.c
> >@@ -252,7 +252,7 @@ static struct sh_timer_config cmt10_platform_data = {
> >  	.name = "CMT10",
> >  	.channel_offset = 0x10,
> >  	.timer_bit = 0,
> >-	.clockevent_rating = 125,
> >+	.clockevent_rating = 80,
> >  	.clocksource_rating = 125,
> >  };
> 
> WBR, Sergei
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

  reply	other threads:[~2013-05-22 13:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-19 17:38 [PATCH] ARM: shmobile: kzm9g-reference: fix device-tree bindings and device names Guennadi Liakhovetski
2013-03-21 12:23 ` Laurent Pinchart
2013-03-21 13:25 ` Simon Horman
2013-05-22 12:49 ` [PATCH] ARM: shmobile: kzm9g-reference: Update CMT clocksource rating to 80 Simon Horman
2013-05-22 12:49   ` Simon Horman
2013-05-22 13:43   ` Sergei Shtylyov
2013-05-22 13:43     ` Sergei Shtylyov
2013-05-22 13:56     ` Simon Horman [this message]
2013-05-22 13:56       ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130522135608.GA32012@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.