[Buildroot] [PATCH] mongrel2: Needs a glibc or a uClibc-0.9.34-git based toolchain

[Buildroot] [PATCH] mongrel2: Needs a glibc or a uClibc-0.9.34-git based toolchain

[Markos Chandras]

From: Markos Chandras <markos.chandras@imgtec.com>

mongrel2 needs the {get,make,swap}context functions which are
present in glibc and in the uClibc's master branch.

Fixes:
http://autobuild.buildroot.net/results/8e132a2b03a7b5ae94199db7db86883c05dca700/build-end.log

Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
 package/mongrel2/Config.in | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/package/mongrel2/Config.in b/package/mongrel2/Config.in
index 05d10d7..1cebcf0 100644
--- a/package/mongrel2/Config.in
+++ b/package/mongrel2/Config.in
@@ -6,6 +6,9 @@ config BR2_PACKAGE_MONGREL2
 	depends on BR2_INET_IPV6 # zeromq
 	depends on BR2_LARGEFILE # zeromq -> util-linux
 	depends on BR2_USE_WCHAR # zeromq -> util-linux
+	# {get,make,swap}context functions present in
+	# glibc and in uClibc's master branch.
+	depends on BR2_UCLIBC_VERSION_SNAPSHOT || !BR2_TOOLCHAIN_BUILDROOT
 	help
 	  Mongrel2 is an application, language, and network architecture
 	  agnostic web server that focuses on web applications using
-- 
1.8.2.1

[Buildroot] [PATCH] mongrel2: Needs a glibc or a uClibc-0.9.34-git based toolchain

[Thomas Petazzoni]

Dear Markos Chandras,

On Wed, 22 May 2013 15:10:08 +0100, Markos Chandras wrote:

> +	# {get,make,swap}context functions present in
> +	# glibc and in uClibc's master branch.
> +	depends on BR2_UCLIBC_VERSION_SNAPSHOT || !BR2_TOOLCHAIN_BUILDROOT
>  	help
>  	  Mongrel2 is an application, language, and network architecture
>  	  agnostic web server that focuses on web applications using

An external toolchain can be uClibc based... but we don't know which
version. However, since no uClibc stable release has been released with
this feature, I don't expect any external toolchain today to have this
feature enabled. So something like:

	depends on BR2_UCLIBC_VERSION_SNAPSHOT || \
		external toolchain uses glibc or eglibc || \
		crosstool-ng backend has glibc or eglibc selected

Would probably be more appropriate.

Best regards,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH] mongrel2: Needs a glibc or a uClibc-0.9.34-git based toolchain

[Markos Chandras]

On 22 May 2013 15:43, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Markos Chandras,
>
> On Wed, 22 May 2013 15:10:08 +0100, Markos Chandras wrote:
>
>> +     # {get,make,swap}context functions present in
>> +     # glibc and in uClibc's master branch.
>> +     depends on BR2_UCLIBC_VERSION_SNAPSHOT || !BR2_TOOLCHAIN_BUILDROOT
>>       help
>>         Mongrel2 is an application, language, and network architecture
>>         agnostic web server that focuses on web applications using
>
> An external toolchain can be uClibc based... but we don't know which
> version. However, since no uClibc stable release has been released with
> this feature, I don't expect any external toolchain today to have this
> feature enabled. So something like:
>
>         depends on BR2_UCLIBC_VERSION_SNAPSHOT || \
>                 external toolchain uses glibc or eglibc || \
>                 crosstool-ng backend has glibc or eglibc selected
>
> Would probably be more appropriate.
>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com

Hi Thomas,

No problem. Although I can't find an option for external toolchain +
eglibc. So what I have right now is this:

        # {get,make,swap}context functions present in
        # {e,}glibc and in uClibc's master branch.
        depends on BR2_UCLIBC_VERSION_SNAPSHOT || \
                BR2_TOOLCHAIN_CTNG_eglibc || \
                BR2_TOOLCHAIN_CTNG_glibc || \
                BR2_TOOLCHAIN_EXTERNAL_CUSTOM_GLIBC || \
                BR2_TOOLCHAIN_EXTERNAL_GLIBC

I believe this should cover all the cases. Thanks for the review

--
Regards,
Markos Chandras

[Buildroot] [PATCH] mongrel2: Needs a glibc or a uClibc-0.9.34-git based toolchain

[Thomas Petazzoni]

Dear Markos Chandras,

On Wed, 22 May 2013 15:57:36 +0100, Markos Chandras wrote:

> No problem. Although I can't find an option for external toolchain +
> eglibc. So what I have right now is this:

Yes, in the external toolchain backend, we support eglibc and glibc
similarly, so there's just one single option for both.

It is however not needed to put BR2_TOOLCHAIN_EXTERNAL_CUSTOM_GLIBC in
your condition, because it already selects
BR2_TOOLCHAIN_EXTERNAL_GLIBC. So as far as external toolchains are
concerned, "depends on BR2_TOOLCHAIN_EXTERNAL_GLIBC" is enough.

Thanks,

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

[Buildroot] [PATCH] mongrel2: Needs a glibc or a uClibc-0.9.34-git based toolchain

[Markos Chandras]

On 22 May 2013 16:52, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Dear Markos Chandras,
>
> On Wed, 22 May 2013 15:57:36 +0100, Markos Chandras wrote:
>
>> No problem. Although I can't find an option for external toolchain +
>> eglibc. So what I have right now is this:
>
> Yes, in the external toolchain backend, we support eglibc and glibc
> similarly, so there's just one single option for both.
>
> It is however not needed to put BR2_TOOLCHAIN_EXTERNAL_CUSTOM_GLIBC in
> your condition, because it already selects
> BR2_TOOLCHAIN_EXTERNAL_GLIBC. So as far as external toolchains are
> concerned, "depends on BR2_TOOLCHAIN_EXTERNAL_GLIBC" is enough.
>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, Free Electrons
> Kernel, drivers, real-time and embedded Linux
> development, consulting, training and support.
> http://free-electrons.com

Hi Thomas,

Thank you for the clarification. I will prepare a new patch.

--
Regards,
Markos Chandras