All of lore.kernel.org
 help / color / mirror / Atom feed
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] regulator: ab8500-ext: Don't register without initialisation data
Date: Thu, 23 May 2013 08:09:05 +0100	[thread overview]
Message-ID: <20130523070905.GD18714@gmail.com> (raw)
In-Reply-To: <20130522174516.GT1627@sirena.org.uk>

On Wed, 22 May 2013, Mark Brown wrote:

> On Wed, May 22, 2013 at 05:53:53PM +0100, Lee Jones wrote:
> > On Wed, 22 May 2013, Mark Brown wrote:
> 
> > > running or not, the worst that should happen is that the state can be
> > > read back.  I'd therefore expect the fix here to be in the board side
> > > code that enables the regulators.
> 
> > It's both.
> 
> > From the platform side we have stopped passing the external regulator
> > driver's constraints for Snowball:
> 
> > https://lkml.org/lkml/2013/5/22/280
> 
> > All I've done here is stop the ext driver from crapping out with the
> > misleading error "Configuration error: size mismatch", because a)
> > it's not an error, it's expected and b) It's not a size mismatch,
> > instead we have chosen to keep the constraints back in the Snowball
> > (and u8505) case.
> 
> OK, so the regulator driver is buggy and insisting on having constraints
> passed in for every regulator then?

If that's not how it's meant to work then, yes.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linus.walleij@linaro.org,
	arnd@arndb.de, linus.walleij@stericsson.com,
	srinidhi.kasagar@stericsson.com
Subject: Re: [PATCH] regulator: ab8500-ext: Don't register without initialisation data
Date: Thu, 23 May 2013 08:09:05 +0100	[thread overview]
Message-ID: <20130523070905.GD18714@gmail.com> (raw)
In-Reply-To: <20130522174516.GT1627@sirena.org.uk>

On Wed, 22 May 2013, Mark Brown wrote:

> On Wed, May 22, 2013 at 05:53:53PM +0100, Lee Jones wrote:
> > On Wed, 22 May 2013, Mark Brown wrote:
> 
> > > running or not, the worst that should happen is that the state can be
> > > read back.  I'd therefore expect the fix here to be in the board side
> > > code that enables the regulators.
> 
> > It's both.
> 
> > From the platform side we have stopped passing the external regulator
> > driver's constraints for Snowball:
> 
> > https://lkml.org/lkml/2013/5/22/280
> 
> > All I've done here is stop the ext driver from crapping out with the
> > misleading error "Configuration error: size mismatch", because a)
> > it's not an error, it's expected and b) It's not a size mismatch,
> > instead we have chosen to keep the constraints back in the Snowball
> > (and u8505) case.
> 
> OK, so the regulator driver is buggy and insisting on having constraints
> passed in for every regulator then?

If that's not how it's meant to work then, yes.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2013-05-23  7:09 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-22 12:47 [RC FIXES] Fix broken MMC devices on Snowball Lee Jones
2013-05-22 12:47 ` Lee Jones
2013-05-22 12:47 ` [PATCH] ARM: ux500: Allow Snowball to pass its own regulator settings Lee Jones
2013-05-22 12:47   ` Lee Jones
2013-05-24 11:25   ` Lee Jones
2013-05-24 11:25     ` Lee Jones
2013-05-22 12:47 ` [PATCH] regulator: ab8500-ext: Don't register without initialisation data Lee Jones
2013-05-22 12:47   ` Lee Jones
2013-05-22 13:18   ` Linus Walleij
2013-05-22 13:18     ` Linus Walleij
2013-05-22 14:08     ` Arnd Bergmann
2013-05-22 14:08       ` Arnd Bergmann
2013-05-23  8:23       ` Linus Walleij
2013-05-23  8:23         ` Linus Walleij
2013-05-22 15:53   ` Mark Brown
2013-05-22 15:53     ` Mark Brown
2013-05-22 16:53     ` Lee Jones
2013-05-22 16:53       ` Lee Jones
2013-05-22 17:45       ` Mark Brown
2013-05-22 17:45         ` Mark Brown
2013-05-23  7:09         ` Lee Jones [this message]
2013-05-23  7:09           ` Lee Jones
2013-05-23 14:24           ` Mark Brown
2013-05-23 14:24             ` Mark Brown
2013-05-23 14:44             ` Lee Jones
2013-05-23 14:44               ` Lee Jones
2013-05-23 15:18               ` Mark Brown
2013-05-23 15:18                 ` Mark Brown
2013-05-23 15:30                 ` Lee Jones
2013-05-23 15:30                   ` Lee Jones
2013-05-24 11:23   ` Lee Jones
2013-05-24 11:23     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130523070905.GD18714@gmail.com \
    --to=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.