From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Chen Gang <gang.chen@asianux.com>
Cc: coreteam@netfilter.org, netdev <netdev@vger.kernel.org>,
bridge@lists.linux-foundation.org,
David Miller <davem@davemloft.net>,
stephen@networkplumber.org, netfilter@vger.kernel.org,
bart.de.schuymer@pandora.be, netfilter-devel@vger.kernel.org,
kaber@trash.net
Subject: Re: [Bridge] [PATCH] bridge: netfilter: using strlcpy() instead of strncpy()
Date: Thu, 23 May 2013 12:56:00 +0200 [thread overview]
Message-ID: <20130523105600.GA22553@localhost> (raw)
In-Reply-To: <5195E53A.4060406@asianux.com>
On Fri, May 17, 2013 at 04:07:22PM +0800, Chen Gang wrote:
>
> 'name' has already set all zero when it is defined, so not need let
> strncpy() to pad it again.
>
> 'name' is a string, better always let is NUL terminated, so use
> strlcpy() instead of strncpy().
Applied, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Chen Gang <gang.chen@asianux.com>
Cc: bart.de.schuymer@pandora.be, kaber@trash.net,
stephen@networkplumber.org, David Miller <davem@davemloft.net>,
netfilter-devel@vger.kernel.org, netfilter@vger.kernel.org,
coreteam@netfilter.org, bridge@lists.linux-foundation.org,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] bridge: netfilter: using strlcpy() instead of strncpy()
Date: Thu, 23 May 2013 12:56:00 +0200 [thread overview]
Message-ID: <20130523105600.GA22553@localhost> (raw)
In-Reply-To: <5195E53A.4060406@asianux.com>
On Fri, May 17, 2013 at 04:07:22PM +0800, Chen Gang wrote:
>
> 'name' has already set all zero when it is defined, so not need let
> strncpy() to pad it again.
>
> 'name' is a string, better always let is NUL terminated, so use
> strlcpy() instead of strncpy().
Applied, thanks.
next prev parent reply other threads:[~2013-05-23 10:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-17 8:07 [Bridge] [PATCH] bridge: netfilter: using strlcpy() instead of strncpy() Chen Gang
2013-05-17 8:07 ` Chen Gang
2013-05-19 19:43 ` [Bridge] " Bart De Schuymer
2013-05-19 19:43 ` Bart De Schuymer
2013-05-20 1:04 ` [Bridge] " Chen Gang
2013-05-20 1:04 ` Chen Gang
2013-05-23 10:56 ` Pablo Neira Ayuso [this message]
2013-05-23 10:56 ` Pablo Neira Ayuso
2013-05-23 10:57 ` [Bridge] " Chen Gang
2013-05-23 10:57 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130523105600.GA22553@localhost \
--to=pablo@netfilter.org \
--cc=bart.de.schuymer@pandora.be \
--cc=bridge@lists.linux-foundation.org \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=gang.chen@asianux.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.