From: Arnd Bergmann <arnd@arndb.de>
To: dinguyen@altera.com
Cc: linux-arm-kernel@lists.infradead.org, dinh.linux@gmail.com,
Seungwon Jeon <tgih.jun@samsung.com>,
Jaehoon Chung <jh80.chung@samsung.com>,
Olof Johansson <olof@lixom.net>, Pavel Machek <pavel@denx.de>,
linux-mmc@vger.kernel.org
Subject: Re: [PATCHv4 6/6] mmc: dw_mmc: Add support DW SD/MMC driver on SOCFPGA
Date: Fri, 24 May 2013 19:10:37 +0200 [thread overview]
Message-ID: <201305241910.37975.arnd@arndb.de> (raw)
In-Reply-To: <1369410080-436-6-git-send-email-dinguyen@altera.com>
On Friday 24 May 2013, dinguyen@altera.com wrote:
>
> From: Dinh Nguyen <dinguyen@altera.com>
>
> Add platform specific functionality for the DW SD/MMC driver for
> SoCFPGA. Move SDMMC_CMD_USE_HOLD_REG to dw_mmc.h so other platforms
> can use this define.
No objections to the patch, but you seem to be missing a binding document,
which is mandatory to describe the properties you add.
It also seems odd to have this in the series for the ethernet driver.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv4 6/6] mmc: dw_mmc: Add support DW SD/MMC driver on SOCFPGA
Date: Fri, 24 May 2013 19:10:37 +0200 [thread overview]
Message-ID: <201305241910.37975.arnd@arndb.de> (raw)
In-Reply-To: <1369410080-436-6-git-send-email-dinguyen@altera.com>
On Friday 24 May 2013, dinguyen at altera.com wrote:
>
> From: Dinh Nguyen <dinguyen@altera.com>
>
> Add platform specific functionality for the DW SD/MMC driver for
> SoCFPGA. Move SDMMC_CMD_USE_HOLD_REG to dw_mmc.h so other platforms
> can use this define.
No objections to the patch, but you seem to be missing a binding document,
which is mandatory to describe the properties you add.
It also seems odd to have this in the series for the ethernet driver.
Arnd
next prev parent reply other threads:[~2013-05-24 17:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-24 15:41 [PATCHv4 1/6] ARM: socfpga: dts: Add ethernet bindings for SOCFPGA dinguyen at altera.com
2013-05-24 15:41 ` [PATCHv4 2/6] ARM: socfpga: dts: Add gate-clock bindings dinguyen at altera.com
2013-05-24 15:41 ` [PATCHv4 3/6] ARM: socfpga: Add support to gate peripheral clocks dinguyen at altera.com
2013-05-30 19:42 ` Mike Turquette
2013-05-30 21:33 ` Dinh Nguyen
2013-05-24 15:41 ` [PATCHv4 4/6] ARM: socfpga: Add syscon to be part of socfpga dinguyen at altera.com
2013-05-24 15:41 ` [PATCHv4 5/6] ARM: socfpga: dts: Add support for SD/MMC dinguyen at altera.com
2013-05-24 15:41 ` [PATCHv4 6/6] mmc: dw_mmc: Add support DW SD/MMC driver on SOCFPGA dinguyen
2013-05-24 15:41 ` dinguyen at altera.com
2013-05-24 17:10 ` Arnd Bergmann [this message]
2013-05-24 17:10 ` Arnd Bergmann
2013-05-24 17:12 ` Arnd Bergmann
2013-05-24 17:12 ` Arnd Bergmann
2013-05-24 18:03 ` Dinh Nguyen
2013-05-24 18:03 ` Dinh Nguyen
2013-05-24 18:58 ` Arnd Bergmann
2013-05-24 18:58 ` Arnd Bergmann
2013-05-26 18:11 ` Pavel Machek
2013-05-26 18:11 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201305241910.37975.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=dinguyen@altera.com \
--cc=dinh.linux@gmail.com \
--cc=jh80.chung@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=pavel@denx.de \
--cc=tgih.jun@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.