All of lore.kernel.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv3 1/6] net: Add EMAC ethernet driver found on Allwinner A10 SoC's
Date: Fri, 24 May 2013 22:10:30 +0200	[thread overview]
Message-ID: <20130524201030.GA17847@lukather> (raw)
In-Reply-To: <519F6128.9060608@elopez.com.ar>

Hi Emilio,

On Fri, May 24, 2013 at 09:46:32AM -0300, Emilio L?pez wrote:
> El 24/05/13 06:23, Maxime Ripard escribi?:
> > From: Stefan Roese <sr@denx.de>
> > 
> > The Allwinner A10 has an ethernet controller that seem to be developped
> > internally by them.
> > 
> > The exact feature set of this controller is unknown, since there is no
> > public documentation for this IP, and this driver is mostly the one
> > published by Allwinner that has been heavily cleaned up.
> > 
> > Signed-off-by: Stefan Roese <sr@denx.de>
> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> > ---
> 
> (snip)
> 
> > +
> > +config SUN4I_EMAC
> > +        tristate "Allwinner A10 EMAC support"
> > +	depends on ARCH_SUNXI
> > +	depends on OF
> > +	select CRC32
> > +	select NET_CORE
> > +	select MII
> > +	select REGULATOR_FIXED_VOLTAGE
> > +        ---help---
> > +          Support for Allwinner A10 EMAC ethernet driver.
> > +
> > +          To compile this driver as a module, choose M here.  The module
> > +          will be called sun4i-emac.
> > +
> 
> You also need to select REGULATOR when you select REGULATOR_FIXED_VOLTAGE

Actually, this should be in patch 2/6.

Thanks for noticing!

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: "Emilio López" <emilio@elopez.com.ar>
Cc: davem@davemloft.net, linux-arm-kernel@lists.infradead.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Stefan Roese <sr@denx.de>, Florian Fainelli <florian@openwrt.org>,
	kevin@allwinnertech.com, sunny@allwinnertech.com,
	shuge@allwinnertech.com
Subject: Re: [PATCHv3 1/6] net: Add EMAC ethernet driver found on Allwinner A10 SoC's
Date: Fri, 24 May 2013 22:10:30 +0200	[thread overview]
Message-ID: <20130524201030.GA17847@lukather> (raw)
In-Reply-To: <519F6128.9060608@elopez.com.ar>

Hi Emilio,

On Fri, May 24, 2013 at 09:46:32AM -0300, Emilio López wrote:
> El 24/05/13 06:23, Maxime Ripard escribió:
> > From: Stefan Roese <sr@denx.de>
> > 
> > The Allwinner A10 has an ethernet controller that seem to be developped
> > internally by them.
> > 
> > The exact feature set of this controller is unknown, since there is no
> > public documentation for this IP, and this driver is mostly the one
> > published by Allwinner that has been heavily cleaned up.
> > 
> > Signed-off-by: Stefan Roese <sr@denx.de>
> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> > ---
> 
> (snip)
> 
> > +
> > +config SUN4I_EMAC
> > +        tristate "Allwinner A10 EMAC support"
> > +	depends on ARCH_SUNXI
> > +	depends on OF
> > +	select CRC32
> > +	select NET_CORE
> > +	select MII
> > +	select REGULATOR_FIXED_VOLTAGE
> > +        ---help---
> > +          Support for Allwinner A10 EMAC ethernet driver.
> > +
> > +          To compile this driver as a module, choose M here.  The module
> > +          will be called sun4i-emac.
> > +
> 
> You also need to select REGULATOR when you select REGULATOR_FIXED_VOLTAGE

Actually, this should be in patch 2/6.

Thanks for noticing!

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2013-05-24 20:10 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-24  9:23 [PATCHv3 RESEND 0/6] ARM: sunxi: Add support for A10 Ethernet controller Maxime Ripard
2013-05-24  9:23 ` Maxime Ripard
2013-05-24  9:23 ` [PATCHv3 1/6] net: Add EMAC ethernet driver found on Allwinner A10 SoC's Maxime Ripard
2013-05-24  9:23   ` Maxime Ripard
2013-05-24 12:46   ` Emilio López
2013-05-24 12:46     ` Emilio López
2013-05-24 20:10     ` Maxime Ripard [this message]
2013-05-24 20:10       ` Maxime Ripard
2013-05-24  9:23 ` [PATCHv3 2/6] net: Add MDIO bus driver for the Allwinner EMAC Maxime Ripard
2013-05-24  9:23   ` Maxime Ripard
2013-05-24  9:42   ` Florian Fainelli
2013-05-24  9:42     ` Florian Fainelli
2013-05-24 10:14     ` Maxime Ripard
2013-05-24 10:14       ` Maxime Ripard
2013-05-24  9:23 ` [PATCHv3 3/6] ARM: sun4i: Add muxing options for the ethernet controller Maxime Ripard
2013-05-24  9:23   ` Maxime Ripard
2013-05-24  9:23 ` [PATCHv3 4/6] ARM: sunxi: Add EMAC controller node to sun4i DTSI Maxime Ripard
2013-05-24  9:23   ` Maxime Ripard
2013-05-24  9:23 ` [PATCHv3 5/6] ARM: cubieboard: Enable ethernet (EMAC) support in dts Maxime Ripard
2013-05-24  9:23   ` Maxime Ripard
2013-05-24 12:53   ` Emilio López
2013-05-24 12:53     ` Emilio López
2013-05-24 20:15     ` Maxime Ripard
2013-05-24 20:15       ` Maxime Ripard
2013-05-24  9:23 ` [PATCHv3 6/6] ARM: sunxi: Add EMAC Controller to Hackberry dt Maxime Ripard
2013-05-24  9:23   ` Maxime Ripard
2013-05-29 18:15 ` [PATCHv3 RESEND 0/6] ARM: sunxi: Add support for A10 Ethernet controller Richard Genoud
2013-05-29 18:15   ` Richard Genoud
2013-05-30  8:11   ` Maxime Ripard
2013-05-30  8:11     ` Maxime Ripard
2013-05-30 17:50     ` Richard Genoud
2013-05-30 17:50       ` Richard Genoud

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130524201030.GA17847@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.