From: Dave Jones <davej@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>, xfs@oss.sgi.com
Subject: Re: XFS assertion from truncate. (3.10-rc2)
Date: Fri, 24 May 2013 16:16:55 -0400 [thread overview]
Message-ID: <20130524201655.GA23086@redhat.com> (raw)
In-Reply-To: <20130524080300.GI24543@dastard>
On Fri, May 24, 2013 at 06:03:00PM +1000, Dave Chinner wrote:
> xfstest generic/193 is *supposed* to test behaviour of suid/sgid bits
> and clearing them is various situations.
>
> You know what I'm about to say, don't you? The test doesn't test
> what it thinks it is testing. it puts the destination file in root
> directory of the xfstests harness, not in the filesystems being
> tested.
awesome, two bugs for the price of one!
> So, on all my machines, it runs on ext3 filesystems, never on the
> ext4, btrfs, xfs, etc filesystems that I'm actually testing.
>
> That's beside the point, because it doesn't test truncate behaviour.
> But at least I know now why my attempts to reproduce the problem
> didn't work...
>
> Right, patch below should fix the problem.
Haven't seen anything out of the ordinary since I applied that,
so I'd call it good.
> What a frustrating bug. Now, where's my bottle of scotch?
heh, enjoy the weekend.
Dave
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Dave Jones <davej@redhat.com>
To: Dave Chinner <david@fromorbit.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>, xfs@oss.sgi.com
Subject: Re: XFS assertion from truncate. (3.10-rc2)
Date: Fri, 24 May 2013 16:16:55 -0400 [thread overview]
Message-ID: <20130524201655.GA23086@redhat.com> (raw)
In-Reply-To: <20130524080300.GI24543@dastard>
On Fri, May 24, 2013 at 06:03:00PM +1000, Dave Chinner wrote:
> xfstest generic/193 is *supposed* to test behaviour of suid/sgid bits
> and clearing them is various situations.
>
> You know what I'm about to say, don't you? The test doesn't test
> what it thinks it is testing. it puts the destination file in root
> directory of the xfstests harness, not in the filesystems being
> tested.
awesome, two bugs for the price of one!
> So, on all my machines, it runs on ext3 filesystems, never on the
> ext4, btrfs, xfs, etc filesystems that I'm actually testing.
>
> That's beside the point, because it doesn't test truncate behaviour.
> But at least I know now why my attempts to reproduce the problem
> didn't work...
>
> Right, patch below should fix the problem.
Haven't seen anything out of the ordinary since I applied that,
so I'd call it good.
> What a frustrating bug. Now, where's my bottle of scotch?
heh, enjoy the weekend.
Dave
next prev parent reply other threads:[~2013-05-24 20:17 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-21 22:52 XFS assertion from truncate. (3.10-rc2) Dave Jones
2013-05-21 22:52 ` Dave Jones
2013-05-21 23:34 ` Dave Chinner
2013-05-21 23:34 ` Dave Chinner
2013-05-21 23:40 ` Dave Jones
2013-05-21 23:40 ` Dave Jones
2013-05-21 23:54 ` Dave Chinner
2013-05-21 23:54 ` Dave Chinner
2013-05-22 0:08 ` Dave Jones
2013-05-22 0:08 ` Dave Jones
2013-05-22 0:16 ` Dave Chinner
2013-05-22 0:16 ` Dave Chinner
2013-05-22 2:56 ` Dave Jones
2013-05-22 2:56 ` Dave Jones
2013-05-22 4:03 ` Dave Chinner
2013-05-22 4:03 ` Dave Chinner
2013-05-22 4:15 ` Dave Jones
2013-05-22 4:15 ` Dave Jones
2013-05-22 5:12 ` Dave Chinner
2013-05-22 5:12 ` Dave Chinner
2013-05-22 5:29 ` Dave Jones
2013-05-22 5:29 ` Dave Jones
2013-05-22 5:51 ` Dave Chinner
2013-05-22 5:51 ` Dave Chinner
2013-05-22 14:22 ` Dave Jones
2013-05-22 14:22 ` Dave Jones
2013-05-22 16:19 ` Dave Jones
2013-05-22 16:19 ` Dave Jones
2013-05-22 22:09 ` Dave Chinner
2013-05-22 22:09 ` Dave Chinner
2013-05-22 23:53 ` Dave Jones
2013-05-22 23:53 ` Dave Jones
2013-05-23 15:17 ` Dave Jones
2013-05-23 15:17 ` Dave Jones
2013-05-23 18:13 ` Dave Jones
2013-05-23 18:13 ` Dave Jones
2013-05-22 21:54 ` Dave Chinner
2013-05-22 21:54 ` Dave Chinner
2013-05-23 18:49 ` Dave Jones
2013-05-23 18:49 ` Dave Jones
2013-05-23 22:30 ` Dave Chinner
2013-05-23 22:30 ` Dave Chinner
2013-05-24 0:49 ` Dave Jones
2013-05-24 0:49 ` Dave Jones
2013-05-24 1:26 ` Dave Chinner
2013-05-24 1:26 ` Dave Chinner
2013-05-24 1:36 ` Dave Jones
2013-05-24 1:36 ` Dave Jones
2013-05-24 1:52 ` Dave Jones
2013-05-24 1:52 ` Dave Jones
2013-05-24 3:03 ` Dave Jones
2013-05-24 3:03 ` Dave Jones
2013-05-24 8:03 ` Dave Chinner
2013-05-24 8:03 ` Dave Chinner
2013-05-24 20:16 ` Dave Jones [this message]
2013-05-24 20:16 ` Dave Jones
2013-05-25 4:58 ` Eric Sandeen
2013-05-25 4:58 ` Eric Sandeen
2013-05-25 6:39 ` Stan Hoeppner
2013-05-26 22:43 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130524201655.GA23086@redhat.com \
--to=davej@redhat.com \
--cc=david@fromorbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.