From: Christoph Hellwig <hch@infradead.org>
To: J??rn Engel <joern@logfs.org>
Cc: Hannes Reinecke <hare@suse.de>,
linux-scsi@vger.kernel.org, Ewan Milne <emilne@redhat.com>,
James Smart <james.smart@emulex.com>,
Bryn Reeves <bmr@redhat.com>,
Roland Dreier <roland@purestorage.com>
Subject: Re: [PATCH 1/4] scsi: move initialization of scmd->eh_entry
Date: Sat, 25 May 2013 04:47:42 -0400 [thread overview]
Message-ID: <20130525084742.GA3288@infradead.org> (raw)
In-Reply-To: <20130524165739.GC30270@logfs.org>
On Fri, May 24, 2013 at 12:57:40PM -0400, J??rn Engel wrote:
> > memset(cmd->sense_buffer, 0, SCSI_SENSE_BUFFERSIZE);
> > if (cmd->cmd_len == 0)
> > cmd->cmd_len = scsi_command_size(cmd->cmnd);
> > + INIT_LIST_HEAD(&cmd->eh_entry);
> > + cmd->eh_eflags = 0;
>
> I always suspect something subtle going on when a variable is
> initialized to 0 three lines below a memset. Can line this go away?
The memset only zeroes the sense_buffer, not the whole scsi command
which would cause a major havoc for the callers.
next prev parent reply other threads:[~2013-05-25 8:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-24 9:50 [PATCH 0/4] New FC timeout handler Hannes Reinecke
2013-05-24 9:50 ` [PATCH 1/4] scsi: move initialization of scmd->eh_entry Hannes Reinecke
2013-05-24 16:57 ` Jörn Engel
2013-05-25 8:47 ` Christoph Hellwig [this message]
2013-05-24 9:50 ` [PATCH 2/4] blk-timeout: add BLK_EH_SCHEDULED return code Hannes Reinecke
2013-05-24 9:50 ` [PATCH 3/4] scsi: export functions for new fc timeout handler Hannes Reinecke
2013-05-24 9:50 ` [PATCH 4/4] scsi_transport_fc: FC " Hannes Reinecke
2013-05-25 5:08 ` Christoph Hellwig
2013-05-25 9:38 ` Hannes Reinecke
2013-05-25 8:42 ` Christoph Hellwig
2013-05-25 9:55 ` Hannes Reinecke
2013-06-05 21:55 ` Jörn Engel
2013-05-30 8:37 ` [PATCH 0/4] New " Ren Mingxin
2013-05-30 12:01 ` Hannes Reinecke
-- strict thread matches above, loose matches on Subject: below --
2013-06-06 9:43 [PATCH 0/4] New SCSI command " Hannes Reinecke
2013-06-06 9:43 ` [PATCH 1/4] scsi: move initialization of scmd->eh_entry Hannes Reinecke
2013-06-06 16:14 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130525084742.GA3288@infradead.org \
--to=hch@infradead.org \
--cc=bmr@redhat.com \
--cc=emilne@redhat.com \
--cc=hare@suse.de \
--cc=james.smart@emulex.com \
--cc=joern@logfs.org \
--cc=linux-scsi@vger.kernel.org \
--cc=roland@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.