All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ren Mingxin <renmx@cn.fujitsu.com>
To: Hannes Reinecke <hare@suse.de>
Cc: linux-scsi@vger.kernel.org, Ewan Milne <emilne@redhat.com>,
	James Smart <james.smart@emulex.com>,
	Bryn Reeves <bmr@redhat.com>,
	Roland Dreier <roland@purestorage.com>,
	Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 0/4] New FC timeout handler
Date: Thu, 30 May 2013 16:37:39 +0800	[thread overview]
Message-ID: <51A70FD3.90908@cn.fujitsu.com> (raw)
In-Reply-To: <1369389050-118628-1-git-send-email-hare@suse.de>

Hi, Hannes:

On 05/24/2013 05:50 PM, Hannes Reinecke wrote:
> this is the first step towards a new FC error handler.
> This patch implements a new FC command timeout handler
> which will be sending command aborts inline without
> engaging SCSI EH.
>
> In addition the commands will be returned directly
> if the command abort succeeded, cutting down recovery
> times dramatically.

To the commands which can be aborted successfully, I guess your
patchset has solved the problem "the error handler can't even be
called until host_failed == host_busy", because it needn't to
wait for the scheduling of EH threads(without engaging SCSI EH
as you said) now, right?

> For any other return code from 'eh_abort_handler' the command
> will be pushed onto the existing SCSI EH handler, or aborted
> with an error if that fails.

To the commands which can NOT be aborted successfully, there is
not any improvements for the SCSI EH will be invoked as usual.
But should we consider the repetitive/time-consuming issue for
the commands will be tried to abort again in the SCSI EH handler?

Thanks,
Ren

  parent reply	other threads:[~2013-05-30  9:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-24  9:50 [PATCH 0/4] New FC timeout handler Hannes Reinecke
2013-05-24  9:50 ` [PATCH 1/4] scsi: move initialization of scmd->eh_entry Hannes Reinecke
2013-05-24 16:57   ` Jörn Engel
2013-05-25  8:47     ` Christoph Hellwig
2013-05-24  9:50 ` [PATCH 2/4] blk-timeout: add BLK_EH_SCHEDULED return code Hannes Reinecke
2013-05-24  9:50 ` [PATCH 3/4] scsi: export functions for new fc timeout handler Hannes Reinecke
2013-05-24  9:50 ` [PATCH 4/4] scsi_transport_fc: FC " Hannes Reinecke
2013-05-25  5:08   ` Christoph Hellwig
2013-05-25  9:38     ` Hannes Reinecke
2013-05-25  8:42       ` Christoph Hellwig
2013-05-25  9:55         ` Hannes Reinecke
2013-06-05 21:55           ` Jörn Engel
2013-05-30  8:37 ` Ren Mingxin [this message]
2013-05-30 12:01   ` [PATCH 0/4] New " Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51A70FD3.90908@cn.fujitsu.com \
    --to=renmx@cn.fujitsu.com \
    --cc=bmr@redhat.com \
    --cc=emilne@redhat.com \
    --cc=hare@suse.de \
    --cc=hch@infradead.org \
    --cc=james.smart@emulex.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=roland@purestorage.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.