All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCHv4 0/6] arm: Initial TI-Nspire support
Date: Sun, 26 May 2013 23:23:29 +0200	[thread overview]
Message-ID: <201305262323.29519.arnd@arndb.de> (raw)
In-Reply-To: <1369480087-24786-1-git-send-email-dt.tangr@gmail.com>

On Saturday 25 May 2013, Daniel Tang wrote:
> Changes between v3 and v4:
> * Remove redundant clock-names in device tree
> * Re-enable bus access to some peripherals on bootup
> * Clean up nspire-classic-timer code.
>   - Implement a nspire_timer_set_mode function
>   - Removed messy IO_MATCHx and CNTL_MATCHx macros
>   - Timer starts disabled to begin with
>   - Interrupt handling code return IRQ_NONE for spurious interrupts
>   - Delete unnessecary shift
> * Change clk-nspire to use compatible property to determine IO type
> * Change device tree bindings to have appropriate vendor prefixes
> * Added device tree binding documentation
> * Fix incorrect register addresses for clocks
> * Use more specific .caps for CLCD

Looks really good now. I have a few more comments for the first patch,
mostly for stuff that can be simplified based on stuff we merged in 3.10.

The one remaining bit that sticks out is the clcd platform data. As I
said before, I won't require you to convert that to DT in order to
get your code merged, but I'd also really like to see that happen,
as we will also need that to get rid of auxdata on the ARM reference
platforms (integrator, versatile, realview, vexpress).

Are you motivated to look into those after the base patch gets
merged into arm-soc?

One comment on the merge path: While we can put any of the patches
into the arm-soc tree, my preference is definitely for the clk,
clksource, irqchip and input drivers to go through the respective
maintainer trees. There are no dependencies to worry about, since
each patch can compile standalone, and we just need to make sure
they all get into 3.11 for your platform to work.

	Arnd

WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Daniel Tang <dt.tangr@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
	"linux@arm.linux.org.uk ARM Linux" <linux@arm.linux.org.uk>,
	Linus Walleij <linus.walleij@linaro.org>,
	"fabian@ritter-vogt.de Vogt" <fabian@ritter-vogt.de>,
	Lionel Debroux <lionel_debroux@yahoo.fr>,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCHv4 0/6] arm: Initial TI-Nspire support
Date: Sun, 26 May 2013 23:23:29 +0200	[thread overview]
Message-ID: <201305262323.29519.arnd@arndb.de> (raw)
In-Reply-To: <1369480087-24786-1-git-send-email-dt.tangr@gmail.com>

On Saturday 25 May 2013, Daniel Tang wrote:
> Changes between v3 and v4:
> * Remove redundant clock-names in device tree
> * Re-enable bus access to some peripherals on bootup
> * Clean up nspire-classic-timer code.
>   - Implement a nspire_timer_set_mode function
>   - Removed messy IO_MATCHx and CNTL_MATCHx macros
>   - Timer starts disabled to begin with
>   - Interrupt handling code return IRQ_NONE for spurious interrupts
>   - Delete unnessecary shift
> * Change clk-nspire to use compatible property to determine IO type
> * Change device tree bindings to have appropriate vendor prefixes
> * Added device tree binding documentation
> * Fix incorrect register addresses for clocks
> * Use more specific .caps for CLCD

Looks really good now. I have a few more comments for the first patch,
mostly for stuff that can be simplified based on stuff we merged in 3.10.

The one remaining bit that sticks out is the clcd platform data. As I
said before, I won't require you to convert that to DT in order to
get your code merged, but I'd also really like to see that happen,
as we will also need that to get rid of auxdata on the ARM reference
platforms (integrator, versatile, realview, vexpress).

Are you motivated to look into those after the base patch gets
merged into arm-soc?

One comment on the merge path: While we can put any of the patches
into the arm-soc tree, my preference is definitely for the clk,
clksource, irqchip and input drivers to go through the respective
maintainer trees. There are no dependencies to worry about, since
each patch can compile standalone, and we just need to make sure
they all get into 3.11 for your platform to work.

	Arnd

  parent reply	other threads:[~2013-05-26 21:23 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-25 11:08 [RFC PATCHv4 0/6] arm: Initial TI-Nspire support Daniel Tang
2013-05-25 11:08 ` Daniel Tang
2013-05-25 11:08 ` [RFC PATCHv4 1/6] arm: TI-Nspire platform code Daniel Tang
2013-05-25 11:08   ` Daniel Tang
2013-05-26 20:46   ` Arnd Bergmann
2013-05-26 20:46     ` Arnd Bergmann
2013-05-27  4:07     ` Daniel Tang
2013-05-27  4:07       ` Daniel Tang
2013-05-27  6:56       ` Arnd Bergmann
2013-05-27  6:56         ` Arnd Bergmann
     [not found]         ` <CAPnH9dnA22C3ZS9jgJNytnmKM_8Vfk7OxNRB1Mg03=q7KhHZBA@mail.gmail.com>
     [not found]           ` <201305271715.02385.arnd@arndb.de>
2013-05-29  5:14             ` Daniel Tang
2013-05-29  5:14               ` Daniel Tang
2013-05-29  7:58               ` Arnd Bergmann
2013-05-29  7:58                 ` Arnd Bergmann
2013-05-25 11:08 ` [RFC PATCHv4 2/6] arm: TI-Nspire device trees Daniel Tang
2013-05-25 11:08   ` Daniel Tang
2013-05-25 11:08 ` [RFC PATCHv4 3/6] clk: TI-Nspire clock drivers Daniel Tang
2013-05-25 11:08   ` Daniel Tang
2013-05-31  1:16   ` Mike Turquette
2013-05-31  1:16     ` Mike Turquette
2013-05-25 11:08 ` [RFC PATCHv4 4/6] clocksource: TI-Nspire timer support Daniel Tang
2013-05-25 11:08   ` Daniel Tang
2013-05-27 10:53   ` Linus Walleij
2013-05-27 10:53     ` Linus Walleij
2013-05-27 10:56     ` Daniel Tang
2013-05-27 10:56       ` Daniel Tang
2013-05-27 12:28     ` Thomas Gleixner
2013-05-27 12:28       ` Thomas Gleixner
2013-05-25 11:08 ` [RFC PATCHv4 5/6] input: TI-Nspire keypad support Daniel Tang
2013-05-25 11:08   ` Daniel Tang
2013-05-25 11:08 ` [RFC PATCHv4 6/6] irqchip: TI-Nspire irqchip support Daniel Tang
2013-05-25 11:08   ` Daniel Tang
2013-05-30 21:29   ` Grant Likely
2013-05-30 21:29     ` Grant Likely
2013-05-26 21:23 ` Arnd Bergmann [this message]
2013-05-26 21:23   ` [RFC PATCHv4 0/6] arm: Initial TI-Nspire support Arnd Bergmann
2013-05-27  2:23   ` Daniel Tang
2013-05-27  2:23     ` Daniel Tang
2013-05-27 10:31     ` Arnd Bergmann
2013-05-27 10:31       ` Arnd Bergmann
2013-05-28 10:52       ` Pawel Moll
2013-05-28 10:52         ` Pawel Moll
2013-05-31  7:43         ` Laurent Pinchart
2013-05-31  7:43           ` Laurent Pinchart
2013-05-29  5:18       ` Daniel Tang
2013-05-29  5:18         ` Daniel Tang
2013-05-29 12:46         ` Arnd Bergmann
2013-05-29 12:46           ` Arnd Bergmann
2013-05-27 10:32     ` Arnd Bergmann
2013-05-27 10:32       ` Arnd Bergmann
2013-05-28 10:54       ` Pawel Moll
2013-05-28 10:54         ` Pawel Moll
2013-05-28 14:16         ` Linus Walleij
2013-05-28 14:16           ` Linus Walleij
2013-05-28 14:21           ` Pawel Moll
2013-05-28 14:21             ` Pawel Moll
2013-05-28 14:52             ` Arnd Bergmann
2013-05-28 14:52               ` Arnd Bergmann
2013-05-28 15:10               ` Andy Shevchenko
2013-05-28 15:10                 ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201305262323.29519.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.