From: Olof Johansson <olof@lixom.net>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 05/11] ARM: shmobile: APE6EVM LAN9220 support
Date: Tue, 28 May 2013 02:45:40 +0000 [thread overview]
Message-ID: <20130528024540.GC13532@quad.lixom.net> (raw)
In-Reply-To: <Pine.LNX.4.64.1305221911380.12715@axis700.grange>
Hi,
Sorry, a bit behind on email and just discovered this.
On Wed, May 22, 2013 at 07:22:59PM +0200, Guennadi Liakhovetski wrote:
> > > The above didn't work in my tests without this:
> > >
> > > diff --git a/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> > > b/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> > > index f603c69..4fb0102 100644
> > > --- a/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> > > +++ b/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> > > @@ -33,8 +33,10 @@
> > > };
> > >
> > > lbsc {
> > > + compatible = "simple-bus";
> > > #address-cells = <1>;
> > > #size-cells = <1>;
> > > + ranges = <0 0 0 0x80000000>;
> > >
> > > ethernet@8000000 {
> > > compatible = "smsc,lan9118", "smsc,lan9115";
> > >
> >
> > Could you please post this as a formal patch and indicate
> > if you would like it included as a fix in v3.10 or not?
>
> Can do that, sure, just thought maybe it would be better to fix the
> original patch. Besides, I wasn't sure what the correct values for
> "ranges" are, I just picked up something, that would be sufficient for
> ethernet. But if more devices are added to it in the future, maybe
> different ranges values would be needed. I think actually, lbsc should map
> the 3 BSC areas, so, the correct property would be
>
> + ranges = <0 0 0 0x14000000>;
>
> > Also, I am curious to know what your tests are.
>
> Just booting with NFS root. I think, anything involving ethernet. Without
> the "simple-bus" property the lbsc node doesn't get scanned, so, no device
> is added. Without "ranges" addresses cannot be mapped correctly.
Since it's a flat mapping you can just specify an empty "ranges" property, no
need to actually define contents.
For more info, see http://devicetree.org/Device_Tree_Usage#Ranges_.28Address_Translation.29
-Olof
WARNING: multiple messages have this Message-ID (diff)
From: olof@lixom.net (Olof Johansson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 05/11] ARM: shmobile: APE6EVM LAN9220 support
Date: Mon, 27 May 2013 19:45:40 -0700 [thread overview]
Message-ID: <20130528024540.GC13532@quad.lixom.net> (raw)
In-Reply-To: <Pine.LNX.4.64.1305221911380.12715@axis700.grange>
Hi,
Sorry, a bit behind on email and just discovered this.
On Wed, May 22, 2013 at 07:22:59PM +0200, Guennadi Liakhovetski wrote:
> > > The above didn't work in my tests without this:
> > >
> > > diff --git a/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> > > b/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> > > index f603c69..4fb0102 100644
> > > --- a/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> > > +++ b/arch/arm/boot/dts/r8a73a4-ape6evm.dts
> > > @@ -33,8 +33,10 @@
> > > };
> > >
> > > lbsc {
> > > + compatible = "simple-bus";
> > > #address-cells = <1>;
> > > #size-cells = <1>;
> > > + ranges = <0 0 0 0x80000000>;
> > >
> > > ethernet at 8000000 {
> > > compatible = "smsc,lan9118", "smsc,lan9115";
> > >
> >
> > Could you please post this as a formal patch and indicate
> > if you would like it included as a fix in v3.10 or not?
>
> Can do that, sure, just thought maybe it would be better to fix the
> original patch. Besides, I wasn't sure what the correct values for
> "ranges" are, I just picked up something, that would be sufficient for
> ethernet. But if more devices are added to it in the future, maybe
> different ranges values would be needed. I think actually, lbsc should map
> the 3 BSC areas, so, the correct property would be
>
> + ranges = <0 0 0 0x14000000>;
>
> > Also, I am curious to know what your tests are.
>
> Just booting with NFS root. I think, anything involving ethernet. Without
> the "simple-bus" property the lbsc node doesn't get scanned, so, no device
> is added. Without "ranges" addresses cannot be mapped correctly.
Since it's a flat mapping you can just specify an empty "ranges" property, no
need to actually define contents.
For more info, see http://devicetree.org/Device_Tree_Usage#Ranges_.28Address_Translation.29
-Olof
next prev parent reply other threads:[~2013-05-28 2:45 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-03 2:08 [GIT PULL v2] Renesas ARM SoC board updates for v3.10 #3 Simon Horman
2013-04-03 2:08 ` Simon Horman
2013-04-03 2:08 ` [PATCH 01/11] ARM: shmobile: add R-Car M1A Bock-W platform support Simon Horman
2013-04-03 2:08 ` Simon Horman
2013-04-03 2:08 ` [PATCH 02/11] ARM: shmobile: kzm9g-reference: add ethernet support Simon Horman
2013-04-03 2:08 ` Simon Horman
2013-04-03 2:08 ` [PATCH 03/11] ARM: shmobile: APE6EVM base support Simon Horman
2013-04-03 2:08 ` Simon Horman
2013-04-03 2:08 ` [PATCH 04/11] ARM: shmobile: APE6EVM PFC support Simon Horman
2013-04-03 2:08 ` Simon Horman
2013-04-03 2:08 ` [PATCH 05/11] ARM: shmobile: APE6EVM LAN9220 support Simon Horman
2013-04-03 2:08 ` Simon Horman
2013-05-17 13:00 ` Guennadi Liakhovetski
2013-05-17 13:00 ` Guennadi Liakhovetski
2013-05-22 14:32 ` Simon Horman
2013-05-22 14:32 ` Simon Horman
2013-05-22 17:22 ` Guennadi Liakhovetski
2013-05-22 17:22 ` Guennadi Liakhovetski
2013-05-25 1:01 ` Simon Horman
2013-05-25 1:01 ` Simon Horman
2013-05-28 2:45 ` Olof Johansson [this message]
2013-05-28 2:45 ` Olof Johansson
2013-05-29 6:26 ` Guennadi Liakhovetski
2013-05-29 6:26 ` Guennadi Liakhovetski
2013-05-30 4:39 ` Olof Johansson
2013-05-30 4:39 ` Olof Johansson
2013-05-30 5:33 ` Guennadi Liakhovetski
2013-05-30 5:33 ` Guennadi Liakhovetski
2013-05-30 13:26 ` Arnd Bergmann
2013-05-30 13:26 ` Arnd Bergmann
2013-04-03 2:08 ` [PATCH 06/11] ARM: shmobile: Initial r8a7790 Lager board support Simon Horman
2013-04-03 2:08 ` Simon Horman
2013-04-03 2:08 ` [PATCH 07/11] ARM: shmobile: mackerel: SDHI resources do not have to be numbered Simon Horman
2013-04-03 2:08 ` Simon Horman
2013-04-03 2:08 ` [PATCH 08/11] ARM: shmobile: mackerel: remove OCR masks, where regulators are used Simon Horman
2013-04-03 2:08 ` Simon Horman
2013-04-03 2:08 ` [PATCH 09/11] ARM: shmobile: mackerel: switch SDHI and MMCIF interfaces to slot-gpio Simon Horman
2013-04-03 2:08 ` Simon Horman
2013-04-03 2:08 ` [PATCH 10/11] ARM: shmobile: mackerel: add interrupt names for SDHI0 Simon Horman
2013-04-03 2:08 ` Simon Horman
2013-04-03 2:08 ` [PATCH 11/11] ARM: shmobile: mackerel: clean up MMCIF vs. SDHI1 selection Simon Horman
2013-04-03 2:08 ` Simon Horman
2013-04-03 6:30 ` [GIT PULL v2] Renesas ARM SoC board updates for v3.10 #3 Olof Johansson
2013-04-03 6:30 ` Olof Johansson
2013-04-04 3:33 ` Simon Horman
2013-04-04 3:33 ` Simon Horman
-- strict thread matches above, loose matches on Subject: below --
2013-04-02 5:11 Simon Horman
2013-04-02 5:11 ` [PATCH 05/11] ARM: shmobile: APE6EVM LAN9220 support Simon Horman
2013-04-02 5:11 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130528024540.GC13532@quad.lixom.net \
--to=olof@lixom.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.