Re: [Qemu-devel] [PATCH v6 00/12] curl: fix curl read

["Richard W.M. Jones" <rjones@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1293 bytes --]

[I chopped the CC list down]

On Tue, May 28, 2013 at 07:14:01PM +0800, Fam Zheng wrote:
> There seems no easy way to me to inject sleep to io reqs in curl.c.
> Another option might be configure & compile qemu with
> CFLAGS=-DDEBUG_CURL and grab the stdout, so that we can see how requests
> are processed.

No problems.

I started with v6 patch.  I did:

$ CFLAGS=-DDEBUG_CURL ./configure --enable-werror --target-list="i386-softmmu x86_64-softmmu"
$ make

Note there is a bug!

block/curl.c: In function ‘curl_complete_io’:
block/curl.c:211:5: error: too many arguments for format [-Werror=format-extra-args]
cc1: all warnings being treated as errors
make: *** [block/curl.o] Error 1

Please add the attached patch to your patch set.

After fixing that and continuing the build, I then ran:

$ /tmp/test.sh >& /tmp/curl-debug.log

This shows the error and produces an absolutely vast amount of
debugging (attached).  Note that I killed it after a while but there
should be enough to show the error.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW

[-- Attachment #2: 0001-curl-Fix-format-string-in-debugging-statement.patch --]
[-- Type: text/plain, Size: 901 bytes --]

>From 9fdcf62e2e0a42c30fb8ff040ce4b147ca89996b Mon Sep 17 00:00:00 2001
From: "Richard W.M. Jones" <rjones@redhat.com>
Date: Tue, 28 May 2013 12:21:34 +0100
Subject: [PATCH] curl: Fix format string in debugging statement.

Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
---
 block/curl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/curl.c b/block/curl.c
index 50c7188..3e330b6 100644
--- a/block/curl.c
+++ b/block/curl.c
@@ -208,7 +208,7 @@ static void curl_complete_io(BDRVCURLState *bs, CURLAIOCB *acb,
 
     qemu_iovec_from_buf(acb->qiov, 0, cache->data + off, aio_bytes);
     acb->common.cb(acb->common.opaque, 0);
-    DPRINTF("AIO Request OK: " PRId64 "%10zd\n", aio_base, aio_bytes);
+    DPRINTF("AIO Request OK: %" PRId64 "%10zd\n", aio_base, aio_bytes);
     qemu_aio_release(acb);
     acb = NULL;
     /* Move cache next in the list */
-- 
1.8.2.1


[-- Attachment #3: curl-debug.log.xz --]
[-- Type: application/x-xz, Size: 53236 bytes --]