Re: [Qemu-devel] [PATCH v6 00/12] curl: fix curl read

["Richard W.M. Jones" <rjones@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 512 bytes --]


This fixes the obvious bug.

I wonder if it should be even larger?  One use for curl is to install
guests using ISOs from websites without having to download the ISO,
and I imagine that even a 30 second timeout could be conservative for
that task.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top

[-- Attachment #2: 0001-curl-Increase-block-timeout.patch --]
[-- Type: text/plain, Size: 941 bytes --]

>From b53db35e299f1bf28daa82a322b999a3515a53b5 Mon Sep 17 00:00:00 2001
From: "Richard W.M. Jones" <rjones@redhat.com>
Date: Tue, 28 May 2013 12:30:07 +0100
Subject: [PATCH] curl: Increase block timeout.

Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
---
 block/curl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/curl.c b/block/curl.c
index 3e330b6..759f7cb 100644
--- a/block/curl.c
+++ b/block/curl.c
@@ -332,7 +332,7 @@ static CURLState *curl_init_state(BDRVCURLState *s)
         goto out;
     }
     curl_easy_setopt(state->curl, CURLOPT_URL, s->url);
-    curl_easy_setopt(state->curl, CURLOPT_TIMEOUT, 5);
+    curl_easy_setopt(state->curl, CURLOPT_TIMEOUT, 30);
     curl_easy_setopt(state->curl, CURLOPT_WRITEFUNCTION, (void *)curl_read_cb);
     curl_easy_setopt(state->curl, CURLOPT_WRITEDATA, (void *)state);
     curl_easy_setopt(state->curl, CURLOPT_PRIVATE, (void *)state);
-- 
1.8.2.1