From: Joerg Roedel <joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
To: Libo Chen <clbchenlibo.chen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
Cc: ohad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org,
joerg.roedel-5C7GfCeVMHo@public.gmane.org,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org,
davidb-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Subject: Re: [PATCH] msm: iommu: fix leak and invalid access
Date: Tue, 28 May 2013 14:27:55 +0200 [thread overview]
Message-ID: <20130528122754.GD2575@8bytes.org> (raw)
In-Reply-To: <519C5E8F.7060006-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
On Wed, May 22, 2013 at 01:58:39PM +0800, Libo Chen wrote:
> >
> > This patch merge two patch that I sended before:
> > 1. msm: iommu: add missing platform_device_unregister() in err case
> > 2. msm: iommu: no need kfree before kzalloc successful
> >
> > It fixes two obvious problems:
> > 1. We have registered msm_iommu_driver first, and need unregister it when
> > registered msm_iommu_ctx_driver fail
> >
> > 2. We don`t need to kfree drvdata before kzalloc successful
> >
> > Signed-off-by: Libo Chen <libo.chen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
> > ---
> > drivers/iommu/msm_iommu_dev.c | 11 +++++------
> > 1 files changed, 5 insertions(+), 6 deletions(-)
Has this patch already been handled? If not please resend it to me and I
will take care of it.
Joerg
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Libo Chen <clbchenlibo.chen@huawei.com>
Cc: ohad@wizery.com, joerg.roedel@amd.com, davidb@codeaurora.org,
LKML <linux-kernel@vger.kernel.org>,
Varun.Sethi@freescale.com, iommu@lists.linux-foundation.org,
mingo@kernel.org, ddutile@redhat.com
Subject: Re: [PATCH] msm: iommu: fix leak and invalid access
Date: Tue, 28 May 2013 14:27:55 +0200 [thread overview]
Message-ID: <20130528122754.GD2575@8bytes.org> (raw)
In-Reply-To: <519C5E8F.7060006@huawei.com>
On Wed, May 22, 2013 at 01:58:39PM +0800, Libo Chen wrote:
> >
> > This patch merge two patch that I sended before:
> > 1. msm: iommu: add missing platform_device_unregister() in err case
> > 2. msm: iommu: no need kfree before kzalloc successful
> >
> > It fixes two obvious problems:
> > 1. We have registered msm_iommu_driver first, and need unregister it when
> > registered msm_iommu_ctx_driver fail
> >
> > 2. We don`t need to kfree drvdata before kzalloc successful
> >
> > Signed-off-by: Libo Chen <libo.chen@huawei.com>
> > ---
> > drivers/iommu/msm_iommu_dev.c | 11 +++++------
> > 1 files changed, 5 insertions(+), 6 deletions(-)
Has this patch already been handled? If not please resend it to me and I
will take care of it.
Joerg
next prev parent reply other threads:[~2013-05-28 12:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 4:47 [PATCH] msm: iommu: fix leak and invalid access Libo Chen
2013-05-22 5:58 ` Libo Chen
2013-05-22 5:58 ` Libo Chen
2013-05-22 22:29 ` David Brown
2013-05-23 1:23 ` Libo Chen
2013-05-23 1:23 ` Libo Chen
[not found] ` <519C5E8F.7060006-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2013-05-28 12:27 ` Joerg Roedel [this message]
2013-05-28 12:27 ` Joerg Roedel
[not found] ` <20130528122754.GD2575-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>
2013-05-28 12:37 ` Libo Chen
2013-05-28 12:37 ` Libo Chen
2013-05-22 22:30 ` David Brown
2013-05-23 23:26 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130528122754.GD2575@8bytes.org \
--to=joro-zlv9swrftaidnm+yrofe0a@public.gmane.org \
--cc=Varun.Sethi-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=clbchenlibo.chen-hv44wF8Li93QT0dZR+AlfA@public.gmane.org \
--cc=davidb-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=joerg.roedel-5C7GfCeVMHo@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=ohad-Ix1uc/W3ht7QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.