All of lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/5] irqchip: mmp: support irqchip
Date: Tue, 28 May 2013 19:26:47 +0200	[thread overview]
Message-ID: <201305281926.47790.arnd@arndb.de> (raw)
In-Reply-To: <1369707707-30295-3-git-send-email-haojian.zhuang@gmail.com>

On Tuesday 28 May 2013, Haojian Zhuang wrote:
>         icu_data[0].domain = irq_domain_add_legacy(node, nr_irqs, 0, 0,
>                                                    &mmp_irq_domain_ops,
>                                                    &icu_data[0]);

Is there anything stopping you from converting to the linear domain now?

> +IRQCHIP_DECLARE(mmp_intc, "mrvl,mmp-intc", mmp_of_init);
> +IRQCHIP_DECLARE(mmp2_intc, "mrvl,mmp2-intc", mmp2_of_init);
> +IRQCHIP_DECLARE(mmp2_mux_intc, "mrvl,mmp2-mux-intc", mmp2_mux_of_init);

Please put each line directly after the function it refers to,
similar to how we do it for EXPORT_SYMBOL.

	Arnd

  reply	other threads:[~2013-05-28 17:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-28  2:21 [PATCH v2 0/5] ARM: mmp: move irq driver into irqchip Haojian Zhuang
2013-05-28  2:21 ` [PATCH v2 1/5] irqchip: move mmp irq driver Haojian Zhuang
2013-05-28  2:21 ` [PATCH v2 2/5] irqchip: mmp: support irqchip Haojian Zhuang
2013-05-28 17:26   ` Arnd Bergmann [this message]
2013-05-28  2:21 ` [PATCH v2 3/5] irqchip: mmp: support MULTI_IRQ_HANDLER Haojian Zhuang
2013-05-28  2:21 ` [PATCH v2 4/5] ARM: mmp: move irqs head file Haojian Zhuang
2013-05-28 17:32   ` Arnd Bergmann
2013-05-28  2:21 ` [PATCH v2 5/5] ARM: mmp: avoid to include head file in mach-mmp Haojian Zhuang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201305281926.47790.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.