From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/5] ARM: mmp: move irqs head file
Date: Tue, 28 May 2013 19:32:44 +0200 [thread overview]
Message-ID: <201305281932.44663.arnd@arndb.de> (raw)
In-Reply-To: <1369707707-30295-5-git-send-email-haojian.zhuang@gmail.com>
On Tuesday 28 May 2013, Haojian Zhuang wrote:
> Since irq-mmp driver includes <mach/irqs.h>, it blocks the multiple
> platform build. So move the head file into include/linux/irqchip/
> directory.
>
> Signed-off-by: Haojian Zhuang <haojian.zhuang@gmail.com>
I disagree with simply moving the file. Let's check first what is actually
needed from it.
> arch/arm/mach-mmp/aspenite.c | 2 +-
> arch/arm/mach-mmp/avengers_lite.c | 2 +-
> arch/arm/mach-mmp/brownstone.c | 2 +-
> arch/arm/mach-mmp/devices.c | 2 +-
> arch/arm/mach-mmp/flint.c | 2 +-
> arch/arm/mach-mmp/gplugd.c | 2 +-
> arch/arm/mach-mmp/jasper.c | 2 +-
> arch/arm/mach-mmp/mmp2.c | 2 +-
> arch/arm/mach-mmp/pm-mmp2.c | 2 +-
> arch/arm/mach-mmp/pm-pxa910.c | 2 +-
> arch/arm/mach-mmp/pxa168.c | 2 +-
> arch/arm/mach-mmp/pxa910.c | 2 +-
> arch/arm/mach-mmp/tavorevb.c | 2 +-
> arch/arm/mach-mmp/teton_bga.c | 2 +-
> arch/arm/mach-mmp/time.c | 2 +-
> arch/arm/mach-mmp/ttc_dkb.c | 2 +-
> drivers/gpio/gpio-pxa.c | 3 +--
> drivers/irqchip/irq-mmp.c | 3 +--
> arch/arm/mach-mmp/include/mach/irqs.h => include/linux/irqchip/mmp.h | 0
> 19 files changed, 18 insertions(+), 20 deletions(-)
> rename arch/arm/mach-mmp/include/mach/irqs.h => include/linux/irqchip/mmp.h (100%)
My guess is that the long list of IRQ numbers is only needed for legacy
board files. That list would better be put into arch/arm/mach-mmp/irqs.h.
Try to move as much as you can from the include/linux/irqchip/mmp.h
file into that new header. Some constants (e.g irq base numbers
and mmio addresses) can be passed into the icu_init_irq/mmp2_init_icu
functions as arguments so you don't need them in the global header.
Arnd
next prev parent reply other threads:[~2013-05-28 17:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 2:21 [PATCH v2 0/5] ARM: mmp: move irq driver into irqchip Haojian Zhuang
2013-05-28 2:21 ` [PATCH v2 1/5] irqchip: move mmp irq driver Haojian Zhuang
2013-05-28 2:21 ` [PATCH v2 2/5] irqchip: mmp: support irqchip Haojian Zhuang
2013-05-28 17:26 ` Arnd Bergmann
2013-05-28 2:21 ` [PATCH v2 3/5] irqchip: mmp: support MULTI_IRQ_HANDLER Haojian Zhuang
2013-05-28 2:21 ` [PATCH v2 4/5] ARM: mmp: move irqs head file Haojian Zhuang
2013-05-28 17:32 ` Arnd Bergmann [this message]
2013-05-28 2:21 ` [PATCH v2 5/5] ARM: mmp: avoid to include head file in mach-mmp Haojian Zhuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201305281932.44663.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.