From: konrad.wilk@oracle.com (Konrad Rzeszutek Wilk)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/4] xen: move xen_setup_runstate_info and get_runstate_snapshot to drivers/xen/time.c
Date: Wed, 29 May 2013 14:01:32 -0400 [thread overview]
Message-ID: <20130529180132.GB10845@phenom.dumpdata.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1305291718430.4799@kaball.uk.xensource.com>
> > > > > +void xen_setup_runstate_info(int cpu)
> > > > > +{
> > > > > + struct vcpu_register_runstate_memory_area area;
> > > > > +
> > > > > + area.addr.v = &per_cpu(xen_runstate, cpu);
> > > > > +
> > > > > + if (HYPERVISOR_vcpu_op(VCPUOP_register_runstate_memory_area,
> > > > > + cpu, &area))
> > > > > + BUG();
> > > >
> > > > The original code did:
> > > >
> > > > - rc = HYPERVISOR_vcpu_op(VCPUOP_register_runstate_memory_area, cpu,
> > > > - &area);
> > > > - WARN_ON(rc && rc != -ENOSYS);
> > > > -
> > > > Any reason not to do this?
> > >
> > > The original x86 code just BUGs out: I took that version over the ia64
> > > version.
> >
> > Ah, I see it now. OK, then this looks good to me.
> >
>
> Can I add your acked-by? ;-)
How about?
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
WARNING: multiple messages have this Message-ID (diff)
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xensource.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, marc.zyngier@arm.com,
will.deacon@arm.com, Ian.Campbell@citrix.com
Subject: Re: [PATCH v4 1/4] xen: move xen_setup_runstate_info and get_runstate_snapshot to drivers/xen/time.c
Date: Wed, 29 May 2013 14:01:32 -0400 [thread overview]
Message-ID: <20130529180132.GB10845@phenom.dumpdata.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1305291718430.4799@kaball.uk.xensource.com>
> > > > > +void xen_setup_runstate_info(int cpu)
> > > > > +{
> > > > > + struct vcpu_register_runstate_memory_area area;
> > > > > +
> > > > > + area.addr.v = &per_cpu(xen_runstate, cpu);
> > > > > +
> > > > > + if (HYPERVISOR_vcpu_op(VCPUOP_register_runstate_memory_area,
> > > > > + cpu, &area))
> > > > > + BUG();
> > > >
> > > > The original code did:
> > > >
> > > > - rc = HYPERVISOR_vcpu_op(VCPUOP_register_runstate_memory_area, cpu,
> > > > - &area);
> > > > - WARN_ON(rc && rc != -ENOSYS);
> > > > -
> > > > Any reason not to do this?
> > >
> > > The original x86 code just BUGs out: I took that version over the ia64
> > > version.
> >
> > Ah, I see it now. OK, then this looks good to me.
> >
>
> Can I add your acked-by? ;-)
How about?
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
WARNING: multiple messages have this Message-ID (diff)
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xensource.com, Ian.Campbell@citrix.com,
marc.zyngier@arm.com, will.deacon@arm.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 1/4] xen: move xen_setup_runstate_info and get_runstate_snapshot to drivers/xen/time.c
Date: Wed, 29 May 2013 14:01:32 -0400 [thread overview]
Message-ID: <20130529180132.GB10845@phenom.dumpdata.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1305291718430.4799@kaball.uk.xensource.com>
> > > > > +void xen_setup_runstate_info(int cpu)
> > > > > +{
> > > > > + struct vcpu_register_runstate_memory_area area;
> > > > > +
> > > > > + area.addr.v = &per_cpu(xen_runstate, cpu);
> > > > > +
> > > > > + if (HYPERVISOR_vcpu_op(VCPUOP_register_runstate_memory_area,
> > > > > + cpu, &area))
> > > > > + BUG();
> > > >
> > > > The original code did:
> > > >
> > > > - rc = HYPERVISOR_vcpu_op(VCPUOP_register_runstate_memory_area, cpu,
> > > > - &area);
> > > > - WARN_ON(rc && rc != -ENOSYS);
> > > > -
> > > > Any reason not to do this?
> > >
> > > The original x86 code just BUGs out: I took that version over the ia64
> > > version.
> >
> > Ah, I see it now. OK, then this looks good to me.
> >
>
> Can I add your acked-by? ;-)
How about?
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
next prev parent reply other threads:[~2013-05-29 18:01 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 17:53 [PATCH v4 0/4] xen/arm: CONFIG_PARAVIRT and stolen ticks accounting Stefano Stabellini
2013-05-28 17:53 ` Stefano Stabellini
2013-05-28 17:54 ` [PATCH v4 1/4] xen: move xen_setup_runstate_info and get_runstate_snapshot to drivers/xen/time.c Stefano Stabellini
2013-05-28 17:54 ` Stefano Stabellini
2013-05-28 17:54 ` Stefano Stabellini
2013-05-28 18:15 ` Konrad Rzeszutek Wilk
2013-05-28 18:15 ` Konrad Rzeszutek Wilk
2013-05-28 18:15 ` Konrad Rzeszutek Wilk
2013-05-29 11:03 ` Stefano Stabellini
2013-05-29 11:03 ` Stefano Stabellini
2013-05-29 11:03 ` Stefano Stabellini
2013-05-29 15:55 ` Konrad Rzeszutek Wilk
2013-05-29 15:55 ` Konrad Rzeszutek Wilk
2013-05-29 15:55 ` Konrad Rzeszutek Wilk
2013-05-29 16:18 ` Stefano Stabellini
2013-05-29 16:18 ` Stefano Stabellini
2013-05-29 16:18 ` Stefano Stabellini
2013-05-29 18:01 ` Konrad Rzeszutek Wilk [this message]
2013-05-29 18:01 ` Konrad Rzeszutek Wilk
2013-05-29 18:01 ` Konrad Rzeszutek Wilk
2013-05-28 17:54 ` [PATCH v4 2/4] kernel: missing include in cputime.c Stefano Stabellini
2013-05-28 17:54 ` Stefano Stabellini
2013-05-28 17:54 ` Stefano Stabellini
2013-05-28 17:54 ` [PATCH v4 3/4] arm: introduce CONFIG_PARAVIRT, PARAVIRT_TIME_ACCOUNTING and pv_time_ops Stefano Stabellini
2013-05-28 17:54 ` Stefano Stabellini
2013-05-28 17:54 ` Stefano Stabellini
2013-05-29 18:09 ` Christopher Covington
2013-05-29 18:09 ` Christopher Covington
2013-05-29 18:09 ` Christopher Covington
2013-05-28 17:54 ` [PATCH v4 4/4] xen/arm: account for stolen ticks Stefano Stabellini
2013-05-28 17:54 ` Stefano Stabellini
2013-05-28 17:54 ` Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130529180132.GB10845@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.