From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: sunxi: "cpu_data" is defined in header files of some architectures
Date: Wed, 29 May 2013 15:48:49 -0700 [thread overview]
Message-ID: <20130529224849.6058.25112@quantum> (raw)
In-Reply-To: <1368798200-7063-1-git-send-email-emilio@elopez.com.ar>
Quoting Emilio L?pez (2013-05-17 06:43:20)
> From: "Giacomo A. Catenazzi" <cate@cateee.net>
>
> In some architectures, the #define cpu_data is not a "macro-function",
> so the compiler will substitute the identifier with probably something
> wrong.
>
> Signed-off-by: Giacomo A. Catenazzi <cate@cateee.net>
> Signed-off-by: Emilio L?pez <emilio@elopez.com.ar>
> [emilio at elopez.com.ar: use cpu_mux_data instead of this_cpu_data]
Taken into clk-next.
Regards,
Mike
> ---
>
> Hi Giacomo,
>
> I have taken your patch and resent it to linux-arm-kernel and Mike
> Turquette this time, but please try to use git send-email on your next
> patch.
>
> Here is a video from Greg that explains how to use it as well as other
> things (checkpatch.pl, get_maintainer.pl, etc)
>
> http://www.youtube.com/watch?v=LLBrBBImJt4
>
> Thanks! :)
>
> Emilio
>
> drivers/clk/sunxi/clk-sunxi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
> index 930d36f..412912b 100644
> --- a/drivers/clk/sunxi/clk-sunxi.c
> +++ b/drivers/clk/sunxi/clk-sunxi.c
> @@ -239,7 +239,7 @@ struct mux_data {
> u8 shift;
> };
>
> -static const __initconst struct mux_data cpu_data = {
> +static const __initconst struct mux_data cpu_mux_data = {
> .shift = 16,
> };
>
> @@ -433,7 +433,7 @@ static const __initconst struct of_device_id clk_div_match[] = {
>
> /* Matches for mux clocks */
> static const __initconst struct of_device_id clk_mux_match[] = {
> - {.compatible = "allwinner,sun4i-cpu-clk", .data = &cpu_data,},
> + {.compatible = "allwinner,sun4i-cpu-clk", .data = &cpu_mux_data,},
> {.compatible = "allwinner,sun4i-apb1-mux-clk", .data = &apb1_mux_data,},
> {}
> };
> --
> 1.8.2.3
WARNING: multiple messages have this Message-ID (diff)
From: Mike Turquette <mturquette@linaro.org>
To: "Emilio López" <emilio@elopez.com.ar>, cate@cateee.net
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
"Emilio López" <emilio@elopez.com.ar>
Subject: Re: [PATCH] clk: sunxi: "cpu_data" is defined in header files of some architectures
Date: Wed, 29 May 2013 15:48:49 -0700 [thread overview]
Message-ID: <20130529224849.6058.25112@quantum> (raw)
In-Reply-To: <1368798200-7063-1-git-send-email-emilio@elopez.com.ar>
Quoting Emilio López (2013-05-17 06:43:20)
> From: "Giacomo A. Catenazzi" <cate@cateee.net>
>
> In some architectures, the #define cpu_data is not a "macro-function",
> so the compiler will substitute the identifier with probably something
> wrong.
>
> Signed-off-by: Giacomo A. Catenazzi <cate@cateee.net>
> Signed-off-by: Emilio López <emilio@elopez.com.ar>
> [emilio@elopez.com.ar: use cpu_mux_data instead of this_cpu_data]
Taken into clk-next.
Regards,
Mike
> ---
>
> Hi Giacomo,
>
> I have taken your patch and resent it to linux-arm-kernel and Mike
> Turquette this time, but please try to use git send-email on your next
> patch.
>
> Here is a video from Greg that explains how to use it as well as other
> things (checkpatch.pl, get_maintainer.pl, etc)
>
> http://www.youtube.com/watch?v=LLBrBBImJt4
>
> Thanks! :)
>
> Emilio
>
> drivers/clk/sunxi/clk-sunxi.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/clk/sunxi/clk-sunxi.c b/drivers/clk/sunxi/clk-sunxi.c
> index 930d36f..412912b 100644
> --- a/drivers/clk/sunxi/clk-sunxi.c
> +++ b/drivers/clk/sunxi/clk-sunxi.c
> @@ -239,7 +239,7 @@ struct mux_data {
> u8 shift;
> };
>
> -static const __initconst struct mux_data cpu_data = {
> +static const __initconst struct mux_data cpu_mux_data = {
> .shift = 16,
> };
>
> @@ -433,7 +433,7 @@ static const __initconst struct of_device_id clk_div_match[] = {
>
> /* Matches for mux clocks */
> static const __initconst struct of_device_id clk_mux_match[] = {
> - {.compatible = "allwinner,sun4i-cpu-clk", .data = &cpu_data,},
> + {.compatible = "allwinner,sun4i-cpu-clk", .data = &cpu_mux_data,},
> {.compatible = "allwinner,sun4i-apb1-mux-clk", .data = &apb1_mux_data,},
> {}
> };
> --
> 1.8.2.3
next prev parent reply other threads:[~2013-05-29 22:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-17 7:02 [PATCH] drivers/clk/sunxi/clk-sunxi.c: small improvement of code Giacomo Catenazzi
2013-05-17 13:43 ` [PATCH] clk: sunxi: "cpu_data" is defined in header files of some architectures Emilio López
2013-05-17 13:43 ` Emilio López
2013-05-29 22:48 ` Mike Turquette [this message]
2013-05-29 22:48 ` Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130529224849.6058.25112@quantum \
--to=mturquette@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.