* [PATCH 07/10] libgles-omap3: Remove unnecessary inclusion of folders into package
@ 2013-05-17 16:57 Prabindh Sundareson
2013-05-29 21:17 ` Denys Dmytriyenko
0 siblings, 1 reply; 6+ messages in thread
From: Prabindh Sundareson @ 2013-05-17 16:57 UTC (permalink / raw)
To: meta-ti
Inclusion of all .so files is not necessary for the
package build.
Signed-off-by: Prabindh Sundareson <prabu@ti.com>
---
recipes-graphics/libgles/libgles-omap3-no-x.inc | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/recipes-graphics/libgles/libgles-omap3-no-x.inc b/recipes-graphics/libgles/libgles-omap3-no-x.inc
index 8e5dad6..4521d59 100644
--- a/recipes-graphics/libgles/libgles-omap3-no-x.inc
+++ b/recipes-graphics/libgles/libgles-omap3-no-x.inc
@@ -285,10 +285,6 @@ INSANE_SKIP_${PN}-linuxfbwsegl-es6 = "ldflags"
INSANE_SKIP_${PN}-linuxfbwsegl-es8 = "ldflags"
INSANE_SKIP_${PN}-tests = "ldflags"
-# Quality control is really poor on these SDKs, so hack around the latest madness:
-FILES_${PN} += "${libdir}/*.so "
-FILES_${PN}-dev = "${includedir}"
-
inherit update-rc.d
INITSCRIPT_NAME = "pvr-init"
--
1.7.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 07/10] libgles-omap3: Remove unnecessary inclusion of folders into package
2013-05-17 16:57 [PATCH 07/10] libgles-omap3: Remove unnecessary inclusion of folders into package Prabindh Sundareson
@ 2013-05-29 21:17 ` Denys Dmytriyenko
2013-05-30 3:18 ` Sundareson, Prabindh
0 siblings, 1 reply; 6+ messages in thread
From: Denys Dmytriyenko @ 2013-05-29 21:17 UTC (permalink / raw)
To: Prabindh Sundareson; +Cc: meta-ti
On Fri, May 17, 2013 at 10:27:56PM +0530, Prabindh Sundareson wrote:
> Inclusion of all .so files is not necessary for the
> package build.
>
> Signed-off-by: Prabindh Sundareson <prabu@ti.com>
> ---
> recipes-graphics/libgles/libgles-omap3-no-x.inc | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/recipes-graphics/libgles/libgles-omap3-no-x.inc b/recipes-graphics/libgles/libgles-omap3-no-x.inc
> index 8e5dad6..4521d59 100644
> --- a/recipes-graphics/libgles/libgles-omap3-no-x.inc
> +++ b/recipes-graphics/libgles/libgles-omap3-no-x.inc
> @@ -285,10 +285,6 @@ INSANE_SKIP_${PN}-linuxfbwsegl-es6 = "ldflags"
> INSANE_SKIP_${PN}-linuxfbwsegl-es8 = "ldflags"
> INSANE_SKIP_${PN}-tests = "ldflags"
>
> -# Quality control is really poor on these SDKs, so hack around the latest madness:
> -FILES_${PN} += "${libdir}/*.so "
> -FILES_${PN}-dev = "${includedir}"
I'm confused - you are removing these 2 lines in 7/10 and then immediately
re-add them back in 8/10. Why?
> inherit update-rc.d
>
> INITSCRIPT_NAME = "pvr-init"
> --
> 1.7.1
>
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 07/10] libgles-omap3: Remove unnecessary inclusion of folders into package
2013-05-29 21:17 ` Denys Dmytriyenko
@ 2013-05-30 3:18 ` Sundareson, Prabindh
2013-05-30 3:20 ` Denys Dmytriyenko
0 siblings, 1 reply; 6+ messages in thread
From: Sundareson, Prabindh @ 2013-05-30 3:18 UTC (permalink / raw)
To: Dmytriyenko, Denys; +Cc: meta-ti@yoctoproject.org
Denys,
Thanks for reviewing,
It is a simple correction. I had mistakenly removed it in the first one, and reinstated in the next one after comparing with the original patch-set. Is there anything missing you observe ?
regards,
Prabu
-----Original Message-----
From: Dmytriyenko, Denys
Sent: Thursday, May 30, 2013 2:47 AM
To: Sundareson, Prabindh
Cc: meta-ti@yoctoproject.org
Subject: Re: [meta-ti] [PATCH 07/10] libgles-omap3: Remove unnecessary inclusion of folders into package
On Fri, May 17, 2013 at 10:27:56PM +0530, Prabindh Sundareson wrote:
> Inclusion of all .so files is not necessary for the package build.
>
> Signed-off-by: Prabindh Sundareson <prabu@ti.com>
> ---
> recipes-graphics/libgles/libgles-omap3-no-x.inc | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/recipes-graphics/libgles/libgles-omap3-no-x.inc
> b/recipes-graphics/libgles/libgles-omap3-no-x.inc
> index 8e5dad6..4521d59 100644
> --- a/recipes-graphics/libgles/libgles-omap3-no-x.inc
> +++ b/recipes-graphics/libgles/libgles-omap3-no-x.inc
> @@ -285,10 +285,6 @@ INSANE_SKIP_${PN}-linuxfbwsegl-es6 = "ldflags"
> INSANE_SKIP_${PN}-linuxfbwsegl-es8 = "ldflags"
> INSANE_SKIP_${PN}-tests = "ldflags"
>
> -# Quality control is really poor on these SDKs, so hack around the latest madness:
> -FILES_${PN} += "${libdir}/*.so "
> -FILES_${PN}-dev = "${includedir}"
I'm confused - you are removing these 2 lines in 7/10 and then immediately re-add them back in 8/10. Why?
> inherit update-rc.d
>
> INITSCRIPT_NAME = "pvr-init"
> --
> 1.7.1
>
> _______________________________________________
> meta-ti mailing list
> meta-ti@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-ti
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 07/10] libgles-omap3: Remove unnecessary inclusion of folders into package
2013-05-30 3:18 ` Sundareson, Prabindh
@ 2013-05-30 3:20 ` Denys Dmytriyenko
2013-05-30 3:33 ` Sundareson, Prabindh
0 siblings, 1 reply; 6+ messages in thread
From: Denys Dmytriyenko @ 2013-05-30 3:20 UTC (permalink / raw)
To: Sundareson, Prabindh; +Cc: meta-ti@yoctoproject.org
On Wed, May 29, 2013 at 11:18:36PM -0400, Sundareson, Prabindh wrote:
> Denys,
>
> Thanks for reviewing,
>
> It is a simple correction. I had mistakenly removed it in the first one, and
> reinstated in the next one after comparing with the original patch-set. Is
> there anything missing you observe ?
You should probably squash those patches then. Otherwise look fine - I just
need to diff the first patch in the series against the original. Have you
tried passing -M to git-format-patch?
--
Denys
> -----Original Message-----
> From: Dmytriyenko, Denys
> Sent: Thursday, May 30, 2013 2:47 AM
> To: Sundareson, Prabindh
> Cc: meta-ti@yoctoproject.org
> Subject: Re: [meta-ti] [PATCH 07/10] libgles-omap3: Remove unnecessary inclusion of folders into package
>
> On Fri, May 17, 2013 at 10:27:56PM +0530, Prabindh Sundareson wrote:
> > Inclusion of all .so files is not necessary for the package build.
> >
> > Signed-off-by: Prabindh Sundareson <prabu@ti.com>
> > ---
> > recipes-graphics/libgles/libgles-omap3-no-x.inc | 4 ----
> > 1 files changed, 0 insertions(+), 4 deletions(-)
> >
> > diff --git a/recipes-graphics/libgles/libgles-omap3-no-x.inc
> > b/recipes-graphics/libgles/libgles-omap3-no-x.inc
> > index 8e5dad6..4521d59 100644
> > --- a/recipes-graphics/libgles/libgles-omap3-no-x.inc
> > +++ b/recipes-graphics/libgles/libgles-omap3-no-x.inc
> > @@ -285,10 +285,6 @@ INSANE_SKIP_${PN}-linuxfbwsegl-es6 = "ldflags"
> > INSANE_SKIP_${PN}-linuxfbwsegl-es8 = "ldflags"
> > INSANE_SKIP_${PN}-tests = "ldflags"
> >
> > -# Quality control is really poor on these SDKs, so hack around the latest madness:
> > -FILES_${PN} += "${libdir}/*.so "
> > -FILES_${PN}-dev = "${includedir}"
>
> I'm confused - you are removing these 2 lines in 7/10 and then immediately re-add them back in 8/10. Why?
>
>
> > inherit update-rc.d
> >
> > INITSCRIPT_NAME = "pvr-init"
> > --
> > 1.7.1
> >
> > _______________________________________________
> > meta-ti mailing list
> > meta-ti@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-ti
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 07/10] libgles-omap3: Remove unnecessary inclusion of folders into package
2013-05-30 3:20 ` Denys Dmytriyenko
@ 2013-05-30 3:33 ` Sundareson, Prabindh
2013-06-05 11:19 ` Sundareson, Prabindh
0 siblings, 1 reply; 6+ messages in thread
From: Sundareson, Prabindh @ 2013-05-30 3:33 UTC (permalink / raw)
To: Dmytriyenko, Denys; +Cc: meta-ti@yoctoproject.org
Hello Denys,
>> You should probably squash those patches then.
I can, with some rework. Please let me know your preference,
>> Have you tried passing -M to git-format-patch?
No. I read through the submission guidelines, and I did not see anything specific there. How does this help ? Or did you mean this in the context of the squashing ?
regards,
Prabu
-----Original Message-----
From: Dmytriyenko, Denys
Sent: Thursday, May 30, 2013 8:51 AM
To: Sundareson, Prabindh
Cc: meta-ti@yoctoproject.org
Subject: Re: [meta-ti] [PATCH 07/10] libgles-omap3: Remove unnecessary inclusion of folders into package
On Wed, May 29, 2013 at 11:18:36PM -0400, Sundareson, Prabindh wrote:
> Denys,
>
> Thanks for reviewing,
>
> It is a simple correction. I had mistakenly removed it in the first
> one, and reinstated in the next one after comparing with the original
> patch-set. Is there anything missing you observe ?
You should probably squash those patches then. Otherwise look fine - I just need to diff the first patch in the series against the original. Have you tried passing -M to git-format-patch?
--
Denys
> -----Original Message-----
> From: Dmytriyenko, Denys
> Sent: Thursday, May 30, 2013 2:47 AM
> To: Sundareson, Prabindh
> Cc: meta-ti@yoctoproject.org
> Subject: Re: [meta-ti] [PATCH 07/10] libgles-omap3: Remove unnecessary inclusion of folders into package
>
> On Fri, May 17, 2013 at 10:27:56PM +0530, Prabindh Sundareson wrote:
> > Inclusion of all .so files is not necessary for the package build.
> >
> > Signed-off-by: Prabindh Sundareson <prabu@ti.com>
> > ---
> > recipes-graphics/libgles/libgles-omap3-no-x.inc | 4 ----
> > 1 files changed, 0 insertions(+), 4 deletions(-)
> >
> > diff --git a/recipes-graphics/libgles/libgles-omap3-no-x.inc
> > b/recipes-graphics/libgles/libgles-omap3-no-x.inc
> > index 8e5dad6..4521d59 100644
> > --- a/recipes-graphics/libgles/libgles-omap3-no-x.inc
> > +++ b/recipes-graphics/libgles/libgles-omap3-no-x.inc
> > @@ -285,10 +285,6 @@ INSANE_SKIP_${PN}-linuxfbwsegl-es6 = "ldflags"
> > INSANE_SKIP_${PN}-linuxfbwsegl-es8 = "ldflags"
> > INSANE_SKIP_${PN}-tests = "ldflags"
> >
> > -# Quality control is really poor on these SDKs, so hack around the latest madness:
> > -FILES_${PN} += "${libdir}/*.so "
> > -FILES_${PN}-dev = "${includedir}"
>
> I'm confused - you are removing these 2 lines in 7/10 and then immediately re-add them back in 8/10. Why?
>
>
> > inherit update-rc.d
> >
> > INITSCRIPT_NAME = "pvr-init"
> > --
> > 1.7.1
> >
> > _______________________________________________
> > meta-ti mailing list
> > meta-ti@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-ti
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 07/10] libgles-omap3: Remove unnecessary inclusion of folders into package
2013-05-30 3:33 ` Sundareson, Prabindh
@ 2013-06-05 11:19 ` Sundareson, Prabindh
0 siblings, 0 replies; 6+ messages in thread
From: Sundareson, Prabindh @ 2013-06-05 11:19 UTC (permalink / raw)
To: Dmytriyenko, Denys; +Cc: meta-ti@yoctoproject.org
Hello Denys,
Any update on below ?
>> You should probably squash those patches then.
I can, with some rework. Please let me know your preference,
regards,
Prabu
-----Original Message-----
From: meta-ti-bounces@yoctoproject.org [mailto:meta-ti-bounces@yoctoproject.org] On Behalf Of Sundareson, Prabindh
Sent: Thursday, May 30, 2013 9:03 AM
To: Dmytriyenko, Denys
Cc: meta-ti@yoctoproject.org
Subject: Re: [meta-ti] [PATCH 07/10] libgles-omap3: Remove unnecessary inclusion of folders into package
Hello Denys,
>> You should probably squash those patches then.
I can, with some rework. Please let me know your preference,
>> Have you tried passing -M to git-format-patch?
No. I read through the submission guidelines, and I did not see anything specific there. How does this help ? Or did you mean this in the context of the squashing ?
regards,
Prabu
-----Original Message-----
From: Dmytriyenko, Denys
Sent: Thursday, May 30, 2013 8:51 AM
To: Sundareson, Prabindh
Cc: meta-ti@yoctoproject.org
Subject: Re: [meta-ti] [PATCH 07/10] libgles-omap3: Remove unnecessary inclusion of folders into package
On Wed, May 29, 2013 at 11:18:36PM -0400, Sundareson, Prabindh wrote:
> Denys,
>
> Thanks for reviewing,
>
> It is a simple correction. I had mistakenly removed it in the first
> one, and reinstated in the next one after comparing with the original
> patch-set. Is there anything missing you observe ?
You should probably squash those patches then. Otherwise look fine - I just need to diff the first patch in the series against the original. Have you tried passing -M to git-format-patch?
--
Denys
> -----Original Message-----
> From: Dmytriyenko, Denys
> Sent: Thursday, May 30, 2013 2:47 AM
> To: Sundareson, Prabindh
> Cc: meta-ti@yoctoproject.org
> Subject: Re: [meta-ti] [PATCH 07/10] libgles-omap3: Remove unnecessary
> inclusion of folders into package
>
> On Fri, May 17, 2013 at 10:27:56PM +0530, Prabindh Sundareson wrote:
> > Inclusion of all .so files is not necessary for the package build.
> >
> > Signed-off-by: Prabindh Sundareson <prabu@ti.com>
> > ---
> > recipes-graphics/libgles/libgles-omap3-no-x.inc | 4 ----
> > 1 files changed, 0 insertions(+), 4 deletions(-)
> >
> > diff --git a/recipes-graphics/libgles/libgles-omap3-no-x.inc
> > b/recipes-graphics/libgles/libgles-omap3-no-x.inc
> > index 8e5dad6..4521d59 100644
> > --- a/recipes-graphics/libgles/libgles-omap3-no-x.inc
> > +++ b/recipes-graphics/libgles/libgles-omap3-no-x.inc
> > @@ -285,10 +285,6 @@ INSANE_SKIP_${PN}-linuxfbwsegl-es6 = "ldflags"
> > INSANE_SKIP_${PN}-linuxfbwsegl-es8 = "ldflags"
> > INSANE_SKIP_${PN}-tests = "ldflags"
> >
> > -# Quality control is really poor on these SDKs, so hack around the latest madness:
> > -FILES_${PN} += "${libdir}/*.so "
> > -FILES_${PN}-dev = "${includedir}"
>
> I'm confused - you are removing these 2 lines in 7/10 and then immediately re-add them back in 8/10. Why?
>
>
> > inherit update-rc.d
> >
> > INITSCRIPT_NAME = "pvr-init"
> > --
> > 1.7.1
> >
> > _______________________________________________
> > meta-ti mailing list
> > meta-ti@yoctoproject.org
> > https://lists.yoctoproject.org/listinfo/meta-ti
_______________________________________________
meta-ti mailing list
meta-ti@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-ti
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-06-05 11:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-17 16:57 [PATCH 07/10] libgles-omap3: Remove unnecessary inclusion of folders into package Prabindh Sundareson
2013-05-29 21:17 ` Denys Dmytriyenko
2013-05-30 3:18 ` Sundareson, Prabindh
2013-05-30 3:20 ` Denys Dmytriyenko
2013-05-30 3:33 ` Sundareson, Prabindh
2013-06-05 11:19 ` Sundareson, Prabindh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.