All of lore.kernel.org
 help / color / mirror / Atom feed
From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH RFC 1/6] [HACK!] arm64/xen: create links to arch/arm include files and Xen code
Date: Fri, 31 May 2013 14:10:38 +0100	[thread overview]
Message-ID: <20130531131038.GA15551@arm.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1305311259090.4799@kaball.uk.xensource.com>

On Fri, May 31, 2013 at 01:02:04PM +0100, Stefano Stabellini wrote:
> On Fri, 31 May 2013, Catalin Marinas wrote:
> > On Thu, May 30, 2013 at 05:18:28PM +0100, Stefano Stabellini wrote:
> > > Most of Xen support for ARM is common between ARMv7 and ARMv8.
> > > Create links to the code under arch/arm (bleah).
> > > 
> > > Other, probably better alternatives:
> > > 
> > > - move the code to a different location, maybe the header files to
> > > include/xen/arm and the code to drivers/xen/arm (still pretty ugly)?
> > > 
> > > - create a copy of the code to arch/arm64 (even worse);
> > 
> > KVM handles this in the Makefile by referencing back to arch/arm or even
> > the generic kvm directory. I think that's the 'cleanest' ;)
> 
> Do you mean creating links in the Makefile or generating header file
> copies from the Makefile?
> Or do you mean using something like "-I arch/arm/include/asm/xen" in the
> arch/arm64 Makefile?

I meant C files being compiled directly from arch/arm (no links).

For headers, if they are specific to arm or arm64, just copy the header
in each place (e.g. not using regs->pstate in the arch/arm code with
#ifdef's). For the rest, if they cannot be made generic, one way is to
have a dummy file including the arm equivalent:

#include <../../arm/include/asm/xen/events.h>

Passing -I is dangerous as you actually need "-I arch/arm/include" which
could bring other files.

-- 
Catalin

WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Will Deacon <Will.Deacon@arm.com>,
	"Ian.Campbell@citrix.com" <Ian.Campbell@citrix.com>,
	"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>
Subject: Re: [PATCH RFC 1/6] [HACK!] arm64/xen: create links to arch/arm include files and Xen code
Date: Fri, 31 May 2013 14:10:38 +0100	[thread overview]
Message-ID: <20130531131038.GA15551@arm.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1305311259090.4799@kaball.uk.xensource.com>

On Fri, May 31, 2013 at 01:02:04PM +0100, Stefano Stabellini wrote:
> On Fri, 31 May 2013, Catalin Marinas wrote:
> > On Thu, May 30, 2013 at 05:18:28PM +0100, Stefano Stabellini wrote:
> > > Most of Xen support for ARM is common between ARMv7 and ARMv8.
> > > Create links to the code under arch/arm (bleah).
> > > 
> > > Other, probably better alternatives:
> > > 
> > > - move the code to a different location, maybe the header files to
> > > include/xen/arm and the code to drivers/xen/arm (still pretty ugly)?
> > > 
> > > - create a copy of the code to arch/arm64 (even worse);
> > 
> > KVM handles this in the Makefile by referencing back to arch/arm or even
> > the generic kvm directory. I think that's the 'cleanest' ;)
> 
> Do you mean creating links in the Makefile or generating header file
> copies from the Makefile?
> Or do you mean using something like "-I arch/arm/include/asm/xen" in the
> arch/arm64 Makefile?

I meant C files being compiled directly from arch/arm (no links).

For headers, if they are specific to arm or arm64, just copy the header
in each place (e.g. not using regs->pstate in the arch/arm code with
#ifdef's). For the rest, if they cannot be made generic, one way is to
have a dummy file including the arm equivalent:

#include <../../arm/include/asm/xen/events.h>

Passing -I is dangerous as you actually need "-I arch/arm/include" which
could bring other files.

-- 
Catalin

WARNING: multiple messages have this Message-ID (diff)
From: Catalin Marinas <catalin.marinas@arm.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	"Ian.Campbell@citrix.com" <Ian.Campbell@citrix.com>,
	"konrad.wilk@oracle.com" <konrad.wilk@oracle.com>,
	Will Deacon <Will.Deacon@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH RFC 1/6] [HACK!] arm64/xen: create links to arch/arm include files and Xen code
Date: Fri, 31 May 2013 14:10:38 +0100	[thread overview]
Message-ID: <20130531131038.GA15551@arm.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1305311259090.4799@kaball.uk.xensource.com>

On Fri, May 31, 2013 at 01:02:04PM +0100, Stefano Stabellini wrote:
> On Fri, 31 May 2013, Catalin Marinas wrote:
> > On Thu, May 30, 2013 at 05:18:28PM +0100, Stefano Stabellini wrote:
> > > Most of Xen support for ARM is common between ARMv7 and ARMv8.
> > > Create links to the code under arch/arm (bleah).
> > > 
> > > Other, probably better alternatives:
> > > 
> > > - move the code to a different location, maybe the header files to
> > > include/xen/arm and the code to drivers/xen/arm (still pretty ugly)?
> > > 
> > > - create a copy of the code to arch/arm64 (even worse);
> > 
> > KVM handles this in the Makefile by referencing back to arch/arm or even
> > the generic kvm directory. I think that's the 'cleanest' ;)
> 
> Do you mean creating links in the Makefile or generating header file
> copies from the Makefile?
> Or do you mean using something like "-I arch/arm/include/asm/xen" in the
> arch/arm64 Makefile?

I meant C files being compiled directly from arch/arm (no links).

For headers, if they are specific to arm or arm64, just copy the header
in each place (e.g. not using regs->pstate in the arch/arm code with
#ifdef's). For the rest, if they cannot be made generic, one way is to
have a dummy file including the arm equivalent:

#include <../../arm/include/asm/xen/events.h>

Passing -I is dangerous as you actually need "-I arch/arm/include" which
could bring other files.

-- 
Catalin

  reply	other threads:[~2013-05-31 13:10 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-30 16:18 [PATCH RFC 0/6] Introduce Xen support to ARM64 Stefano Stabellini
2013-05-30 16:18 ` Stefano Stabellini
2013-05-30 16:18 ` Stefano Stabellini
2013-05-30 16:18 ` [PATCH RFC 1/6] [HACK!] arm64/xen: create links to arch/arm include files and Xen code Stefano Stabellini
2013-05-30 16:18   ` Stefano Stabellini
2013-05-30 16:18   ` Stefano Stabellini
2013-05-31 10:36   ` Catalin Marinas
2013-05-31 10:36     ` Catalin Marinas
2013-05-31 12:02     ` Stefano Stabellini
2013-05-31 12:02       ` Stefano Stabellini
2013-05-31 13:10       ` Catalin Marinas [this message]
2013-05-31 13:10         ` Catalin Marinas
2013-05-31 13:10         ` Catalin Marinas
2013-05-31 15:20         ` Stefano Stabellini
2013-05-31 15:20           ` Stefano Stabellini
2013-05-30 16:18 ` [PATCH RFC 2/6] arm64/xen: arm/xen header changes to compile on arm64 Stefano Stabellini
2013-05-30 16:18   ` Stefano Stabellini
2013-05-30 16:18   ` Stefano Stabellini
2013-05-31 10:43   ` Catalin Marinas
2013-05-31 10:43     ` Catalin Marinas
2013-05-31 10:43     ` Catalin Marinas
2013-05-31 13:25     ` Stefano Stabellini
2013-05-31 13:25       ` Stefano Stabellini
2013-05-30 16:18 ` [PATCH RFC 3/6] arm64/xen: use XEN_IO_PROTO_ABI_ARM on ARM64 Stefano Stabellini
2013-05-30 16:18   ` Stefano Stabellini
2013-05-30 16:18   ` Stefano Stabellini
2013-05-30 16:18 ` [PATCH RFC 4/6] arm64/xen: introduce asm/hypervisor.h and sys_bitops.h Stefano Stabellini
2013-05-30 16:18   ` Stefano Stabellini
2013-05-30 16:18   ` Stefano Stabellini
2013-05-30 16:18 ` [PATCH RFC 5/6] arm64/xen: implement xen_remap on arm64 Stefano Stabellini
2013-05-30 16:18   ` Stefano Stabellini
2013-05-30 16:18   ` Stefano Stabellini
2013-05-31 10:59   ` Catalin Marinas
2013-05-31 10:59     ` Catalin Marinas
2013-05-31 10:59     ` Catalin Marinas
2013-05-31 13:21     ` Stefano Stabellini
2013-05-31 13:21       ` Stefano Stabellini
2013-05-31 14:16       ` Catalin Marinas
2013-05-31 14:16         ` Catalin Marinas
2013-05-31 14:50         ` Stefano Stabellini
2013-05-31 14:50           ` Stefano Stabellini
2013-05-31 15:23           ` Stefano Stabellini
2013-05-31 15:23             ` Stefano Stabellini
2013-05-31 15:56             ` Catalin Marinas
2013-05-31 15:56               ` Catalin Marinas
2013-05-31 15:56               ` Catalin Marinas
2013-05-30 16:18 ` [PATCH RFC 6/6] arm64/xen: introduce CONFIG_XEN and hypercall.S on ARM64 Stefano Stabellini
2013-05-30 16:18   ` Stefano Stabellini
2013-05-30 16:18   ` Stefano Stabellini
2013-05-31 11:02   ` Catalin Marinas
2013-05-31 11:02     ` Catalin Marinas
2013-05-31 11:02     ` Catalin Marinas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130531131038.GA15551@arm.com \
    --to=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.