From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>
To: Christian Daudt <csd-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
Cc: linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jerry Huang
<Chang-Ming.Huang-KZfg59tc24xl57MIdRCFDg@public.gmane.org>,
Wei WANG <wei_wang-kXabqFNEczNtrwSWzY7KCg@public.gmane.org>,
matt.porter-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
Kevin Liu <kliu5-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>,
Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Viresh Kumar
<viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Chris Ball <cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Sascha Hauer <s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
Bill Pemberton <wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Anton Vorontsov
<avorontsov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Guennadi Liakhovetski
<g.liakhovetski-Mmb7MZpHnFY@public.gmane.org>
Subject: Re: [PATCH V4 2/3] ARM: mmc: bcm281xx SDHCI driver
Date: Sat, 1 Jun 2013 22:13:47 +0200 [thread overview]
Message-ID: <201306012213.47386.arnd@arndb.de> (raw)
In-Reply-To: <51A93DA0.3070909-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
On Saturday 01 June 2013, Christian Daudt wrote:
> I looked into it and it can replace just about everything that our own
> dt parsing code is doing. The only problem is with cd_gpio. If I call
> mmc_of_parse, then it will install its own irq handler for cd gpio, and
> our driver needs a different handler. the mmc irq handler can call a
> card_event callback, but that is already pointing to sdhci_card_event.
> So the only way I can use mmc_of_parse that I can see is by adding a
> flag to it to skip cd_gpio parsing which only this driver will then set
> to true. Any other ideas ?
Can't you add a callback handler into sdhci_card_event that can call
a platform specific function?
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4 2/3] ARM: mmc: bcm281xx SDHCI driver
Date: Sat, 1 Jun 2013 22:13:47 +0200 [thread overview]
Message-ID: <201306012213.47386.arnd@arndb.de> (raw)
In-Reply-To: <51A93DA0.3070909@broadcom.com>
On Saturday 01 June 2013, Christian Daudt wrote:
> I looked into it and it can replace just about everything that our own
> dt parsing code is doing. The only problem is with cd_gpio. If I call
> mmc_of_parse, then it will install its own irq handler for cd gpio, and
> our driver needs a different handler. the mmc irq handler can call a
> card_event callback, but that is already pointing to sdhci_card_event.
> So the only way I can use mmc_of_parse that I can see is by adding a
> flag to it to skip cd_gpio parsing which only this driver will then set
> to true. Any other ideas ?
Can't you add a callback handler into sdhci_card_event that can call
a platform specific function?
Arnd
next prev parent reply other threads:[~2013-06-01 20:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-29 20:50 [PATCH V4 1/3] mmc: sdhci: Add size for caller in init+register Christian Daudt
2013-05-29 20:50 ` Christian Daudt
2013-05-29 20:50 ` [PATCH V4 2/3] ARM: mmc: bcm281xx SDHCI driver Christian Daudt
2013-05-29 20:50 ` Christian Daudt
[not found] ` <1369860607-25572-2-git-send-email-csd-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2013-05-31 16:15 ` Chris Ball
2013-05-31 16:15 ` Chris Ball
2013-06-01 0:17 ` Christian Daudt
2013-06-01 0:17 ` Christian Daudt
[not found] ` <51A93DA0.3070909-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2013-06-01 20:13 ` Arnd Bergmann [this message]
2013-06-01 20:13 ` Arnd Bergmann
2013-06-04 14:19 ` Christian Daudt
2013-06-04 14:19 ` Christian Daudt
2013-05-29 20:50 ` [PATCH V4 3/3] ARM: mmc: bcm281xx SDHCI driver (dt mods) Christian Daudt
2013-05-29 20:50 ` Christian Daudt
2013-05-31 15:41 ` [PATCH V4 1/3] mmc: sdhci: Add size for caller in init+register Christian Daudt
2013-05-31 15:41 ` Christian Daudt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201306012213.47386.arnd@arndb.de \
--to=arnd-r2ngtmty4d4@public.gmane.org \
--cc=Chang-Ming.Huang-KZfg59tc24xl57MIdRCFDg@public.gmane.org \
--cc=avorontsov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org \
--cc=cjb-2X9k7bc8m7Mdnm+yROfE0A@public.gmane.org \
--cc=csd-dY08KVG/lbpWk0Htik3J/w@public.gmane.org \
--cc=devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=g.liakhovetski-Mmb7MZpHnFY@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=kliu5-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org \
--cc=lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org \
--cc=linux-mmc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt.porter-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org \
--cc=s.hauer-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
--cc=viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=wei_wang-kXabqFNEczNtrwSWzY7KCg@public.gmane.org \
--cc=wfp5p-4Ng6DfrEGID2fBVCVOL8/A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.