All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chirag Kantharia <chirag.kantharia@hp.com>
Cc: iss_storagedev@hp.com, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: [patch] cpqarray: info leak in ida_locked_ioctl()
Date: Mon, 03 Jun 2013 09:25:16 +0000	[thread overview]
Message-ID: <20130603092516.GC16171@debian> (raw)

The pciinfo struct has a two byte hole after ->dev_fn so stack
information could be leaked to the user.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/block/cpqarray.c b/drivers/block/cpqarray.c
index 639d26b..2b94403 100644
--- a/drivers/block/cpqarray.c
+++ b/drivers/block/cpqarray.c
@@ -1193,6 +1193,7 @@ out_passthru:
 		ida_pci_info_struct pciinfo;
 
 		if (!arg) return -EINVAL;
+		memset(&pciinfo, 0, sizeof(pciinfo));
 		pciinfo.bus = host->pci_dev->bus->number;
 		pciinfo.dev_fn = host->pci_dev->devfn;
 		pciinfo.board_id = host->board_id;

WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chirag Kantharia <chirag.kantharia@hp.com>
Cc: iss_storagedev@hp.com, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: [patch] cpqarray: info leak in ida_locked_ioctl()
Date: Mon, 3 Jun 2013 12:25:16 +0300	[thread overview]
Message-ID: <20130603092516.GC16171@debian> (raw)

The pciinfo struct has a two byte hole after ->dev_fn so stack
information could be leaked to the user.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/block/cpqarray.c b/drivers/block/cpqarray.c
index 639d26b..2b94403 100644
--- a/drivers/block/cpqarray.c
+++ b/drivers/block/cpqarray.c
@@ -1193,6 +1193,7 @@ out_passthru:
 		ida_pci_info_struct pciinfo;
 
 		if (!arg) return -EINVAL;
+		memset(&pciinfo, 0, sizeof(pciinfo));
 		pciinfo.bus = host->pci_dev->bus->number;
 		pciinfo.dev_fn = host->pci_dev->devfn;
 		pciinfo.board_id = host->board_id;

             reply	other threads:[~2013-06-03  9:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-03  9:25 Dan Carpenter [this message]
2013-06-03  9:25 ` [patch] cpqarray: info leak in ida_locked_ioctl() Dan Carpenter
2013-09-11  7:38 ` [patch -resend] " Dan Carpenter
2013-09-11  7:38   ` Dan Carpenter
2013-09-11 17:23   ` Miller, Mike (OS Dev)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130603092516.GC16171@debian \
    --to=dan.carpenter@oracle.com \
    --cc=chirag.kantharia@hp.com \
    --cc=iss_storagedev@hp.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.